Conversation
|
Hello @Didou09! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2019-11-22 15:19:38 UTC |
…p, requirements, conda_recipe/meta.yaml)
Codecov Report
@@ Coverage Diff @@
## devel #274 +/- ##
=======================================
Coverage 41.46% 41.46%
=======================================
Files 79 79
Lines 23228 23228
=======================================
Hits 9632 9632
Misses 13596 13596
Continue to review full report at Codecov.
|
|
I'm not sure this would work... |
…xcept at import time
…xcept at import time also for build_ext
|
I wouldn't change the Cython/cython if they were not the issue in the first place... what do you think @Didou09 |
…xcept at import time also for np.get_include()
|
Fall back to a more generic and modern solution as recommended in setuptools's answer to the opened issue (see few last comments on Issue #272 ) Closing the PR as we are changing solution |
…tions showed that there exist a recommended solution from PEP517 and PEP518: introduce a tofu.toml file for listing build-time dependencies. Opening issue #276 accordingly
|
Sorry, should have merged this before closing, there are still interesting changes (try / except + setup_requires) that can be useful. |
|
To be clairifie din teh future branch @lasofivec : are the changes implemented here (try / except func + setup_requires) still useful / necessary even with the toml file ? |
4 participants
Fixes, in devel, issue #272 to make pip install easier