Skip to content
This repository was archived by the owner on Mar 20, 2025. It is now read-only.

feat: Remove the core scripts#7

Merged
psionikangel merged 2 commits intoVilledeMontreal:betafrom
electrotype:feature/no-more-core-scripts
Apr 8, 2022
Merged

feat: Remove the core scripts#7
psionikangel merged 2 commits intoVilledeMontreal:betafrom
electrotype:feature/no-more-core-scripts

Conversation

@electrotype
Copy link
Copy Markdown
Contributor

@electrotype electrotype commented Apr 7, 2022

After discussion, we decided that the core scripts provided by this library were more confusing than useful. Indeed, a developer working on a project using this library may want to be able to easily view the code of all scripts he is running. By bundeling some scripts here, we have made this a little difficult.

Now, these core scripts (test-units, lint, watch, etc) will have to be defined in the projects themselves, like any other script.

Instead of providing the scripts in this library, we will add them to the API and Library templates.

@electrotype electrotype force-pushed the feature/no-more-core-scripts branch from f8beea2 to 2b10aa2 Compare April 7, 2022 23:01
feat: Remove the core scripts.
f85e5ea 
After discussion, we decided that the core scripts provided by this library were more confusing than useful. Indeed, a developer working on a project using this library may want to view the code of all scripts he is running. By bundeling some core scripts here, we have made this a little difficult.

Now, these core scripts (`test-units`, `lint`, `watch`, etc) will have to be defined *in the projects themselves*, like any other script.

Instead of providing the scripts in this library, we will add them to the API and Library templates.

Signed-off-by: Julien Lamarre <julien.lamarre@montreal.ca>
@electrotype electrotype force-pushed the feature/no-more-core-scripts branch from 2b10aa2 to f85e5ea Compare April 7, 2022 23:23
fix: remove some remaining "tslint" references
bdef040 
Signed-off-by: Julien Lamarre <julien.lamarre@montreal.ca>
@psionikangel
Copy link
Copy Markdown
Member

psionikangel commented Apr 8, 2022

Excellent travail @electrotype ! Tout passe de mon côté. Alors je vais merger et faire une nouvelle release.

@psionikangel psionikangel merged commit da2136a into VilledeMontreal:beta Apr 8, 2022
psionikangel added a commit that referenced this pull request Apr 25, 2022
@psionikangel @etiennegingras @electrotype
Merging Beta to main branch (#10)
728acdd 
* ci: eslint (#2)

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

Co-authored-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* fix: allowJs true (#3)

* ci: eslint

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* fix: allowJs true

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

Co-authored-by: uginget <etienne.gingras@ville.montreal.qc.ca>
Co-authored-by: Jérémie Carpentier-Roy <jeremie.carpentier-roy@montreal.ca>

* Beta 2 (#4)

* ci: eslint

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* fix: allowJs true

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* fix: run.js if simplification

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* version beta-2

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

Co-authored-by: uginget <etienne.gingras@ville.montreal.qc.ca>
Co-authored-by: Jérémie Carpentier-Roy <jeremie.carpentier-roy@montreal.ca>

* ci: eslint (#2)

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

Co-authored-by: uginget <etienne.gingras@ville.montreal.qc.ca>
Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* fix: allowJs true (#3)

* ci: eslint

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* fix: allowJs true

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

Co-authored-by: uginget <etienne.gingras@ville.montreal.qc.ca>
Co-authored-by: Jérémie Carpentier-Roy <jeremie.carpentier-roy@montreal.ca>
Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* ci: eslint

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* fix: allowJs true

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* fix: run.js if simplification

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* version beta-2

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* remove tslint and prettier from lint-config and install eslint/prettier

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* change version for 2.0.0

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* elvis operator allowed

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* feat: Remove the core scripts (#7)

* feat: Remove the core scripts.

After discussion, we decided that the core scripts provided by this library were more confusing than useful. Indeed, a developer working on a project using this library may want to view the code of all scripts he is running. By bundeling some core scripts here, we have made this a little difficult.

Now, these core scripts (`test-units`, `lint`, `watch`, etc) will have to be defined *in the projects themselves*, like any other script.

Instead of providing the scripts in this library, we will add them to the API and Library templates.

Signed-off-by: Julien Lamarre <julien.lamarre@montreal.ca>

* Release v2.1.0-beta

Signed-off-by: Jérémie Carpentier-Roy <jeremie.carpentier-roy@montreal.ca>

* * fix: Typescript typings files generation (#8)

Signed-off-by: Julien Lamarre <julien.lamarre@montreal.ca>

Co-authored-by: Julien Lamarre <julien.lamarre@montreal.ca>

* Bump to version 2.1.1-beta

Signed-off-by: Jérémie Carpentier-Roy <jeremie.carpentier-roy@montreal.ca>

* Include run js in build (#9)

* * fix: Typescript typings files generation

Signed-off-by: Julien Lamarre <julien.lamarre@montreal.ca>

* fix: The "src/run.js" was not included in the build

Signed-off-by: Julien Lamarre <julien.lamarre@montreal.ca>

Co-authored-by: Julien Lamarre <julien.lamarre@montreal.ca>

* Bump version to 2.1.2-beta

Signed-off-by: Jérémie Carpentier-Roy <jeremie.carpentier-roy@montreal.ca>

Co-authored-by: etiennegingras <42901019+etiennegingras@users.noreply.github.com>
Co-authored-by: uginget <etienne.gingras@ville.montreal.qc.ca>
Co-authored-by: Electro Type <electrotype@gmail.com>
Co-authored-by: Julien Lamarre <julien.lamarre@montreal.ca>
psionikangel added a commit that referenced this pull request May 2, 2022
@electrotype @etiennegingras @psionikangel
fix: Possible error when there are no devDependencies (#14)
9feecd7 
* ci: eslint (#2)

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

Co-authored-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* fix: allowJs true (#3)

* ci: eslint

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* fix: allowJs true

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

Co-authored-by: uginget <etienne.gingras@ville.montreal.qc.ca>
Co-authored-by: Jérémie Carpentier-Roy <jeremie.carpentier-roy@montreal.ca>

* Beta 2 (#4)

* ci: eslint

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* fix: allowJs true

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* fix: run.js if simplification

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* version beta-2

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

Co-authored-by: uginget <etienne.gingras@ville.montreal.qc.ca>
Co-authored-by: Jérémie Carpentier-Roy <jeremie.carpentier-roy@montreal.ca>

* ci: eslint (#2)

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

Co-authored-by: uginget <etienne.gingras@ville.montreal.qc.ca>
Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* fix: allowJs true (#3)

* ci: eslint

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* fix: allowJs true

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

Co-authored-by: uginget <etienne.gingras@ville.montreal.qc.ca>
Co-authored-by: Jérémie Carpentier-Roy <jeremie.carpentier-roy@montreal.ca>
Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* ci: eslint

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* fix: allowJs true

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* fix: run.js if simplification

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* version beta-2

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* remove tslint and prettier from lint-config and install eslint/prettier

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* change version for 2.0.0

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* elvis operator allowed

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* feat: Remove the core scripts (#7)

* feat: Remove the core scripts.

After discussion, we decided that the core scripts provided by this library were more confusing than useful. Indeed, a developer working on a project using this library may want to view the code of all scripts he is running. By bundeling some core scripts here, we have made this a little difficult.

Now, these core scripts (`test-units`, `lint`, `watch`, etc) will have to be defined *in the projects themselves*, like any other script.

Instead of providing the scripts in this library, we will add them to the API and Library templates.

Signed-off-by: Julien Lamarre <julien.lamarre@montreal.ca>

* Release v2.1.0-beta

Signed-off-by: Jérémie Carpentier-Roy <jeremie.carpentier-roy@montreal.ca>

* * fix: Typescript typings files generation (#8)

Signed-off-by: Julien Lamarre <julien.lamarre@montreal.ca>

Co-authored-by: Julien Lamarre <julien.lamarre@montreal.ca>

* Bump to version 2.1.1-beta

Signed-off-by: Jérémie Carpentier-Roy <jeremie.carpentier-roy@montreal.ca>

* Include run js in build (#9)

* * fix: Typescript typings files generation

Signed-off-by: Julien Lamarre <julien.lamarre@montreal.ca>

* fix: The "src/run.js" was not included in the build

Signed-off-by: Julien Lamarre <julien.lamarre@montreal.ca>

Co-authored-by: Julien Lamarre <julien.lamarre@montreal.ca>

* Bump version to 2.1.2-beta

Signed-off-by: Jérémie Carpentier-Roy <jeremie.carpentier-roy@montreal.ca>

* fix: Possible error when there are no devDependencies

Fix for the rare projects that would use the scripting lib but without having any `devDependencies` in their "package.json".

Signed-off-by: Julien Lamarre <julien.lamarre@montreal.ca>

Co-authored-by: etiennegingras <42901019+etiennegingras@users.noreply.github.com>
Co-authored-by: uginget <etienne.gingras@ville.montreal.qc.ca>
Co-authored-by: Jérémie Carpentier-Roy <jeremie.carpentier-roy@montreal.ca>
Co-authored-by: Jérémie Carpentier-Roy <jeremie.carpentier.roy@gmail.com>
Co-authored-by: Julien Lamarre <julien.lamarre@montreal.ca>
galak75 pushed a commit to galak75/node-scripting that referenced this pull request Nov 18, 2022
@psionikangel @etiennegingras
@electrotype @galak75
Merging Beta to main branch (VilledeMontreal#10)
ae68b6b 
* ci: eslint (#2)

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

Co-authored-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* fix: allowJs true (#3)

* ci: eslint

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* fix: allowJs true

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

Co-authored-by: uginget <etienne.gingras@ville.montreal.qc.ca>
Co-authored-by: Jérémie Carpentier-Roy <jeremie.carpentier-roy@montreal.ca>

* Beta 2 (#4)

* ci: eslint

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* fix: allowJs true

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* fix: run.js if simplification

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* version beta-2

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

Co-authored-by: uginget <etienne.gingras@ville.montreal.qc.ca>
Co-authored-by: Jérémie Carpentier-Roy <jeremie.carpentier-roy@montreal.ca>

* ci: eslint (#2)

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

Co-authored-by: uginget <etienne.gingras@ville.montreal.qc.ca>
Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* fix: allowJs true (#3)

* ci: eslint

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* fix: allowJs true

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

Co-authored-by: uginget <etienne.gingras@ville.montreal.qc.ca>
Co-authored-by: Jérémie Carpentier-Roy <jeremie.carpentier-roy@montreal.ca>
Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* ci: eslint

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* fix: allowJs true

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* fix: run.js if simplification

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* version beta-2

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* remove tslint and prettier from lint-config and install eslint/prettier

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* change version for 2.0.0

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* elvis operator allowed

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* feat: Remove the core scripts (VilledeMontreal#7)

* feat: Remove the core scripts.

After discussion, we decided that the core scripts provided by this library were more confusing than useful. Indeed, a developer working on a project using this library may want to view the code of all scripts he is running. By bundeling some core scripts here, we have made this a little difficult.

Now, these core scripts (`test-units`, `lint`, `watch`, etc) will have to be defined *in the projects themselves*, like any other script.

Instead of providing the scripts in this library, we will add them to the API and Library templates.

Signed-off-by: Julien Lamarre <julien.lamarre@montreal.ca>

* Release v2.1.0-beta

Signed-off-by: Jérémie Carpentier-Roy <jeremie.carpentier-roy@montreal.ca>

* * fix: Typescript typings files generation (VilledeMontreal#8)

Signed-off-by: Julien Lamarre <julien.lamarre@montreal.ca>

Co-authored-by: Julien Lamarre <julien.lamarre@montreal.ca>

* Bump to version 2.1.1-beta

Signed-off-by: Jérémie Carpentier-Roy <jeremie.carpentier-roy@montreal.ca>

* Include run js in build (VilledeMontreal#9)

* * fix: Typescript typings files generation

Signed-off-by: Julien Lamarre <julien.lamarre@montreal.ca>

* fix: The "src/run.js" was not included in the build

Signed-off-by: Julien Lamarre <julien.lamarre@montreal.ca>

Co-authored-by: Julien Lamarre <julien.lamarre@montreal.ca>

* Bump version to 2.1.2-beta

Signed-off-by: Jérémie Carpentier-Roy <jeremie.carpentier-roy@montreal.ca>

Co-authored-by: etiennegingras <42901019+etiennegingras@users.noreply.github.com>
Co-authored-by: uginget <etienne.gingras@ville.montreal.qc.ca>
Co-authored-by: Electro Type <electrotype@gmail.com>
Co-authored-by: Julien Lamarre <julien.lamarre@montreal.ca>
galak75 pushed a commit to galak75/node-scripting that referenced this pull request Nov 18, 2022
@electrotype @etiennegingras
@psionikangel @galak75
fix: Possible error when there are no devDependencies (VilledeMontrea…
dd1c384 
…l#14)

* ci: eslint (#2)

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

Co-authored-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* fix: allowJs true (#3)

* ci: eslint

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* fix: allowJs true

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

Co-authored-by: uginget <etienne.gingras@ville.montreal.qc.ca>
Co-authored-by: Jérémie Carpentier-Roy <jeremie.carpentier-roy@montreal.ca>

* Beta 2 (#4)

* ci: eslint

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* fix: allowJs true

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* fix: run.js if simplification

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* version beta-2

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

Co-authored-by: uginget <etienne.gingras@ville.montreal.qc.ca>
Co-authored-by: Jérémie Carpentier-Roy <jeremie.carpentier-roy@montreal.ca>

* ci: eslint (#2)

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

Co-authored-by: uginget <etienne.gingras@ville.montreal.qc.ca>
Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* fix: allowJs true (#3)

* ci: eslint

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* fix: allowJs true

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

Co-authored-by: uginget <etienne.gingras@ville.montreal.qc.ca>
Co-authored-by: Jérémie Carpentier-Roy <jeremie.carpentier-roy@montreal.ca>
Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* ci: eslint

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* fix: allowJs true

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* fix: run.js if simplification

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* version beta-2

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* remove tslint and prettier from lint-config and install eslint/prettier

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* change version for 2.0.0

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* elvis operator allowed

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* feat: Remove the core scripts (VilledeMontreal#7)

* feat: Remove the core scripts.

After discussion, we decided that the core scripts provided by this library were more confusing than useful. Indeed, a developer working on a project using this library may want to view the code of all scripts he is running. By bundeling some core scripts here, we have made this a little difficult.

Now, these core scripts (`test-units`, `lint`, `watch`, etc) will have to be defined *in the projects themselves*, like any other script.

Instead of providing the scripts in this library, we will add them to the API and Library templates.

Signed-off-by: Julien Lamarre <julien.lamarre@montreal.ca>

* Release v2.1.0-beta

Signed-off-by: Jérémie Carpentier-Roy <jeremie.carpentier-roy@montreal.ca>

* * fix: Typescript typings files generation (VilledeMontreal#8)

Signed-off-by: Julien Lamarre <julien.lamarre@montreal.ca>

Co-authored-by: Julien Lamarre <julien.lamarre@montreal.ca>

* Bump to version 2.1.1-beta

Signed-off-by: Jérémie Carpentier-Roy <jeremie.carpentier-roy@montreal.ca>

* Include run js in build (VilledeMontreal#9)

* * fix: Typescript typings files generation

Signed-off-by: Julien Lamarre <julien.lamarre@montreal.ca>

* fix: The "src/run.js" was not included in the build

Signed-off-by: Julien Lamarre <julien.lamarre@montreal.ca>

Co-authored-by: Julien Lamarre <julien.lamarre@montreal.ca>

* Bump version to 2.1.2-beta

Signed-off-by: Jérémie Carpentier-Roy <jeremie.carpentier-roy@montreal.ca>

* fix: Possible error when there are no devDependencies

Fix for the rare projects that would use the scripting lib but without having any `devDependencies` in their "package.json".

Signed-off-by: Julien Lamarre <julien.lamarre@montreal.ca>

Co-authored-by: etiennegingras <42901019+etiennegingras@users.noreply.github.com>
Co-authored-by: uginget <etienne.gingras@ville.montreal.qc.ca>
Co-authored-by: Jérémie Carpentier-Roy <jeremie.carpentier-roy@montreal.ca>
Co-authored-by: Jérémie Carpentier-Roy <jeremie.carpentier.roy@gmail.com>
Co-authored-by: Julien Lamarre <julien.lamarre@montreal.ca>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@electrotype @psionikangel