This repository was archived by the owner on Mar 20, 2025. It is now read-only.
Fix declaration files generation#8
Merged
psionikangel merged 1 commit intoVilledeMontreal:betafrom Apr 11, 2022
Merged
Conversation
Signed-off-by: Julien Lamarre <julien.lamarre@montreal.ca>
electrotype
force-pushed
the
feature/fix-declaration-files-generation
branch
from
1ebf1aa to
8439455
Compare
psionikangel
added a commit
that referenced
this pull request
Apr 25, 2022
* ci: eslint (#2) Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> Co-authored-by: uginget <etienne.gingras@ville.montreal.qc.ca> * fix: allowJs true (#3) * ci: eslint Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> * fix: allowJs true Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> Co-authored-by: uginget <etienne.gingras@ville.montreal.qc.ca> Co-authored-by: Jérémie Carpentier-Roy <jeremie.carpentier-roy@montreal.ca> * Beta 2 (#4) * ci: eslint Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> * fix: allowJs true Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> * fix: run.js if simplification Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> * version beta-2 Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> Co-authored-by: uginget <etienne.gingras@ville.montreal.qc.ca> Co-authored-by: Jérémie Carpentier-Roy <jeremie.carpentier-roy@montreal.ca> * ci: eslint (#2) Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> Co-authored-by: uginget <etienne.gingras@ville.montreal.qc.ca> Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> * fix: allowJs true (#3) * ci: eslint Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> * fix: allowJs true Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> Co-authored-by: uginget <etienne.gingras@ville.montreal.qc.ca> Co-authored-by: Jérémie Carpentier-Roy <jeremie.carpentier-roy@montreal.ca> Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> * ci: eslint Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> * fix: allowJs true Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> * fix: run.js if simplification Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> * version beta-2 Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> * remove tslint and prettier from lint-config and install eslint/prettier Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> * change version for 2.0.0 Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> * elvis operator allowed Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> * feat: Remove the core scripts (#7) * feat: Remove the core scripts. After discussion, we decided that the core scripts provided by this library were more confusing than useful. Indeed, a developer working on a project using this library may want to view the code of all scripts he is running. By bundeling some core scripts here, we have made this a little difficult. Now, these core scripts (`test-units`, `lint`, `watch`, etc) will have to be defined *in the projects themselves*, like any other script. Instead of providing the scripts in this library, we will add them to the API and Library templates. Signed-off-by: Julien Lamarre <julien.lamarre@montreal.ca> * Release v2.1.0-beta Signed-off-by: Jérémie Carpentier-Roy <jeremie.carpentier-roy@montreal.ca> * * fix: Typescript typings files generation (#8) Signed-off-by: Julien Lamarre <julien.lamarre@montreal.ca> Co-authored-by: Julien Lamarre <julien.lamarre@montreal.ca> * Bump to version 2.1.1-beta Signed-off-by: Jérémie Carpentier-Roy <jeremie.carpentier-roy@montreal.ca> * Include run js in build (#9) * * fix: Typescript typings files generation Signed-off-by: Julien Lamarre <julien.lamarre@montreal.ca> * fix: The "src/run.js" was not included in the build Signed-off-by: Julien Lamarre <julien.lamarre@montreal.ca> Co-authored-by: Julien Lamarre <julien.lamarre@montreal.ca> * Bump version to 2.1.2-beta Signed-off-by: Jérémie Carpentier-Roy <jeremie.carpentier-roy@montreal.ca> Co-authored-by: etiennegingras <42901019+etiennegingras@users.noreply.github.com> Co-authored-by: uginget <etienne.gingras@ville.montreal.qc.ca> Co-authored-by: Electro Type <electrotype@gmail.com> Co-authored-by: Julien Lamarre <julien.lamarre@montreal.ca>
psionikangel
added a commit
that referenced
this pull request
May 2, 2022
* ci: eslint (#2) Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> Co-authored-by: uginget <etienne.gingras@ville.montreal.qc.ca> * fix: allowJs true (#3) * ci: eslint Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> * fix: allowJs true Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> Co-authored-by: uginget <etienne.gingras@ville.montreal.qc.ca> Co-authored-by: Jérémie Carpentier-Roy <jeremie.carpentier-roy@montreal.ca> * Beta 2 (#4) * ci: eslint Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> * fix: allowJs true Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> * fix: run.js if simplification Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> * version beta-2 Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> Co-authored-by: uginget <etienne.gingras@ville.montreal.qc.ca> Co-authored-by: Jérémie Carpentier-Roy <jeremie.carpentier-roy@montreal.ca> * ci: eslint (#2) Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> Co-authored-by: uginget <etienne.gingras@ville.montreal.qc.ca> Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> * fix: allowJs true (#3) * ci: eslint Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> * fix: allowJs true Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> Co-authored-by: uginget <etienne.gingras@ville.montreal.qc.ca> Co-authored-by: Jérémie Carpentier-Roy <jeremie.carpentier-roy@montreal.ca> Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> * ci: eslint Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> * fix: allowJs true Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> * fix: run.js if simplification Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> * version beta-2 Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> * remove tslint and prettier from lint-config and install eslint/prettier Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> * change version for 2.0.0 Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> * elvis operator allowed Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> * feat: Remove the core scripts (#7) * feat: Remove the core scripts. After discussion, we decided that the core scripts provided by this library were more confusing than useful. Indeed, a developer working on a project using this library may want to view the code of all scripts he is running. By bundeling some core scripts here, we have made this a little difficult. Now, these core scripts (`test-units`, `lint`, `watch`, etc) will have to be defined *in the projects themselves*, like any other script. Instead of providing the scripts in this library, we will add them to the API and Library templates. Signed-off-by: Julien Lamarre <julien.lamarre@montreal.ca> * Release v2.1.0-beta Signed-off-by: Jérémie Carpentier-Roy <jeremie.carpentier-roy@montreal.ca> * * fix: Typescript typings files generation (#8) Signed-off-by: Julien Lamarre <julien.lamarre@montreal.ca> Co-authored-by: Julien Lamarre <julien.lamarre@montreal.ca> * Bump to version 2.1.1-beta Signed-off-by: Jérémie Carpentier-Roy <jeremie.carpentier-roy@montreal.ca> * Include run js in build (#9) * * fix: Typescript typings files generation Signed-off-by: Julien Lamarre <julien.lamarre@montreal.ca> * fix: The "src/run.js" was not included in the build Signed-off-by: Julien Lamarre <julien.lamarre@montreal.ca> Co-authored-by: Julien Lamarre <julien.lamarre@montreal.ca> * Bump version to 2.1.2-beta Signed-off-by: Jérémie Carpentier-Roy <jeremie.carpentier-roy@montreal.ca> * fix: Possible error when there are no devDependencies Fix for the rare projects that would use the scripting lib but without having any `devDependencies` in their "package.json". Signed-off-by: Julien Lamarre <julien.lamarre@montreal.ca> Co-authored-by: etiennegingras <42901019+etiennegingras@users.noreply.github.com> Co-authored-by: uginget <etienne.gingras@ville.montreal.qc.ca> Co-authored-by: Jérémie Carpentier-Roy <jeremie.carpentier-roy@montreal.ca> Co-authored-by: Jérémie Carpentier-Roy <jeremie.carpentier.roy@gmail.com> Co-authored-by: Julien Lamarre <julien.lamarre@montreal.ca>
galak75
pushed a commit
to galak75/node-scripting
that referenced
this pull request
Nov 18, 2022
* ci: eslint (#2) Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> Co-authored-by: uginget <etienne.gingras@ville.montreal.qc.ca> * fix: allowJs true (#3) * ci: eslint Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> * fix: allowJs true Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> Co-authored-by: uginget <etienne.gingras@ville.montreal.qc.ca> Co-authored-by: Jérémie Carpentier-Roy <jeremie.carpentier-roy@montreal.ca> * Beta 2 (#4) * ci: eslint Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> * fix: allowJs true Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> * fix: run.js if simplification Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> * version beta-2 Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> Co-authored-by: uginget <etienne.gingras@ville.montreal.qc.ca> Co-authored-by: Jérémie Carpentier-Roy <jeremie.carpentier-roy@montreal.ca> * ci: eslint (#2) Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> Co-authored-by: uginget <etienne.gingras@ville.montreal.qc.ca> Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> * fix: allowJs true (#3) * ci: eslint Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> * fix: allowJs true Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> Co-authored-by: uginget <etienne.gingras@ville.montreal.qc.ca> Co-authored-by: Jérémie Carpentier-Roy <jeremie.carpentier-roy@montreal.ca> Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> * ci: eslint Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> * fix: allowJs true Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> * fix: run.js if simplification Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> * version beta-2 Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> * remove tslint and prettier from lint-config and install eslint/prettier Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> * change version for 2.0.0 Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> * elvis operator allowed Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> * feat: Remove the core scripts (VilledeMontreal#7) * feat: Remove the core scripts. After discussion, we decided that the core scripts provided by this library were more confusing than useful. Indeed, a developer working on a project using this library may want to view the code of all scripts he is running. By bundeling some core scripts here, we have made this a little difficult. Now, these core scripts (`test-units`, `lint`, `watch`, etc) will have to be defined *in the projects themselves*, like any other script. Instead of providing the scripts in this library, we will add them to the API and Library templates. Signed-off-by: Julien Lamarre <julien.lamarre@montreal.ca> * Release v2.1.0-beta Signed-off-by: Jérémie Carpentier-Roy <jeremie.carpentier-roy@montreal.ca> * * fix: Typescript typings files generation (VilledeMontreal#8) Signed-off-by: Julien Lamarre <julien.lamarre@montreal.ca> Co-authored-by: Julien Lamarre <julien.lamarre@montreal.ca> * Bump to version 2.1.1-beta Signed-off-by: Jérémie Carpentier-Roy <jeremie.carpentier-roy@montreal.ca> * Include run js in build (VilledeMontreal#9) * * fix: Typescript typings files generation Signed-off-by: Julien Lamarre <julien.lamarre@montreal.ca> * fix: The "src/run.js" was not included in the build Signed-off-by: Julien Lamarre <julien.lamarre@montreal.ca> Co-authored-by: Julien Lamarre <julien.lamarre@montreal.ca> * Bump version to 2.1.2-beta Signed-off-by: Jérémie Carpentier-Roy <jeremie.carpentier-roy@montreal.ca> Co-authored-by: etiennegingras <42901019+etiennegingras@users.noreply.github.com> Co-authored-by: uginget <etienne.gingras@ville.montreal.qc.ca> Co-authored-by: Electro Type <electrotype@gmail.com> Co-authored-by: Julien Lamarre <julien.lamarre@montreal.ca>
galak75
pushed a commit
to galak75/node-scripting
that referenced
this pull request
Nov 18, 2022
…l#14) * ci: eslint (#2) Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> Co-authored-by: uginget <etienne.gingras@ville.montreal.qc.ca> * fix: allowJs true (#3) * ci: eslint Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> * fix: allowJs true Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> Co-authored-by: uginget <etienne.gingras@ville.montreal.qc.ca> Co-authored-by: Jérémie Carpentier-Roy <jeremie.carpentier-roy@montreal.ca> * Beta 2 (#4) * ci: eslint Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> * fix: allowJs true Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> * fix: run.js if simplification Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> * version beta-2 Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> Co-authored-by: uginget <etienne.gingras@ville.montreal.qc.ca> Co-authored-by: Jérémie Carpentier-Roy <jeremie.carpentier-roy@montreal.ca> * ci: eslint (#2) Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> Co-authored-by: uginget <etienne.gingras@ville.montreal.qc.ca> Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> * fix: allowJs true (#3) * ci: eslint Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> * fix: allowJs true Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> Co-authored-by: uginget <etienne.gingras@ville.montreal.qc.ca> Co-authored-by: Jérémie Carpentier-Roy <jeremie.carpentier-roy@montreal.ca> Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> * ci: eslint Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> * fix: allowJs true Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> * fix: run.js if simplification Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> * version beta-2 Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> * remove tslint and prettier from lint-config and install eslint/prettier Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> * change version for 2.0.0 Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> * elvis operator allowed Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca> * feat: Remove the core scripts (VilledeMontreal#7) * feat: Remove the core scripts. After discussion, we decided that the core scripts provided by this library were more confusing than useful. Indeed, a developer working on a project using this library may want to view the code of all scripts he is running. By bundeling some core scripts here, we have made this a little difficult. Now, these core scripts (`test-units`, `lint`, `watch`, etc) will have to be defined *in the projects themselves*, like any other script. Instead of providing the scripts in this library, we will add them to the API and Library templates. Signed-off-by: Julien Lamarre <julien.lamarre@montreal.ca> * Release v2.1.0-beta Signed-off-by: Jérémie Carpentier-Roy <jeremie.carpentier-roy@montreal.ca> * * fix: Typescript typings files generation (VilledeMontreal#8) Signed-off-by: Julien Lamarre <julien.lamarre@montreal.ca> Co-authored-by: Julien Lamarre <julien.lamarre@montreal.ca> * Bump to version 2.1.1-beta Signed-off-by: Jérémie Carpentier-Roy <jeremie.carpentier-roy@montreal.ca> * Include run js in build (VilledeMontreal#9) * * fix: Typescript typings files generation Signed-off-by: Julien Lamarre <julien.lamarre@montreal.ca> * fix: The "src/run.js" was not included in the build Signed-off-by: Julien Lamarre <julien.lamarre@montreal.ca> Co-authored-by: Julien Lamarre <julien.lamarre@montreal.ca> * Bump version to 2.1.2-beta Signed-off-by: Jérémie Carpentier-Roy <jeremie.carpentier-roy@montreal.ca> * fix: Possible error when there are no devDependencies Fix for the rare projects that would use the scripting lib but without having any `devDependencies` in their "package.json". Signed-off-by: Julien Lamarre <julien.lamarre@montreal.ca> Co-authored-by: etiennegingras <42901019+etiennegingras@users.noreply.github.com> Co-authored-by: uginget <etienne.gingras@ville.montreal.qc.ca> Co-authored-by: Jérémie Carpentier-Roy <jeremie.carpentier-roy@montreal.ca> Co-authored-by: Jérémie Carpentier-Roy <jeremie.carpentier.roy@gmail.com> Co-authored-by: Julien Lamarre <julien.lamarre@montreal.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typing files were not generated so it was not possible to use the library properly.