Skip to content

Feature/add some unit tests#3

Merged
galak75 merged 12 commits intofeature/add-sonar-scriptsfrom
feature/add-some-unit-tests
Oct 31, 2021
Merged

Feature/add some unit tests#3
galak75 merged 12 commits intofeature/add-sonar-scriptsfrom
feature/add-some-unit-tests

Conversation

@galak75
Copy link
Copy Markdown
Owner

@galak75 galak75 commented Oct 31, 2021

No description provided.

Signed-off-by: Géraud Lac <galak75@gmail.com>
Signed-off-by: Géraud Lac <galak75@gmail.com>
Signed-off-by: Géraud Lac <galak75@gmail.com>
Signed-off-by: Géraud Lac <galak75@gmail.com>
Signed-off-by: Géraud Lac <galak75@gmail.com>
Signed-off-by: Géraud Lac <galak75@gmail.com>
Signed-off-by: Géraud Lac <galak75@gmail.com>
Signed-off-by: Géraud Lac <galak75@gmail.com>
Signed-off-by: Géraud Lac <galak75@gmail.com>
Signed-off-by: Géraud Lac <galak75@gmail.com>
Signed-off-by: Géraud Lac <galak75@gmail.com>
Signed-off-by: Géraud Lac <galak75@gmail.com>
@galak75 galak75 merged commit b42e86b into feature/add-sonar-scripts Oct 31, 2021
@galak75 galak75 deleted the feature/add-some-unit-tests branch October 31, 2021 21:54
galak75 pushed a commit that referenced this pull request Apr 8, 2022
* ci: eslint

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* fix: allowJs true

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

Co-authored-by: uginget <etienne.gingras@ville.montreal.qc.ca>
Co-authored-by: Jérémie Carpentier-Roy <jeremie.carpentier-roy@montreal.ca>
galak75 pushed a commit that referenced this pull request Apr 8, 2022
* ci: eslint

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* fix: allowJs true

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

Co-authored-by: uginget <etienne.gingras@ville.montreal.qc.ca>
Co-authored-by: Jérémie Carpentier-Roy <jeremie.carpentier-roy@montreal.ca>
Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>
galak75 pushed a commit that referenced this pull request Nov 18, 2022
* ci: eslint (#2)

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

Co-authored-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* fix: allowJs true (#3)

* ci: eslint

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* fix: allowJs true

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

Co-authored-by: uginget <etienne.gingras@ville.montreal.qc.ca>
Co-authored-by: Jérémie Carpentier-Roy <jeremie.carpentier-roy@montreal.ca>

* Beta 2 (#4)

* ci: eslint

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* fix: allowJs true

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* fix: run.js if simplification

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* version beta-2

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

Co-authored-by: uginget <etienne.gingras@ville.montreal.qc.ca>
Co-authored-by: Jérémie Carpentier-Roy <jeremie.carpentier-roy@montreal.ca>

* ci: eslint (#2)

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

Co-authored-by: uginget <etienne.gingras@ville.montreal.qc.ca>
Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* fix: allowJs true (#3)

* ci: eslint

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* fix: allowJs true

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

Co-authored-by: uginget <etienne.gingras@ville.montreal.qc.ca>
Co-authored-by: Jérémie Carpentier-Roy <jeremie.carpentier-roy@montreal.ca>
Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* ci: eslint

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* fix: allowJs true

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* fix: run.js if simplification

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* version beta-2

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* remove tslint and prettier from lint-config and install eslint/prettier

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* change version for 2.0.0

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* elvis operator allowed

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* feat: Remove the core scripts (VilledeMontreal#7)

* feat: Remove the core scripts.

After discussion, we decided that the core scripts provided by this library were more confusing than useful. Indeed, a developer working on a project using this library may want to view the code of all scripts he is running. By bundeling some core scripts here, we have made this a little difficult.

Now, these core scripts (`test-units`, `lint`, `watch`, etc) will have to be defined *in the projects themselves*, like any other script.

Instead of providing the scripts in this library, we will add them to the API and Library templates.

Signed-off-by: Julien Lamarre <julien.lamarre@montreal.ca>

* Release v2.1.0-beta

Signed-off-by: Jérémie Carpentier-Roy <jeremie.carpentier-roy@montreal.ca>

* * fix: Typescript typings files generation (VilledeMontreal#8)

Signed-off-by: Julien Lamarre <julien.lamarre@montreal.ca>

Co-authored-by: Julien Lamarre <julien.lamarre@montreal.ca>

* Bump to version 2.1.1-beta

Signed-off-by: Jérémie Carpentier-Roy <jeremie.carpentier-roy@montreal.ca>

* Include run js in build (VilledeMontreal#9)

* * fix: Typescript typings files generation

Signed-off-by: Julien Lamarre <julien.lamarre@montreal.ca>

* fix: The "src/run.js" was not included in the build

Signed-off-by: Julien Lamarre <julien.lamarre@montreal.ca>

Co-authored-by: Julien Lamarre <julien.lamarre@montreal.ca>

* Bump version to 2.1.2-beta

Signed-off-by: Jérémie Carpentier-Roy <jeremie.carpentier-roy@montreal.ca>

Co-authored-by: etiennegingras <42901019+etiennegingras@users.noreply.github.com>
Co-authored-by: uginget <etienne.gingras@ville.montreal.qc.ca>
Co-authored-by: Electro Type <electrotype@gmail.com>
Co-authored-by: Julien Lamarre <julien.lamarre@montreal.ca>
galak75 pushed a commit that referenced this pull request Nov 18, 2022
…l#14)

* ci: eslint (#2)

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

Co-authored-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* fix: allowJs true (#3)

* ci: eslint

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* fix: allowJs true

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

Co-authored-by: uginget <etienne.gingras@ville.montreal.qc.ca>
Co-authored-by: Jérémie Carpentier-Roy <jeremie.carpentier-roy@montreal.ca>

* Beta 2 (#4)

* ci: eslint

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* fix: allowJs true

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* fix: run.js if simplification

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* version beta-2

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

Co-authored-by: uginget <etienne.gingras@ville.montreal.qc.ca>
Co-authored-by: Jérémie Carpentier-Roy <jeremie.carpentier-roy@montreal.ca>

* ci: eslint (#2)

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

Co-authored-by: uginget <etienne.gingras@ville.montreal.qc.ca>
Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* fix: allowJs true (#3)

* ci: eslint

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* fix: allowJs true

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

Co-authored-by: uginget <etienne.gingras@ville.montreal.qc.ca>
Co-authored-by: Jérémie Carpentier-Roy <jeremie.carpentier-roy@montreal.ca>
Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* ci: eslint

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* fix: allowJs true

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* fix: run.js if simplification

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* version beta-2

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* remove tslint and prettier from lint-config and install eslint/prettier

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* change version for 2.0.0

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* elvis operator allowed

Signed-off-by: uginget <etienne.gingras@ville.montreal.qc.ca>

* feat: Remove the core scripts (VilledeMontreal#7)

* feat: Remove the core scripts.

After discussion, we decided that the core scripts provided by this library were more confusing than useful. Indeed, a developer working on a project using this library may want to view the code of all scripts he is running. By bundeling some core scripts here, we have made this a little difficult.

Now, these core scripts (`test-units`, `lint`, `watch`, etc) will have to be defined *in the projects themselves*, like any other script.

Instead of providing the scripts in this library, we will add them to the API and Library templates.

Signed-off-by: Julien Lamarre <julien.lamarre@montreal.ca>

* Release v2.1.0-beta

Signed-off-by: Jérémie Carpentier-Roy <jeremie.carpentier-roy@montreal.ca>

* * fix: Typescript typings files generation (VilledeMontreal#8)

Signed-off-by: Julien Lamarre <julien.lamarre@montreal.ca>

Co-authored-by: Julien Lamarre <julien.lamarre@montreal.ca>

* Bump to version 2.1.1-beta

Signed-off-by: Jérémie Carpentier-Roy <jeremie.carpentier-roy@montreal.ca>

* Include run js in build (VilledeMontreal#9)

* * fix: Typescript typings files generation

Signed-off-by: Julien Lamarre <julien.lamarre@montreal.ca>

* fix: The "src/run.js" was not included in the build

Signed-off-by: Julien Lamarre <julien.lamarre@montreal.ca>

Co-authored-by: Julien Lamarre <julien.lamarre@montreal.ca>

* Bump version to 2.1.2-beta

Signed-off-by: Jérémie Carpentier-Roy <jeremie.carpentier-roy@montreal.ca>

* fix: Possible error when there are no devDependencies

Fix for the rare projects that would use the scripting lib but without having any `devDependencies` in their "package.json".

Signed-off-by: Julien Lamarre <julien.lamarre@montreal.ca>

Co-authored-by: etiennegingras <42901019+etiennegingras@users.noreply.github.com>
Co-authored-by: uginget <etienne.gingras@ville.montreal.qc.ca>
Co-authored-by: Jérémie Carpentier-Roy <jeremie.carpentier-roy@montreal.ca>
Co-authored-by: Jérémie Carpentier-Roy <jeremie.carpentier.roy@gmail.com>
Co-authored-by: Julien Lamarre <julien.lamarre@montreal.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant