Upgrade Deltacode to use Skeleton and support python 3.8+ #182 #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-svn-id: svn+ssh://rubyforge.org/var/svn/rubygems/trunk@1 3d4018f9-ac1a-0410-99e9-8a154d859a19
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Use virtualenv-embedded libraries
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
This will work even from a git archive or when git is not installed. Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
This was they do not end up in the template CHANGELOG.rst Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
New configure
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
From aboutcode-org/typecode#20 Reported-by: Pierre Tardy <pierre.tardy@renault.com> Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
And remove v prefix from fallback version Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
* This is handy for windows to have the same path as linux Signed-off-by: Chin Yeung Li <tli@nexb.com>
Create junction from Scripts to bin
Signed-off-by: Jono Yang <jyang@nexb.com>
…-dir Check for deps in local thirdparty directory aboutcode-org#31
Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
* Create copyright statement from holder information Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
arnav-mandal1234
force-pushed
the
skeleton_upgrade
branch
2 times, most recently
from
8927679 to
d7cb1f7
Compare
Collaborator
Author
|
Setting DCO test to pass as skeleton had some commits which had no sign-offs. The latest commit has the sign-off. |
arnav-mandal1234
requested review from
AyanSinhaMahapatra,
JonoYang,
pombredanne and
steven-esser
arnav-mandal1234
changed the title
AyanSinhaMahapatra
requested changes
Mar 24, 2023
Member
AyanSinhaMahapatra
left a comment
AyanSinhaMahapatra
left a comment
There was a problem hiding this comment.
See comments for a few changes, looking good otherwise! Thanks!
arnav-mandal1234
force-pushed
the
skeleton_upgrade
branch
8 times, most recently
from
18309c2 to
df10d63
Compare
AyanSinhaMahapatra
requested changes
Mar 24, 2023
Member
AyanSinhaMahapatra
left a comment
AyanSinhaMahapatra
left a comment
There was a problem hiding this comment.
See some more comments for your consideration. Thanks! Looking like we'll be ready after these changes. Thanks!
* Delete `thirdparty/` and unnecessary files. * Delete `Deltacode`, `Deltacode.bat`, `test.csv` and `expected.json`. * Change `from bitarray import bitdiff` to `from bitarray.util import count_xor`. * Upgrade bitarray to support python 3.7+. * Added dependencies in `requirements.txt` and `requirements-dev.txt`. Signed-off-by: Arnav Mandal <arnav.mandal1234@gmail.com>
arnav-mandal1234
force-pushed
the
skeleton_upgrade
branch
from
df10d63 to
bfdfaa9
Compare
AyanSinhaMahapatra
changed the title
AyanSinhaMahapatra
approved these changes
Mar 24, 2023
Member
AyanSinhaMahapatra
left a comment
AyanSinhaMahapatra
left a comment
There was a problem hiding this comment.
@arnav-mandal1234 thanks! LGTM!
@pombredanne this is ready for you to review!
AyanSinhaMahapatra
changed the title
JonoYang
reviewed
Mar 27, 2023
Member
JonoYang
left a comment
JonoYang
left a comment
There was a problem hiding this comment.
LGTM! Just left a comment about updating the commands under the quick start guide in the README
Member
|
Thanks+++ @arnav-mandal1234 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
thirdparty/and unnecessary files.Deltacode,Deltacode.bat,test.csvandexpected.json.from bitarray import bitdifftofrom bitarray.util import count_xor.requirements.txtandrequirements-dev.txt.Signed-off-by: Arnav Mandal arnav.mandal1234@gmail.com