Conversation
|
I need to upgraed FAB in v2-3-stable so that pull requests of users can be made. |
6f21a79 to
f32ae37
Compare
|
Why aren't we just cherry-picking #24884 into v2-3-test then? |
|
I am testing PR from a fork to Root cause is that there is a change #24961 coming which is coming from a user as PR (it's not really cherry-pickable as there were more changes in ther original PR and this one just brings DebugExecutor to be the same as in main). And I already found that I need to merge #25056 and #25053 to main to make PRs to v2-3-stable work with the new selective checks and Python based breeze (so far we just tested that cherry-picks work fine). I can eventually cherry-pick that one of course to v2-3-test, but then we would have to merge v2-3-test back to v2-3-stable so that users could make PRs to v2-3-stable. I thought that we only merge v2-3-stable and v2-3-test when we relase, so I thought that this PR should be merged to |
|
Hey @jedcunningham - was it good-enough explanation ? We need #25056 merged for this one to succed as well as # #25053. So I'd love to merge those to get this one merged. |
|
Yep, makes sense. I'd personally prefer we cherry-pick and do an out-of-band v2-3-stable sync, but it ultimately doesn't really matter 🤷♂️. |
|
Let's see if we this will work now :) |
f32ae37 to
d1a8514
Compare
We can stil do it. I just want to have this PR green (and test that it CAN be done) and I can cherry-pick it directly later and merge to v2-3-stable, no problem |
d1a8514 to
89a193a
Compare
|
Hey @jedcunningham @ephraimbuddy - I cherry-picked a number of breeze/ci changes (As again it was easier than trying to fix the related CI "problems" where changes in "main" have to be synced with the brenanch. Once it is green I will make a sync v2-3-stable to v2-3-test and then this one might finally succeed (and then I can re-cherry-pick it anyway) |
de87c41 to
a1b4f08
Compare
939b372 to
5d5f167
Compare
no relevant changes found when comparing `airflow/www/fab_security` with FAB see dpgaspar/Flask-AppBuilder@v4.1.2...v4.1.3 (cherry picked from commit 01a5d8f)
5d5f167 to
2123b37
Compare
|
OK. Finally I got it succeed, so I close this one and cherry-pick it instead :). We should be ok with handling PRs to v2-3 and v2-4 branches |
no relevant changes found when comparing
airflow/www/fab_securitywith FABsee dpgaspar/Flask-AppBuilder@v4.1.2...v4.1.3
(cherry picked from commit 01a5d8f)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.