Retrieve airflow branch/constraints from env variables#25053
Merged
potiuk merged 1 commit intoapache:mainfrom Jul 19, 2022
Merged
Retrieve airflow branch/constraints from env variables#25053potiuk merged 1 commit intoapache:mainfrom
potiuk merged 1 commit intoapache:mainfrom
Conversation
Member
Author
|
We need than one merged in main in order to #25050 to succed in v2-3-stable branch |
Member
Author
|
The branch env variables are set here: airflow/.github/workflows/build-images.yml Line 116 in 5e0160f |
This was referenced Jul 14, 2022
Member
Author
|
Also woudl love some revirews here. I need that one to get the "PR to v2-3-stable" flow working. |
jedcunningham
approved these changes
Jul 19, 2022
We are using the "main" breeze to build even v2-3 images and it has to retrieve the branch and constraints not from the Python constants but from environment variables that are set by build-image.yaml. Otherwise "main" is used to push/pull image and constraints. This pr changes the retrieval in build image to retrieve branch, constraints branch (and debian version) from env variables if they are set.
potiuk
force-pushed
the
branches-can-be-overridden
branch
from
bab0eaf to
32a7251
Compare
potiuk
added a commit
that referenced
this pull request
Jul 21, 2022
We are using the "main" breeze to build even v2-3 images and it has to retrieve the branch and constraints not from the Python constants but from environment variables that are set by build-image.yaml. Otherwise "main" is used to push/pull image and constraints. This pr changes the retrieval in build image to retrieve branch, constraints branch (and debian version) from env variables if they are set. (cherry picked from commit f36f81e)
ephraimbuddy
added
the
changelog:skip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are using the "main" breeze to build even v2-3 images and
it has to retrieve the branch and constraints not from the
Python constants but from environment variables that are
set by build-image.yaml. Otherwise "main" is used to push/pull
image and constraints.
This pr changes the retrieval in build image to retrieve
branch, constraints branch (and debian version) from env
variables if they are set.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.