Disable provider packages building for non-main branch builds #25056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running the builds from non-main, we do not want to use provider packages built locally, but we want to install those from PyPI. This is achieved by skipping the step of building providers in case default branch is not main. During this change it was also discovered that we do not need AIRFLOW_FROM_CONTEXT flag to indicate whether airflow is among those being installed from docker-context files. This is now detected automatically and airflow is installed from Pypi if not installed from docker context files. Providers and airflow are automatically detected and installed if they are present. Installing pre-cached dependencies from GitHub is skipped in case docker-context-files are used.
potiuk
requested review from
ashb,
jedcunningham,
kaxil and
mik-laj
as code owners
boring-cyborg
bot
added
area:dev-tools
area:production-image
Member
Author
|
Another change needed to make PRs to v2-3-stable succeed on top of #25053 |
Member
Author
|
Anyone here? I need that one to get the v2-3* back in order (for PR case) |
jedcunningham
approved these changes
Jul 19, 2022
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
potiuk
added a commit
that referenced
this pull request
Jul 21, 2022
* Disable provider packages building for non-main branch builds When running the builds from non-main, we do not want to use provider packages built locally, but we want to install those from PyPI. This is achieved by skipping the step of building providers in case default branch is not main. During this change it was also discovered that we do not need AIRFLOW_FROM_CONTEXT flag to indicate whether airflow is among those being installed from docker-context files. This is now detected automatically and airflow is installed from Pypi if not installed from docker context files. Providers and airflow are automatically detected and installed if they are present. Installing pre-cached dependencies from GitHub is skipped in case docker-context-files are used. (cherry picked from commit 67a24ae)
ephraimbuddy
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the builds from non-main, we do not want to use
provider packages built locally, but we want to install those from
PyPI. This is achieved by skipping the step of building providers
in case default branch is not main.
During this change it was also discovered that we do not need
AIRFLOW_FROM_CONTEXT flag to indicate whether airflow is
among those being installed from docker-context files. This is
now detected automatically and airflow is installed from Pypi
if not installed from docker context files. Providers
and airflow are automatically detected and installed if they are
present.
Installing pre-cached dependencies from GitHub is skipped in
case docker-context-files are used.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.