fetches data but fails to display them #45170
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LefterisXefteris
requested review from
bbovenzi,
jscheffl,
pierrejeambrun and
ryanahamilton
as code owners
Contributor
|
Related issue #43328 |
Contributor
|
Note: As PR #45312 has been merged, the code formatting rules have changed for new UI. Please rebase and re-run pre-commit checks to ensure that formatting in folder airflow/ui is adjusted. |
* Fix task id validation in BaseOperator * add additional tests to check task id length * fix assert statement
* #44019 - Set autocomplete to off for username and password login form * fixed static check
* Send multiple queries on dataproc sql job DataProcJobBuilder.add_query(query) is misleading, cause it can make you think that you can call this function multiple times with different queries and then execute and it will send all queries, but it fact it will sent the last one since its override the queries. I've added set_queries function which takes a list of strings and send it. Dataproc supports queries list. * Append query to the queries sent to dataproc instead of replacing Requested by reviewer, instead of adding a function that sets a list of queries, just fix the original function add_query that will actually append query to the queries list send to dataproc job. * Send multiple queries on dataproc sql job DataProcJobBuilder.add_query(query) is misleading, cause it can make you think that you can call this function multiple times with different queries and then execute and it will send all queries, but it fact it will sent the last one since its override the queries. I've added set_queries function which takes a list of strings and send it. Dataproc supports queries list. * Append query to the queries sent to dataproc instead of replacing Requested by reviewer, instead of adding a function that sets a list of queries, just fix the original function add_query that will actually append query to the queries list send to dataproc job. * formatter --------- Co-authored-by: Amir Mor <amir.mor26@gmail.com>
New hatchling version was released.
I suspect we no longer need this since alias resolution now happens very late in the scheduling process. A DAG *should* be able to automatically understand the alias is resolved without a reparse after refactorings introduced in cccc933.
* Refactor PostConnection handling insert duplicate * Add parsing error detail to error handler with test * Add parsing multiple columns case in unique constraint * Add multiple columns, parsing error cases in test * Fix public API already existed test cases * Refactor: remove parsing, return statement and orig * Refactor test_exceptions with statement and orign * Fix unique constriant violation response in api test
Co-authored-by: Marco Küttelwesch <marco.kuettelwesch@de.bosch.com>
Part of #44481 This commit augments the TI context available in the Task Execution Interface with the one from the Execution API Server. In future PRs the following will be added: - More methods on TI like ti.xcom_pull, ti.xcom_push etc - Lazy fetching of connections, variables - Verifying the "get_current_context" is working
* Structure endpoint add asset-condition * Fix CI
* issue 44559 removed depricated code from alibaba provider * Apply suggestions from code review Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com> --------- Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com> Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
This was initially added in response to #168. However, we now have `ti.log_url` that is used for that; example usages: https://github.com/apache/airflow/blob/dcd41f60f1c9b5583b49bfb49b6d85c640a2892c/airflow/models/taskinstance.py#L1362 https://github.com/apache/airflow/blob/dcd41f60f1c9b5583b49bfb49b6d85c640a2892c/providers/src/airflow/providers/smtp/notifications/templates/email.html#L28 https://github.com/apache/airflow/blob/dcd41f60f1c9b5583b49bfb49b6d85c640a2892c/docs/apache-airflow/howto/email-config.rst?plain=1#L76 So, to simplify what we need to pass from API server to the Task SDK, I want to simplify and remove things that aren't needed. In this case, this is good so we don't pass/expore secrets unnecesarily via `conf`
* conf * conf check * basic trigger api * retrieve params * refactor the api * fix * fix details page * refactor the logic * refactor * reviews * error on form * data date validation * remove empty runid and note
* Add support for XCom tab in Task Instance detail page. * Add support for XCom page in browse section. * Disable sorting since API doesn't support it. * Fix run_id in xcom tests. * Fix generated files. * Refactor XCom page and XCom columns.
PR #44820 removed `conf` from task context, but these tests still expect it.
Small improvements in airflow/api_fastapi/common/parameters.py:_transform_ti_states
LefterisXefteris
force-pushed
the
feature/pool-slots
branch
from
36ba8ac to
c01066f
Compare
LefterisXefteris
requested review from
Fokko,
XD-DENG,
ashb,
bolkedebruin,
dstandish,
eladkal,
ephraimbuddy,
hussein-awala,
jedcunningham,
josh-fell,
kaxil,
mik-laj,
mobuchowski,
o-nikolas,
potiuk,
uranusjr and
vincbeck
as code owners
Member
|
I think some rebase went wrong. Can you fix the branch and resolve possible conflicts to facilitate the review please. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
github-actions
bot
added
the
stale
Member
|
@LefterisXefteris it's hard to provide guidance because I suspect a rebase went wrong and the change set contains hundred of other commits. Can you clean the branch please ? |
github-actions
bot
removed
the
stale
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
github-actions
bot
added
the
stale
Member
|
No updates, closing for now. Feel free to re-open if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I implemented data fetching for pool slots using React Query. The data is successfully retrieved but I need help with displaying it in the required format.
Closes: #43328
Current Status
Implementation Details
Questions/Help Needed