-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-15280: [C++][Python][GLib] add libarrow_acero containing everything previously in compute/exec #34711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@westonpace I did not move acero components in their own namespace. |
Hmm, let's leave it as it is for now. That would be a more significant breaking change for anyone using Acero today and I don't know that it's justified. |
On the other hand...they're going to have to change all their include statements. So if we are going to make the change at some point, now is probably the time to do it. |
72620f7 to
d551aa0
Compare
|
@icexelloss It seems that this breaks the "AMD64 Windows R 4.2 RTools 42" job: https://github.com/apache/arrow/actions/runs/4582748548/jobs/8093221704#step:12:90 Could you check this and open an issue for this if needed? |
|
Could we run crossbow jobs before merging big changes like this? I don't see any in this PR at all. |
|
@github-actions crossbow submit -g r -g cpp |
|
Revision: 769da29 Submitted crossbow builds: ursacomputing/crossbow @ actions-c171914822 |
|
Benchmark runs are scheduled for baseline = 7e19111 and contender = f137f29. f137f29 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Sorry I wasn't aware of crossbow jobs needs to be manually invoked before merging. Certainly will do next time. For my knowledge, what is the difference between crossbow jobs and the github CI? |
Terribly sorry about that. Will do. |
Crossbow jobs are e.g. the nightly jobs which are run in a different repo, they have to be triggered manually via comment (as seen above). Which should be triggered by the reviewers on such a large change. (And imo any change that touches the build system in a significant way). This is a bit poorly documented tbh so don't worry ^^. |
Got it - Will do next time. Thanks! |
Created #34843 |
|
It's not just the R Windows builds; test-r-minimal-build and test-r-offline-minimal are also failing now. |
### Rationale for this change There was an issue with window R build introduced by this PR: #34711 ### What changes are included in this PR? Many changes to the build files ### Are these changes tested? crossbow builds ### Are there any user-facing changes? * Closes: #34843 Lead-authored-by: Weston Pace <weston.pace@gmail.com> Co-authored-by: Li Jin <ice.xelloss@gmail.com> Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
### Rationale for this change We need to update Linux packages for #34711. ### What changes are included in this PR? Add Acero related packages. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * Closes: #34914 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
### Rationale for this change We need to update Linux packages for apache#34711. ### What changes are included in this PR? Add Acero related packages. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * Closes: apache#34914 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
…rything previously in compute/exec (apache#34711) ### Rationale for this change See the linked issue ### What changes are included in this PR? C++: * remove all compute/exec/* from libarrow * rename compute/exec -> acero and make libarrow_acero * add new ARROW_ACERO option, required if ARROW_DATASET is on * libarrow_dataset now depends on libarrow_acero c_glib: add the new libarrow_acero dependency - we disallow building glib without it python: added PYARROW_BUILD_ACERO, set to on if DATASETS are built ### Are these changes tested? All the standard tests do work properly. I manually compiled C++ with: * no ARROW_ACERO * ARROW_ACERO and no ARROW_DATASET * ARROW_ACERO and ARROW_DATASET and no ARROW_SUBSTRAIT I manually compiled python without ACERO & DATASET and with ACERO and without DATASET ### Are there any user-facing changes? If users include compute/exec files directly then they'll have to update their code. * Closes: apache#15280 Lead-authored-by: Davide Pasetto <dpasetto69@gmail.com> Co-authored-by: Li Jin <ice.xelloss@gmail.com> Co-authored-by: Weston Pace <weston.pace@gmail.com> Signed-off-by: Li Jin <ice.xelloss@gmail.com>
…he#34844) ### Rationale for this change There was an issue with window R build introduced by this PR: apache#34711 ### What changes are included in this PR? Many changes to the build files ### Are these changes tested? crossbow builds ### Are there any user-facing changes? * Closes: apache#34843 Lead-authored-by: Weston Pace <weston.pace@gmail.com> Co-authored-by: Li Jin <ice.xelloss@gmail.com> Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
### Rationale for this change We need to update Linux packages for apache#34711. ### What changes are included in this PR? Add Acero related packages. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * Closes: apache#34914 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Rationale for this change
See the linked issue
What changes are included in this PR?
C++:
c_glib: add the new libarrow_acero dependency - we disallow building glib without it
python: added PYARROW_BUILD_ACERO, set to on if DATASETS are built
Are these changes tested?
All the standard tests do work properly.
I manually compiled C++ with:
I manually compiled python without ACERO & DATASET and with ACERO and without DATASET
Are there any user-facing changes?
If users include compute/exec files directly then they'll have to update their code.