Skip to content

Conversation

@kou
Copy link
Member

@kou kou commented Jul 14, 2023

Rationale for this change

PyArrow wants Acero.

What changes are included in this PR?

Add ARROW_ACERO to ARROW_PYTHON dependency.

Are these changes tested?

Yes.

Are there any user-facing changes?

Yes.

@kou
Copy link
Member Author

kou commented Jul 14, 2023

@github-actions crossbow submit example-python-minimal-*

@github-actions
Copy link

⚠️ GitHub issue #36680 has been automatically assigned in GitHub to PR creator.

@github-actions

This comment was marked as outdated.

@kou
Copy link
Member Author

kou commented Jul 14, 2023

@github-actions crossbow submit example-python-minimal-*

@github-actions

This comment was marked as outdated.

@kou kou force-pushed the example-minimal-acero branch from 34f72d9 to fe14c3f Compare July 14, 2023 08:17
@kou
Copy link
Member Author

kou commented Jul 14, 2023

I've opened #36683 for the example-minimal-python-* failures.

(This is a deprecated option. Use CMake presets instead.)"
OFF
DEPENDS
ARROW_ACERO
Copy link
Member

@raulcd raulcd Jul 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not entirely sure I understand why are we doing this change. Should all ARROW_PYTHON dependencies be added? what about S3 or GCS?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, shouldn't we in theory not rely on this in our own CI, given that it is a deprecated option?

If the minimal python build needs this, then we should just enable ARROW_ACERO directly in that build? (or update it to not require acero)

Copy link
Member Author

@kou kou Jul 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry. This is needless.
I thought that this is the cause of #36680 but it was wrong: #36683

I thought that this is still needed because #34711 removes ARROW_COMPUTE from ARROW_PYTHON instead of replacing ARROW_COMPUTE with ARROW_ACERO.
But it's correct because ARROW_PYTHON depends on ARROW_ACERO implicitly: ARROW_PYTHON -> ARROW_DATASET -> ARROW_ACERO

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Jul 14, 2023
@kou
Copy link
Member Author

kou commented Jul 15, 2023

I withdraw this because this is needless.

@kou kou closed this Jul 15, 2023
@kou kou deleted the example-minimal-acero branch July 15, 2023 21:08
@kou kou changed the title GH-36680: [C++] Add missing ARROW_ACERO dependency to ARROW_PYTHON GH-36682: [C++] Add missing ARROW_ACERO dependency to ARROW_PYTHON Jul 15, 2023
@github-actions
Copy link

⚠️ GitHub issue #36682 has been automatically assigned in GitHub to PR creator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[C++] ARROW_PYTHON misses ARROW_ACERO dependency

3 participants