Skip to content

GH-35537: [MATLAB] Create shared test class utility for numeric arrays #35556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kou merged 2 commits into from
May 19, 2023
Merged

GH-35537: [MATLAB] Create shared test class utility for numeric arrays #35556

kou merged 2 commits into from
May 19, 2023

Conversation

@sgilmore10
Copy link
Member

@sgilmore10 sgilmore10 commented May 11, 2023 •
edited
Loading

Rationale for this change

To avoid writing duplicate tests, we created an an Abstract Test Class called hNumericArray which defines tests that can be shared by all numeric array types. Concrete test classes can inherit from this class to automatically get the shared test points.

What changes are included in this PR?

  1. Defined new abstract test class hNumericArray
  2. Modified tFloat32Array to inherit from hNumericArray
  3. Modified tFloat64Array to inherit from hNumericArray

Are these changes tested?

  1. Qualified the tests still pass on macOS.

Are there any user-facing changes?

There are no user-facing changes in this PR. This PR only has test-related changes.

@github-actions
Copy link

github-actions bot commented May 11, 2023

@kevingurney kevingurney mentioned this pull request May 11, 2023
Merged
@sgilmore10 sgilmore10 mentioned this pull request May 11, 2023
Merged
@sgilmore10 @kevingurney
1. Create an abstract TestClass called hNumericArray that has shared …
47cda68 
…tests for numeric arrays.

2. Change tFloat32Array and tFloat64Array to inherit from hNumericArray.

Co-authored-by: Kevin Gurney <kgurney@mathworks.com>
@sgilmore10 sgilmore10 marked this pull request as ready for review May 17, 2023 17:33
@sgilmore10 sgilmore10 requested a review from assignUser as a code owner May 17, 2023 17:33
kou
kou approved these changes May 17, 2023
View reviewed changes
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels May 17, 2023
@assignUser
Copy link
Member

assignUser commented May 17, 2023

@kevingurney would you mind reviewing this?

@kou
Copy link
Member

kou commented May 18, 2023

(I think that @sgilmore10 and @kevingurney did pair programming.)

@assignUser
Copy link
Member

assignUser commented May 18, 2023

Ah, +1 then!

@sgilmore10 @kou
Fix indentation
fa413de 
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
@kevingurney
Copy link
Member

kevingurney commented May 18, 2023

@assignUser and @kou - that's correct! @sgilmore10 and I have been pair programming on these MATLAB interface pull requests.

@kou kou changed the title GH-35537 [MATLAB] Create shared test class utility for numeric arrays. GH-35537 [MATLAB]: Create shared test class utility for numeric arrays May 19, 2023
@kou kou changed the title GH-35537 [MATLAB]: Create shared test class utility for numeric arrays GH-35537: [MATLAB] Create shared test class utility for numeric arrays May 19, 2023
@kou kou merged commit 5002535 into apache:main May 19, 2023
@ursabot
Copy link

ursabot commented May 21, 2023

Benchmark runs are scheduled for baseline = b80c655 and contender = 5002535. 5002535 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.24% ⬆️0.0%] test-mac-arm
[Finished ⬇️2.94% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.66% ⬆️0.12%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 5002535e ec2-t3-xlarge-us-east-2
[Finished] 5002535e test-mac-arm
[Finished] 5002535e ursa-i9-9960x
[Finished] 5002535e ursa-thinkcentre-m75q
[Finished] b80c6551 ec2-t3-xlarge-us-east-2
[Finished] b80c6551 test-mac-arm
[Finished] b80c6551 ursa-i9-9960x
[Finished] b80c6551 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented May 21, 2023

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x

@sgilmore10 sgilmore10 deleted the GH-35537 branch June 27, 2023 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kou kou kou approved these changes

@assignUser assignUser Awaiting requested review from assignUser

Assignees

No one assigned

Labels

awaiting merge Awaiting merge Component: MATLAB

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[MATLAB] Create shared test class utility for numeric arrays.

5 participants

@sgilmore10 @assignUser @kou @kevingurney @ursabot