-
Notifications
You must be signed in to change notification settings - Fork 4k
MINOR: [Java] Bump com.puppycrawl.tools:checkstyle from 8.19 to 8.29 in /java/maven #39202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINOR: [Java] Bump com.puppycrawl.tools:checkstyle from 8.19 to 8.29 in /java/maven #39202
Conversation
Bumps [com.puppycrawl.tools:checkstyle](https://github.com/checkstyle/checkstyle) from 8.19 to 8.29. - [Release notes](https://github.com/checkstyle/checkstyle/releases) - [Commits](checkstyle/checkstyle@checkstyle-8.19...checkstyle-8.29) --- updated-dependencies: - dependency-name: com.puppycrawl.tools:checkstyle dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or In the case of PARQUET issues on JIRA the title also supports: See also: |
|
should we close this? |
|
I think we should try to get this minor version bump in if possible. If it's a large effort I'd rather spend that switching to google-java-format instead. |
|
I can take a look. |
|
PR to replace this is created here: #39694 |
…29 (#39694) ### Rationale for this change This PR was created in place of #39202 to integrate the `puppycrawl.tools.checkstyle` upgrade. ### What changes are included in this PR? Style changes in Java classes and core changes to the style format itself. Some unsupported attributes have been removed. And some attributes have been reorganized upon the provided guidelines in the documentation. ### Are these changes tested? N/A Tested by existing checkstyle guideline. ### Are there any user-facing changes? No * Closes: #39946 Lead-authored-by: Vibhatha Lakmal Abeykoon <vibhatha@gmail.com> Co-authored-by: vibhatha <vibhatha@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>
|
@lidavidm I think we could close this. |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
… to 8.29 (apache#39694) ### Rationale for this change This PR was created in place of apache#39202 to integrate the `puppycrawl.tools.checkstyle` upgrade. ### What changes are included in this PR? Style changes in Java classes and core changes to the style format itself. Some unsupported attributes have been removed. And some attributes have been reorganized upon the provided guidelines in the documentation. ### Are these changes tested? N/A Tested by existing checkstyle guideline. ### Are there any user-facing changes? No * Closes: apache#39946 Lead-authored-by: Vibhatha Lakmal Abeykoon <vibhatha@gmail.com> Co-authored-by: vibhatha <vibhatha@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>
…29 (#39694) ### Rationale for this change This PR was created in place of apache/arrow#39202 to integrate the `puppycrawl.tools.checkstyle` upgrade. ### What changes are included in this PR? Style changes in Java classes and core changes to the style format itself. Some unsupported attributes have been removed. And some attributes have been reorganized upon the provided guidelines in the documentation. ### Are these changes tested? N/A Tested by existing checkstyle guideline. ### Are there any user-facing changes? No * Closes: #39946 Lead-authored-by: Vibhatha Lakmal Abeykoon <vibhatha@gmail.com> Co-authored-by: vibhatha <vibhatha@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>
…29 (#39694) ### Rationale for this change This PR was created in place of apache/arrow#39202 to integrate the `puppycrawl.tools.checkstyle` upgrade. ### What changes are included in this PR? Style changes in Java classes and core changes to the style format itself. Some unsupported attributes have been removed. And some attributes have been reorganized upon the provided guidelines in the documentation. ### Are these changes tested? N/A Tested by existing checkstyle guideline. ### Are there any user-facing changes? No * Closes: #39946 Lead-authored-by: Vibhatha Lakmal Abeykoon <vibhatha@gmail.com> Co-authored-by: vibhatha <vibhatha@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>
Bumps com.puppycrawl.tools:checkstyle from 8.19 to 8.29.
Release notes
Sourced from com.puppycrawl.tools:checkstyle's releases.
Commits
8933d03[maven-release-plugin] prepare release checkstyle-8.29bd45909Issue #7487: refactor code to use DetailAST.hasChildren()317e51fIssue #7487: add method hasChildren() to DetailAST89b4dcdIssue #3238: Java 8 Grammar: annotations on arrays and varargs252cd89dependency: bump junit-pioneer from 0.5.1 to 0.5.22ee2615dependency: bump junit.version from 5.5.2 to 5.6.04ed7cb8minor: add space before xml comment end '-->' to ease reading and make links ...c46a16dIssue #7468: disable 'external-parameter-entities' feature by defaultdfed794minor: add missing test case to SuperCloneCheckTest24e7bdfdependency: bump antlr4.version from 4.7.2 to 4.8-1You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.