GH-39628: [C++] Use -j1 for cmake >= 3.28 #39629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Member
Author
|
@github-actions crossbow submit test-r-depsource-bundled r-binary-packages |
assignUser
force-pushed
the
use-j1-328
branch
from
cfa6e81 to
fa07594
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
Revision: fa07594 Submitted crossbow builds: ursacomputing/crossbow @ actions-1dcd458160
|
Member
Author
|
@github-actions crossbow submit test-r-depsource-bundled |
|
Revision: ccea0a0 Submitted crossbow builds: ursacomputing/crossbow @ actions-9485687db7
|
github-actions
bot
added
awaiting merge
raulcd
reviewed
Jan 16, 2024
github-actions
bot
added
awaiting changes
assignUser
added a commit
that referenced
this pull request
Jan 17, 2024
### Rationale for this change Prevent 'bad file descriptor' issue. ### What changes are included in this PR? Use -j1 for make on CMake >= 3.28 ### Are these changes tested? Crossbow * Closes: #39628 Authored-by: Jacob Wujciak-Jens <jacob@wujciak.de> Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 980e7d7. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them. |
pitrou
added a commit
that referenced
this pull request
Jan 23, 2024
Revert #39629: it makes all builds using CMake >= 3.28 much slower, while only addressing a very specific build failure. Hopefully we can find a more targeted workaround. Authored-by: Antoine Pitrou <pitrou@free.fr> Signed-off-by: Antoine Pitrou <antoine@python.org>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
### Rationale for this change Prevent 'bad file descriptor' issue. ### What changes are included in this PR? Use -j1 for make on CMake >= 3.28 ### Are these changes tested? Crossbow * Closes: apache#39628 Authored-by: Jacob Wujciak-Jens <jacob@wujciak.de> Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…he#39736) Revert apache#39629: it makes all builds using CMake >= 3.28 much slower, while only addressing a very specific build failure. Hopefully we can find a more targeted workaround. Authored-by: Antoine Pitrou <pitrou@free.fr> Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Prevent 'bad file descriptor' issue.
What changes are included in this PR?
Use -j1 for make on CMake >= 3.28
Are these changes tested?
Crossbow
make-based externalProjects when CMake >= 3.28 is used #39628