Skip to content

Conversation

@pitrou
Copy link
Member

@pitrou pitrou commented Jan 22, 2024

Revert #39629: it makes all builds using CMake >= 3.28 much slower, while only addressing a very specific build failure. Hopefully we can find a more targeted workaround.

@pitrou pitrou requested review from assignUser and kou January 22, 2024 13:58
@github-actions
Copy link

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Jan 22, 2024
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@raulcd Should we use "MINOR: ..." or "GH-XXX: ..." format for this? Or is it OK with "git revert" format?

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Jan 22, 2024
@raulcd
Copy link
Member

raulcd commented Jan 23, 2024

Should we use "MINOR: ..." or "GH-XXX: ..." format for this? Or is it OK with "git revert" format?

I think we can use both MINOR or the git revert format. This is not common and the changelog script will just ignore it. As we don't cherry-pick initially and we just branch from main when we create the maintenance branch it won't be an issue.

@pitrou pitrou changed the title Revert "GH-39628: [C++] Use -j1 for cmake >= 3.28" MINOR: Revert "GH-39628: [C++] Use -j1 for cmake >= 3.28" Jan 23, 2024
@pitrou
Copy link
Member Author

pitrou commented Jan 23, 2024

Ok, I added "MINOR". CI failures look unrelated.

@pitrou pitrou merged commit 015c2d6 into main Jan 23, 2024
@pitrou pitrou removed the awaiting merge Awaiting merge label Jan 23, 2024
@pitrou pitrou deleted the revert-39629-use-j1-328 branch January 23, 2024 10:21
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 015c2d6.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
…he#39736)

Revert apache#39629: it makes all builds using CMake >= 3.28 much slower, while only addressing a very specific build failure. Hopefully we can find a more targeted workaround.

Authored-by: Antoine Pitrou <pitrou@free.fr>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants