Skip to content

Conversation

@amoeba
Copy link
Member

@amoeba amoeba commented Dec 9, 2024

Rationale for this change

Adds R bindings to newly added hyperbolic trig and Expm1 compute functions. See #44953. Bindings prefer calling _checked variants of compute functions where applicable which follows how existing bindings have been implemented.

What changes are included in this PR?

  • R bindings for hyperbolic trig compute functions
  • R bindings for Expm1(Exponent) compute function
  • Adds missing dplyr binding for base::atan
  • Adds missing documentation for atan (not directly related to this PR)
  • Updates to NEWS.md

Are these changes tested?

Yes.

Are there any user-facing changes?

New compute bindings in R.

@github-actions github-actions bot added the awaiting review Awaiting review label Dec 9, 2024
@amoeba
Copy link
Member Author

amoeba commented Dec 9, 2024

This PR branch is currently based on #44630 and I'll rebase and force-push once that's merged. I still need to:

  • Add the Expm1(Exponent) binding and
  • Verify both sets of bindings are tested adequately

Copy link
Member

@jonkeane jonkeane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! One minor comment and one question

@github-actions github-actions bot added awaiting merge Awaiting merge awaiting review Awaiting review awaiting committer review Awaiting committer review and removed awaiting review Awaiting review awaiting merge Awaiting merge labels Dec 10, 2024
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels May 1, 2025
@github-actions github-actions bot added awaiting change review Awaiting change review awaiting changes Awaiting changes and removed awaiting changes Awaiting changes awaiting change review Awaiting change review labels May 1, 2025
@github-actions github-actions bot removed the awaiting changes Awaiting changes label May 1, 2025
@github-actions github-actions bot added the awaiting change review Awaiting change review label May 1, 2025
@thisisnic thisisnic force-pushed the feature/GH-44953--r-compute-bindings branch from f5b846a to d9f5a35 Compare May 1, 2025 13:45
@thisisnic thisisnic merged commit 8b0ebb9 into apache:main May 1, 2025
10 checks passed
@thisisnic thisisnic removed the awaiting change review Awaiting change review label May 1, 2025
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 8b0ebb9.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

})

test_that("expm1()", {
skip_if_arrow_version_less_than("18.1.0.9000", "`expm1()` not available until version 19.")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, coming back and looking at this again, do we need to skip based on version here? These tests were added at the same time the functions were, so won't be run against older versions at all — right? Were they failing for some other reason? I can clean this up in #46294 but maybe I'm missing some reason they are important here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit unsure what we have running on our extensive CI these days, but if we don't have anywhere where we run current R arrow combined with older C++ arrow, then yep, we shouldn't need this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do test across versions of libarrow (maybe that failed when you were looking at this? It doesn't look like it from the commit history, but maybe I'm missing it), though looking at the discussion in #43623 it looks like no one is interested in maintaining + teaching folks about libarrow cross compatibility such that it's worth it to keep that job + the maintenance cost of that.

I'll try removing / reverting in my other PR and see though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants