-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-44953: [R] Add R bindings for new compute functions #44971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-44953: [R] Add R bindings for new compute functions #44971
Conversation
|
This PR branch is currently based on #44630 and I'll rebase and force-push once that's merged. I still need to:
|
de2ca98 to
dd01aae
Compare
jonkeane
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! One minor comment and one question
f5b846a to
d9f5a35
Compare
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 8b0ebb9. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
| }) | ||
|
|
||
| test_that("expm1()", { | ||
| skip_if_arrow_version_less_than("18.1.0.9000", "`expm1()` not available until version 19.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, coming back and looking at this again, do we need to skip based on version here? These tests were added at the same time the functions were, so won't be run against older versions at all — right? Were they failing for some other reason? I can clean this up in #46294 but maybe I'm missing some reason they are important here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit unsure what we have running on our extensive CI these days, but if we don't have anywhere where we run current R arrow combined with older C++ arrow, then yep, we shouldn't need this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do test across versions of libarrow (maybe that failed when you were looking at this? It doesn't look like it from the commit history, but maybe I'm missing it), though looking at the discussion in #43623 it looks like no one is interested in maintaining + teaching folks about libarrow cross compatibility such that it's worth it to keep that job + the maintenance cost of that.
I'll try removing / reverting in my other PR and see though
Rationale for this change
Adds R bindings to newly added hyperbolic trig and Expm1 compute functions. See #44953. Bindings prefer calling
_checkedvariants of compute functions where applicable which follows how existing bindings have been implemented.What changes are included in this PR?
base::atanAre these changes tested?
Yes.
Are there any user-facing changes?
New compute bindings in R.