-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[BEAM-9795] Support custom avro DatumWriters when writing to BigQuery #11479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8a92ddc to
ce75c4f
Compare
|
hm, looks like the precommit is failing with: which hopefully my change didn't break ;) |
|
Hi Steve! thanks for the feature. I'll take a look hopefully by friday |
|
thanks! |
|
bump? |
|
ah yes sorry Steve. Thanks for the contribution. This looks good to me. I'll just rerun precomits to get a green run, and run postcommits as well. |
|
Run Java PostCommit |
|
Run Java PreCommit |
|
thanks! I'm going to have a similar PR for AvroIO coming up, do you know who's best to review that? edit: hmm looks like this pre-commit broke again w/ the license error, do I need to rebase this? |
|
since it's only that task that failed, we can merge anyway. For AvroIO - I think @iemejia may be a good candidate. |
|
thanks @steveniemitz ! |
There are cases where we'd like to further control the user record -> avro process. For example, I might not want to write generic records, but instead use my own DatumWriter instance to do the avro writing.
This PR simply allows further customizing the AvroRowWriter that is created during pipeline construction, allowing the user to hook into the DatumWriter construction.
R: @pabloem @chamikaramj
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.