[BEAM-10523] Add support for custom DatumWriters to AvroIO.Write #12299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveniemitz
force-pushed
the
avro-writer
branch
from
3d55656 to
a8b5331
Compare
Contributor
Author
|
ping? |
Contributor
Author
|
@iemejia @RyanSkraba can one of you take a look at this, or recommend someone who can? |
RyanSkraba
approved these changes
Aug 18, 2020
Contributor
RyanSkraba
left a comment
RyanSkraba
left a comment
There was a problem hiding this comment.
Looks good to me, and consistent! Thanks for the contribution.
sdks/java/core/src/main/java/org/apache/beam/sdk/io/AvroIO.java
Outdated
Show resolved
Hide resolved
Member
|
Please rebase and it should be good to go. I felt a bit uneasy about making |
steveniemitz
force-pushed
the
avro-writer
branch
3 times, most recently
from
561cae9 to
6fe2d2e
Compare
steveniemitz
force-pushed
the
avro-writer
branch
from
6fe2d2e to
6bed6de
Compare
Contributor
Author
|
rebased, I think I got all the (lol there's an @ Nullable github account, oops) |
Contributor
Author
|
Run Spotless PreCommit |
Contributor
Author
|
rebased, ptal @iemejia @RyanSkraba |
Member
|
Thanks @steveniemitz now the feature looks complete 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #11641 and #11479, this change allows configuring the IO to use custom DatumWriter implementations.
R: @iemejia @RyanSkraba
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.