[BEAM-9931] Support custom Avro DatumReaders in AvroIO #11641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveniemitz
force-pushed
the
avro-source-reader
branch
from
72ccb34 to
c6ae351
Compare
steveniemitz
changed the title
iemejia
changed the title
steveniemitz
force-pushed
the
avro-source-reader
branch
from
c6ae351 to
9c3a87b
Compare
steveniemitz
force-pushed
the
avro-source-reader
branch
from
9c3a87b to
d2ca199
Compare
RyanSkraba
approved these changes
May 12, 2020
Contributor
RyanSkraba
left a comment
RyanSkraba
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the feature.
RyanSkraba
reviewed
May 12, 2020
| if (codec.equals(DataFileConstants.NULL_CODEC)) { | ||
| // Avro can read from a byte[] using a more efficient implementation. If the input is not | ||
| // compressed, pass the data in directly. | ||
| this.decoder = DecoderFactory.get().binaryDecoder(data, null); |
Contributor
There was a problem hiding this comment.
Nice, avoids the input stream wrapper.
iemejia
approved these changes
May 13, 2020
Member
iemejia
left a comment
iemejia
left a comment
There was a problem hiding this comment.
LGTM! Flawless job @steveniemitz Thanks!
| if (codec.equals(DataFileConstants.NULL_CODEC)) { | ||
| // Avro can read from a byte[] using a more efficient implementation. If the input is not | ||
| // compressed, pass the data in directly. | ||
| this.decoder = DecoderFactory.get().binaryDecoder(data, null); |
Contributor
Author
|
thanks for the quick reviews! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to PR #11479, it would be useful to be able to explicitly pass a DatumReader factory to AvroIO, and have it use that instead of GenericDatumReader or SpecificDatumReader.
This PR adds
withDatumReaderFactoryto AvroIO and plumbs it through into AvroSource.R: @iemejia
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.