[Bug] alter job is missing in iamge

[morningman]

Search before asking

• I had searched in the issues and found no similar issues.

Version

1.0.0

What's Wrong?

in #8030, we removed lots of code about old meta data in FE,
But the logic of saveAlterJob was modified incorrectly. Cause the alter job to be lost in the image.
But this may not bring data problems, the analysis is as follows:

Case 1. Do checkpoint before job is finished.

• [image: alter job(pending)]: The job information is lost, but the data is not changed. Like nothing happened.
• [image: alter job(pending)] + [editlog: alter job(waiting_txn)]: The information in the pending stage is lost, but there is still complete job information in the edit log, and the execution can continue.

Case 2. Do checkpoint after job is finished.

• [image: alter job(finished)]: Modifications to metadata are already stored in the image, the only thing missing is the job history.

So this error does not result in a data error.
But it remains a potential risk.

What You Expected?

fix it

How to Reproduce?

No response

Anything Else?

No response

Are you willing to submit PR?

• Yes I am willing to submit a PR!

Code of Conduct

• I agree to follow this project's Code of Conduct