[Refactor] Remove old schema change rollup backend decommission code #8030
Conversation
| } | ||
| schemaChangeJob.cancel(olapTable, "user cancelled"); | ||
| } | ||
| Preconditions.checkNotNull(schemaChangeJobV2, "Table[" + tableName + "] is not under SCHEMA_CHANGE."); |
There was a problem hiding this comment.
How about throw DdlException? just like rollup job
| // alter jobs == 0 | ||
| // If the FE version upgrade from old version, if it have alter jobs, the FE will failed during start process | ||
| // the number of old version alter jobs has to be 0 | ||
| int size = 0; |
There was a problem hiding this comment.
We don't need to write this size now.
There was a problem hiding this comment.
Need write size.
When use this fe version to replace old fe version, the old fe version does not have any old alter jobs, so that the size == 0. And the new fe version will load size and find it is 0, so that it will skip to load old alter jobs.
If not write size = 0, the new fe version dump the image and try to restart it will fail because it will load size...
|
|
||
| // finished or cancelled jobs | ||
| size = finishedOrCancelledAlterJobs.size(); | ||
| size = 0; |
There was a problem hiding this comment.
We don't need to write this size now.
There was a problem hiding this comment.
Need write size.
When use this fe version to replace old fe version, the old fe version does not have any old alter jobs, so that the size == 0. And the new fe version will load size and find it is 0, so that it will skip to load old alter jobs.
If not write size = 0, the new fe version dump the image and try to restart it will fail because it will load size...
Co-authored-by: Mingyu Chen <morningman.cmy@gmail.com>
Co-authored-by: Mingyu Chen <morningman.cmy@gmail.com>
Co-authored-by: Mingyu Chen <morningman.cmy@gmail.com>
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
This bug is introduced from #8030
…e#9329) This bug is introduced from apache#8030
This bug is introduced from #8030
…e#9329) This bug is introduced from apache#8030
…e#9329) This bug is introduced from apache#8030
…e#9329) This bug is introduced from apache#8030
2 participants
No description provided.