Skip to content

Conversation

@morningman
Copy link
Contributor

@morningman morningman commented Apr 29, 2022

Proposed changes

Issue Number: close #9330

Problem Summary:

This bug is introduced from #8030

Checklist(Required)

  1. Does it affect the original behavior: (No)
  2. Has unit tests been added: (Nod)
  3. Has document been added or modified: (No Need)
  4. Does it need to update dependencies: (No)
  5. Are there any changes that cannot be rolled back: (No)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@morningman morningman added kind/fix Categorizes issue or PR as related to a bug. area/catalog Issues or PRs related to catalog management dev/1.0.1-deprecated should be merged into dev-1.0.1 branch labels Apr 29, 2022
@@ -2113,6 +2109,13 @@ public long saveAlterJob(CountingDataOutputStream dos, long checksum) throws IOE

public long saveAlterJob(CountingDataOutputStream dos, long checksum, JobType type) throws IOException {
Map<Long, AlterJobV2> alterJobsV2 = Maps.newHashMap();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Map<Long, AlterJobV2> alterJobsV2 = Maps.newHashMap();
Map<Long, AlterJobV2> alterJobsV2;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Member

@xy720 xy720 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2022

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels May 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2022

PR approved by anyone and no changes requested.

@morningman morningman merged commit 3baf6ce into apache:master May 3, 2022
stalary pushed a commit to stalary/doris that referenced this pull request May 5, 2022
@morningman morningman added dev/merged-1.0.1-deprecated PR has been merged into dev-1.0.1 and removed dev/1.0.1-deprecated should be merged into dev-1.0.1 branch labels May 6, 2022
morningman added a commit that referenced this pull request May 6, 2022
Kikyou1997 pushed a commit to Kikyou1997/incubator-doris that referenced this pull request May 9, 2022
starocean999 pushed a commit to starocean999/incubator-doris that referenced this pull request May 19, 2022
englefly pushed a commit to englefly/incubator-doris that referenced this pull request May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/catalog Issues or PRs related to catalog management dev/merged-1.0.1-deprecated PR has been merged into dev-1.0.1 kind/fix Categorizes issue or PR as related to a bug. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] alter job is missing in iamge

2 participants