[enhance](partitionid) check partition id to avoid unexpected behavior #28045
Conversation
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
| if (tablet_meta->partition_id() <= 0) { | ||
| LOG(WARNING) << "invalid partition id " << tablet_meta->partition_id() << ", tablet " | ||
| << tablet_meta->tablet_id(); | ||
| return nullptr; |
There was a problem hiding this comment.
Will it cause NPE for caller?
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
* [fix](hudi-catalog) fix hudi catalog code (#27966) backport: #27963 * [fix](Nereids): fix datetime fold-constant-be in Branch-2.0 (#27938) fix fold-constant-be datetimev2 will lose the scale of datetime. * [bug](function) fix compound expr coredump problem #27988 (#27989) * [branch-2.0](cache) Fix partition cache support DATEV2 #27978 (#27990) * [branch-2.0] delete auto partition docs (#28001) * [fix](stats) Drop stats or update updated rows after truncate table (#27956) 1. Also clear follower's stats cache when doing drop stats. 2. Drop stats when truncate a table. backport #27931 * [minor](stats) truncate min/max if too long #27955 (#27997) * [agg](profile) fix incorrect profile (#28004) (#28035) * [fix](remote-scanner-pool) missing _remote_thread_pool_max_size value #28057 (#28053) bp #28057 * [enhance](partitionid) check partition id to avoid unexpected behavior (#28045) * [opt](resource-tag) root and admin user can use any resource tag by default #28088 (#28080) bp #28088 * [compile](compile option) add deflate to X86 only (#28089) * change version to 2.0.3-rc05-var05 * [fix](Nereids): Preserve `""` in single quote strings and `''` in double quote strings. (#27959) --------- Co-authored-by: Tiewei Fang <43782773+BePPPower@users.noreply.github.com> Co-authored-by: jakevin <jakevingoo@gmail.com> Co-authored-by: HappenLee <happenlee@hotmail.com> Co-authored-by: Xinyi Zou <zouxinyi02@gmail.com> Co-authored-by: zclllyybb <zhaochangle@selectdb.com> Co-authored-by: Jibing-Li <64681310+Jibing-Li@users.noreply.github.com> Co-authored-by: AKIRA <33112463+Kikyou1997@users.noreply.github.com> Co-authored-by: TengJianPing <18241664+jacktengg@users.noreply.github.com> Co-authored-by: Mingyu Chen <morningman@163.com> Co-authored-by: Yongqiang YANG <98214048+dataroaring@users.noreply.github.com> Co-authored-by: shuke <37901441+shuke987@users.noreply.github.com> Co-authored-by: 谢健 <jianxie0@gmail.com>
3 participants
Proposed changes
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...