Skip to content

[compile](compile option) add deflate to X86 only #28089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 2 commits into from
Dec 7, 2023
Merged

[compile](compile option) add deflate to X86 only #28089

yiguolei merged 2 commits into from
Dec 7, 2023

Conversation

@shuke987
Copy link
Collaborator

@shuke987 shuke987 commented Dec 6, 2023

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@shuke987
Copy link
Collaborator Author

shuke987 commented Dec 6, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2023

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Dec 6, 2023

TeamCity be ut coverage result:
Function Coverage: 37.94% (7980/21035)
Line Coverage: 29.65% (64745/218399)
Region Coverage: 29.07% (33329/114660)
Branch Coverage: 24.93% (17117/68668)
Coverage Report: http://coverage.selectdb-in.cc/coverage/d9fd8399755cc4270dff6a86146684e99de2bb65_d9fd8399755cc4270dff6a86146684e99de2bb65/report/index.html

@doris-robot
Copy link

doris-robot commented Dec 6, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 49.96 seconds
stream load tsv: 573 seconds loaded 74807831229 Bytes, about 124 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.8 seconds inserted 10000000 Rows, about 335K ops/s
storage size: 17161300247 Bytes

@shuke987 shuke987 requested a review from morningman December 7, 2023 01:24
yiguolei
yiguolei approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit f971e1d into apache:branch-2.0 Dec 7, 2023
eldenmoon pushed a commit to eldenmoon/incubator-doris that referenced this pull request Dec 8, 2023
@shuke987 @eldenmoon
[compile](compile option) add deflate to X86 only (apache#28089)
f39ad29
eldenmoon added a commit that referenced this pull request Dec 8, 2023
@eldenmoon @BePPPower
@jackwener @HappenLee @xinyiZzz @zclllyybb @Jibing-Li @Kikyou1997 @jacktengg @morningman @dataroaring @shuke987 @keanji-x
[pick](branch-2.0) pick prs from branch-2.0 (#28176)
9d5f314 
* [fix](hudi-catalog) fix hudi catalog code (#27966)

backport: #27963

* [fix](Nereids): fix datetime fold-constant-be in Branch-2.0 (#27938)

fix fold-constant-be datetimev2 will lose the scale of datetime.

* [bug](function) fix compound expr coredump problem #27988 (#27989)

* [branch-2.0](cache) Fix partition cache support DATEV2  #27978 (#27990)

* [branch-2.0] delete auto partition docs (#28001)

* [fix](stats) Drop stats or update updated rows after truncate table (#27956)

1. Also clear follower's stats cache when doing drop stats.
2. Drop stats when truncate a table.

backport #27931

* [minor](stats) truncate min/max if too long #27955 (#27997)

* [agg](profile) fix incorrect profile (#28004) (#28035)

* [fix](remote-scanner-pool) missing _remote_thread_pool_max_size value #28057 (#28053)

bp #28057

* [enhance](partitionid) check partition id to avoid unexpected behavior (#28045)

* [opt](resource-tag) root and admin user can use any resource tag by default #28088 (#28080)

bp #28088

* [compile](compile option) add deflate to X86 only (#28089)

* change version to 2.0.3-rc05-var05

* [fix](Nereids): Preserve `""` in single quote strings and `''` in double quote strings. (#27959)

---------

Co-authored-by: Tiewei Fang <43782773+BePPPower@users.noreply.github.com>
Co-authored-by: jakevin <jakevingoo@gmail.com>
Co-authored-by: HappenLee <happenlee@hotmail.com>
Co-authored-by: Xinyi Zou <zouxinyi02@gmail.com>
Co-authored-by: zclllyybb <zhaochangle@selectdb.com>
Co-authored-by: Jibing-Li <64681310+Jibing-Li@users.noreply.github.com>
Co-authored-by: AKIRA <33112463+Kikyou1997@users.noreply.github.com>
Co-authored-by: TengJianPing <18241664+jacktengg@users.noreply.github.com>
Co-authored-by: Mingyu Chen <morningman@163.com>
Co-authored-by: Yongqiang YANG <98214048+dataroaring@users.noreply.github.com>
Co-authored-by: shuke <37901441+shuke987@users.noreply.github.com>
Co-authored-by: 谢健 <jianxie0@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

@morningman morningman Awaiting requested review from morningman

Assignees

No one assigned

Labels

dev/2.0.3-merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shuke987 @doris-robot @yiguolei