[fix](remote-scanner-pool) missing _remote_thread_pool_max_size value #28057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
morningman
added a commit
that referenced
this pull request
Dec 6, 2023
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
ByteYue
approved these changes
Dec 7, 2023
Contributor
|
PR approved by anyone and no changes requested. |
eldenmoon
pushed a commit
to eldenmoon/incubator-doris
that referenced
this pull request
Dec 8, 2023
eldenmoon
added a commit
that referenced
this pull request
Dec 8, 2023
* [fix](hudi-catalog) fix hudi catalog code (#27966) backport: #27963 * [fix](Nereids): fix datetime fold-constant-be in Branch-2.0 (#27938) fix fold-constant-be datetimev2 will lose the scale of datetime. * [bug](function) fix compound expr coredump problem #27988 (#27989) * [branch-2.0](cache) Fix partition cache support DATEV2 #27978 (#27990) * [branch-2.0] delete auto partition docs (#28001) * [fix](stats) Drop stats or update updated rows after truncate table (#27956) 1. Also clear follower's stats cache when doing drop stats. 2. Drop stats when truncate a table. backport #27931 * [minor](stats) truncate min/max if too long #27955 (#27997) * [agg](profile) fix incorrect profile (#28004) (#28035) * [fix](remote-scanner-pool) missing _remote_thread_pool_max_size value #28057 (#28053) bp #28057 * [enhance](partitionid) check partition id to avoid unexpected behavior (#28045) * [opt](resource-tag) root and admin user can use any resource tag by default #28088 (#28080) bp #28088 * [compile](compile option) add deflate to X86 only (#28089) * change version to 2.0.3-rc05-var05 * [fix](Nereids): Preserve `""` in single quote strings and `''` in double quote strings. (#27959) --------- Co-authored-by: Tiewei Fang <43782773+BePPPower@users.noreply.github.com> Co-authored-by: jakevin <jakevingoo@gmail.com> Co-authored-by: HappenLee <happenlee@hotmail.com> Co-authored-by: Xinyi Zou <zouxinyi02@gmail.com> Co-authored-by: zclllyybb <zhaochangle@selectdb.com> Co-authored-by: Jibing-Li <64681310+Jibing-Li@users.noreply.github.com> Co-authored-by: AKIRA <33112463+Kikyou1997@users.noreply.github.com> Co-authored-by: TengJianPing <18241664+jacktengg@users.noreply.github.com> Co-authored-by: Mingyu Chen <morningman@163.com> Co-authored-by: Yongqiang YANG <98214048+dataroaring@users.noreply.github.com> Co-authored-by: shuke <37901441+shuke987@users.noreply.github.com> Co-authored-by: 谢健 <jianxie0@gmail.com>
XuJianxu
pushed a commit
to XuJianxu/doris
that referenced
this pull request
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The assignment of
_remote_thread_pool_max_sizeis missing in #27053.It will result the maxConnection in S3 client to be 0, and block some operation such as list file in s3.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...