[fix](pipeline) Fix query hang if limited rows is reached #35466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 40258 ms |
TPC-DS: Total hot run time: 173466 ms |
ClickBench: Total hot run time: 30.42 s |
|
TeamCity be ut coverage result: |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
BiteTheDDDDt
approved these changes
May 28, 2024
yiguolei
pushed a commit
that referenced
this pull request
May 28, 2024
## Proposed changes Some operators has limit condition, the source operator should notify the sink operator that limit reached. Although FE has limit logic but it not always send . ## Further comments If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
dataroaring
pushed a commit
that referenced
this pull request
May 28, 2024
## Proposed changes Some operators has limit condition, the source operator should notify the sink operator that limit reached. Although FE has limit logic but it not always send . ## Further comments If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
Gabriel39
added a commit
that referenced
this pull request
May 31, 2024
Follow-up for #35466. We should assure closed tasks will not block other tasks.
Gabriel39
added a commit
to Gabriel39/incubator-doris
that referenced
this pull request
May 31, 2024
…35513) Follow-up for apache#35466. We should assure closed tasks will not block other tasks.
yiguolei
pushed a commit
that referenced
this pull request
May 31, 2024
dataroaring
pushed a commit
that referenced
this pull request
Jun 4, 2024
Follow-up for #35466. We should assure closed tasks will not block other tasks.
seawinde
pushed a commit
to seawinde/doris
that referenced
this pull request
Jun 5, 2024
…35513) Follow-up for apache#35466. We should assure closed tasks will not block other tasks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Some operators has limit condition, the source operator should notify the sink operator that limit reached.
Although FE has limit logic but it not always send .
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...