-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](pipeline) Fix query hang up if limited rows is reached #35513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
|
run buildall |
TPC-H: Total hot run time: 42132 ms |
TPC-DS: Total hot run time: 170036 ms |
ClickBench: Total hot run time: 30.24 s |
|
run buildall |
TPC-H: Total hot run time: 39805 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 169396 ms |
ClickBench: Total hot run time: 30.36 s |
|
run buildall |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 42170 ms |
TPC-DS: Total hot run time: 171852 ms |
ClickBench: Total hot run time: 30.48 s |
|
run buildall |
TPC-H: Total hot run time: 41196 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 169766 ms |
ClickBench: Total hot run time: 30.52 s |
|
run buildall |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 42278 ms |
TPC-DS: Total hot run time: 168840 ms |
ClickBench: Total hot run time: 30.34 s |
TPC-H: Total hot run time: 40476 ms |
TPC-DS: Total hot run time: 171721 ms |
|
TeamCity be ut coverage result: |
ClickBench: Total hot run time: 30.26 s |
| RuntimeProfile::Counter* compress_timer() { return _compress_timer; } | ||
| RuntimeProfile::Counter* uncompressed_bytes_counter() { return _uncompressed_bytes_counter; } | ||
| [[nodiscard]] bool transfer_large_data_by_brpc() const; | ||
| bool eos() const override { return _reach_limit.load(); } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename to is_finished
|
run buildall |
yiguolei
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
run buildall |
TPC-H: Total hot run time: 39993 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 169393 ms |
ClickBench: Total hot run time: 30.74 s |
|
PR approved by at least one committer and no changes requested. |
HappenLee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…35513) Follow-up for apache#35466. We should assure closed tasks will not block other tasks.
Follow-up for #35466. We should assure closed tasks will not block other tasks.
…35513) Follow-up for apache#35466. We should assure closed tasks will not block other tasks.
Proposed changes
Follow-up for #35466.
We should assure closed tasks will not block other tasks.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...