Skip to content

Conversation

@Gabriel39
Copy link
Contributor

Follow-up for #35466.

We should assure closed tasks will not block other tasks.

Proposed changes

Issue Number: close #xxx

…35513)

Follow-up for apache#35466.

We should assure closed tasks will not block other tasks.
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

RuntimeState* state);
~ExchangeSinkBuffer();
RuntimeState* state, ExchangeSinkLocalState* parent = nullptr);
~ExchangeSinkBuffer() = default;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: annotate this function with 'override' or (rarely) 'final' [modernize-use-override]

Suggested change
~ExchangeSinkBuffer() = default;
~ExchangeSinkBuffer() override = default;

@yiguolei yiguolei merged commit b864aa7 into apache:branch-2.1 May 31, 2024
@yiguolei yiguolei mentioned this pull request Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants