Skip to content

Conversation

@eldenmoon
Copy link
Member

Bad cast from type:doris::vectorized::ColumnVector to doris::vectorized::ColumnObject

Check failure stack trace: ***
@ 0x562dcebca976 google::LogMessage::SendToLog()
@ 0x562dcebc73c0 google::LogMessage::Flush()
@ 0x562dcebcb1b9 google::LogMessageFatal::~LogMessageFatal()
@ 0x562d9ded39e6 assert_cast<>()
@ 0x562d9df1e599 doris::segment_v2::HierarchicalDataReader::process_read<>()
@ 0x562d9df1e106 doris::segment_v2::HierarchicalDataReader::next_batch()
@ 0x562d9df3373e doris::segment_v2::ColumnIterator::next_batch()
....
@ 0x562d9ea56d31 doris::EngineChecksumTask::_compute_checksum()
@ 0x562d9ea55cc2 doris::EngineChecksumTask::execute()
@ 0x562d9b558355 doris::check_consistency_callback()

introduced by #34925

Proposed changes

Issue Number: close #xxx

```
Bad cast from type:doris::vectorized::ColumnVector to doris::vectorized::ColumnObject

Check failure stack trace: ***
@ 0x562dcebca976 google::LogMessage::SendToLog()
@ 0x562dcebc73c0 google::LogMessage::Flush()
@ 0x562dcebcb1b9 google::LogMessageFatal::~LogMessageFatal()
@ 0x562d9ded39e6 assert_cast<>()
@ 0x562d9df1e599 doris::segment_v2::HierarchicalDataReader::process_read<>()
@ 0x562d9df1e106 doris::segment_v2::HierarchicalDataReader::next_batch()
@ 0x562d9df3373e doris::segment_v2::ColumnIterator::next_batch()
....
@ 0x562d9ea56d31 doris::EngineChecksumTask::_compute_checksum()
@ 0x562d9ea55cc2 doris::EngineChecksumTask::execute()
@ 0x562d9b558355 doris::check_consistency_callback()
```

introduced by apache#34925
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@eldenmoon
Copy link
Member Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.40% (8986/24684)
Line Coverage: 27.95% (73479/262896)
Region Coverage: 27.40% (38112/139111)
Branch Coverage: 24.01% (19350/80592)
Coverage Report: http://coverage.selectdb-in.cc/coverage/f9c53ffc52339476641d5351856ac5992896c321_f9c53ffc52339476641d5351856ac5992896c321/report/index.html

@doris-robot
Copy link

TPC-H: Total hot run time: 40096 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f9c53ffc52339476641d5351856ac5992896c321, data reload: false

------ Round 1 ----------------------------------
q1	17873	4522	4380	4380
q2	2666	244	194	194
q3	10993	1120	1115	1115
q4	10575	802	839	802
q5	7872	2698	2711	2698
q6	230	137	140	137
q7	977	627	625	625
q8	9261	2092	2086	2086
q9	8969	6457	6496	6457
q10	8951	3733	3819	3733
q11	466	242	241	241
q12	401	234	226	226
q13	17755	3003	2975	2975
q14	279	222	220	220
q15	512	488	478	478
q16	522	387	380	380
q17	966	774	687	687
q18	7958	7472	7410	7410
q19	7451	1522	1366	1366
q20	665	310	331	310
q21	4957	3330	3247	3247
q22	380	334	329	329
Total cold run time: 120679 ms
Total hot run time: 40096 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4432	4254	4216	4216
q2	386	275	268	268
q3	2985	2766	2746	2746
q4	1861	1568	1601	1568
q5	5249	5270	5303	5270
q6	219	130	127	127
q7	2127	1695	1712	1695
q8	3160	3335	3309	3309
q9	8342	8334	8281	8281
q10	3917	3711	3665	3665
q11	569	489	476	476
q12	759	576	605	576
q13	16793	2963	2957	2957
q14	289	256	260	256
q15	514	466	460	460
q16	465	404	415	404
q17	1751	1486	1452	1452
q18	7478	7572	7352	7352
q19	1668	1586	1616	1586
q20	1969	1754	1794	1754
q21	4759	4677	4778	4677
q22	597	537	532	532
Total cold run time: 70289 ms
Total hot run time: 53627 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 172744 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f9c53ffc52339476641d5351856ac5992896c321, data reload: false

query1	920	391	370	370
query2	6450	2327	2276	2276
query3	6651	206	205	205
query4	22941	17264	17251	17251
query5	4131	464	455	455
query6	241	165	162	162
query7	4594	294	294	294
query8	306	290	284	284
query9	8587	2443	2456	2443
query10	602	314	286	286
query11	10667	10087	10091	10087
query12	134	89	86	86
query13	1664	362	358	358
query14	9397	7442	7413	7413
query15	233	190	182	182
query16	8001	262	263	262
query17	1925	520	534	520
query18	2017	265	266	265
query19	206	153	157	153
query20	88	85	81	81
query21	210	137	125	125
query22	4237	3998	3900	3900
query23	33731	33055	33173	33055
query24	11978	2843	2847	2843
query25	667	358	350	350
query26	1767	154	151	151
query27	2953	317	325	317
query28	7517	2078	2086	2078
query29	1037	631	604	604
query30	285	151	152	151
query31	946	701	763	701
query32	95	55	55	55
query33	774	301	292	292
query34	927	491	494	491
query35	728	640	608	608
query36	1060	968	910	910
query37	187	70	69	69
query38	2900	2743	2751	2743
query39	853	781	775	775
query40	286	128	122	122
query41	53	52	54	52
query42	115	95	97	95
query43	595	539	548	539
query44	1163	718	729	718
query45	199	164	164	164
query46	1111	729	733	729
query47	1863	1766	1776	1766
query48	370	301	296	296
query49	1194	396	399	396
query50	773	386	394	386
query51	6747	6593	6592	6592
query52	112	90	97	90
query53	359	288	293	288
query54	921	451	468	451
query55	76	71	70	70
query56	282	253	261	253
query57	1136	1034	1052	1034
query58	235	243	239	239
query59	3558	3048	3071	3048
query60	292	285	284	284
query61	95	90	90	90
query62	638	454	453	453
query63	308	286	287	286
query64	9893	2293	1734	1734
query65	3234	3139	3142	3139
query66	1369	343	340	340
query67	15408	14843	15270	14843
query68	4629	541	546	541
query69	499	407	367	367
query70	1192	1069	1147	1069
query71	407	275	272	272
query72	6989	5247	5636	5247
query73	760	329	326	326
query74	5875	5424	5559	5424
query75	3402	2663	2618	2618
query76	2741	918	1011	918
query77	500	288	289	288
query78	10278	9809	9887	9809
query79	2181	517	507	507
query80	879	448	459	448
query81	597	225	218	218
query82	734	105	99	99
query83	261	173	168	168
query84	242	84	85	84
query85	1684	286	273	273
query86	484	332	333	332
query87	3277	3087	3079	3079
query88	3952	2466	2433	2433
query89	471	376	391	376
query90	1825	189	192	189
query91	127	101	100	100
query92	65	49	48	48
query93	2202	516	502	502
query94	1270	184	187	184
query95	394	320	392	320
query96	596	276	266	266
query97	3246	3062	3051	3051
query98	222	201	196	196
query99	1227	846	844	844
Total cold run time: 278200 ms
Total hot run time: 172744 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.09 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f9c53ffc52339476641d5351856ac5992896c321, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.04	0.03
query3	0.22	0.05	0.06
query4	1.67	0.09	0.08
query5	0.52	0.48	0.50
query6	1.11	0.73	0.74
query7	0.01	0.01	0.02
query8	0.05	0.04	0.04
query9	0.54	0.48	0.49
query10	0.54	0.54	0.54
query11	0.16	0.11	0.11
query12	0.14	0.12	0.12
query13	0.60	0.60	0.61
query14	0.78	0.80	0.78
query15	0.84	0.82	0.82
query16	0.37	0.38	0.36
query17	1.04	1.04	0.99
query18	0.23	0.22	0.26
query19	1.81	1.78	1.84
query20	0.01	0.01	0.01
query21	15.41	0.66	0.64
query22	4.12	7.31	2.14
query23	18.35	1.37	1.39
query24	2.18	0.23	0.21
query25	0.15	0.08	0.08
query26	0.28	0.18	0.17
query27	0.07	0.08	0.07
query28	13.14	1.02	1.01
query29	12.64	3.32	3.30
query30	0.26	0.07	0.05
query31	2.86	0.40	0.38
query32	3.28	0.50	0.48
query33	2.89	2.94	2.92
query34	17.20	4.43	4.47
query35	4.51	4.51	4.52
query36	0.64	0.47	0.47
query37	0.18	0.15	0.16
query38	0.15	0.15	0.14
query39	0.05	0.04	0.03
query40	0.18	0.15	0.15
query41	0.10	0.05	0.05
query42	0.05	0.04	0.04
query43	0.04	0.04	0.04
Total cold run time: 109.49 s
Total hot run time: 31.09 s

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Jun 13, 2024
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@xiaokang xiaokang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiaokang xiaokang merged commit 91b4a4c into apache:master Jun 13, 2024
dataroaring pushed a commit that referenced this pull request Jun 13, 2024
)

```
Bad cast from type:doris::vectorized::ColumnVector to doris::vectorized::ColumnObject

Check failure stack trace: ***
@ 0x562dcebca976 google::LogMessage::SendToLog()
@ 0x562dcebc73c0 google::LogMessage::Flush()
@ 0x562dcebcb1b9 google::LogMessageFatal::~LogMessageFatal()
@ 0x562d9ded39e6 assert_cast<>()
@ 0x562d9df1e599 doris::segment_v2::HierarchicalDataReader::process_read<>()
@ 0x562d9df1e106 doris::segment_v2::HierarchicalDataReader::next_batch()
@ 0x562d9df3373e doris::segment_v2::ColumnIterator::next_batch()
....
@ 0x562d9ea56d31 doris::EngineChecksumTask::_compute_checksum()
@ 0x562d9ea55cc2 doris::EngineChecksumTask::execute()
@ 0x562d9b558355 doris::check_consistency_callback()
```

introduced by #34925
eldenmoon added a commit to eldenmoon/incubator-doris that referenced this pull request Jul 10, 2024
…che#36201)

```
Bad cast from type:doris::vectorized::ColumnVector to doris::vectorized::ColumnObject

Check failure stack trace: ***
@ 0x562dcebca976 google::LogMessage::SendToLog()
@ 0x562dcebc73c0 google::LogMessage::Flush()
@ 0x562dcebcb1b9 google::LogMessageFatal::~LogMessageFatal()
@ 0x562d9ded39e6 assert_cast<>()
@ 0x562d9df1e599 doris::segment_v2::HierarchicalDataReader::process_read<>()
@ 0x562d9df1e106 doris::segment_v2::HierarchicalDataReader::next_batch()
@ 0x562d9df3373e doris::segment_v2::ColumnIterator::next_batch()
....
@ 0x562d9ea56d31 doris::EngineChecksumTask::_compute_checksum()
@ 0x562d9ea55cc2 doris::EngineChecksumTask::execute()
@ 0x562d9b558355 doris::check_consistency_callback()
```

introduced by apache#34925
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.5-merged dev/3.0.0-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants