-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Fix](Variant) fix variant schema change may cause invalid block schema and write missing blocks #36317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 39534 ms |
TPC-DS: Total hot run time: 169487 ms |
ClickBench: Total hot run time: 31.49 s |
xiaokang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls add testcase
…ma and write missing blocks 1. update_rowset_schema should not update _context.tablet_schema, since it's used as src schema for schema change, if it's changed may lead to wrong schema with block 2. buffering block during schema change should merge first and then flush, otherwise may lost current block
done |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 39933 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 172576 ms |
ClickBench: Total hot run time: 30.43 s |
xiaokang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
csun5285
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ma and write missing blocks (apache#36317) buffering block during schema change should merge first and then flush, otherwise may lost current block
…ma and write missing blocks (#36317) 1. update_rowset_schema should not update _context.tablet_schema, since it's used as src schema for schema change, if it's changed may lead to wrong schema with block 2. buffering block during schema change should merge first and then flush, otherwise may lost current block
…ma and write missing blocks (apache#36317) 1. update_rowset_schema should not update _context.tablet_schema, since it's used as src schema for schema change, if it's changed may lead to wrong schema with block 2. buffering block during schema change should merge first and then flush, otherwise may lost current block
…ma and write missing blocks
Proposed changes
Issue Number: close #xxx