-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Fix](Variant) fix variant partial update with row store enabled #36793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 42960 ms |
TPC-DS: Total hot run time: 172992 ms |
ClickBench: Total hot run time: 30.92 s |
505c62c to
4ac1288
Compare
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 39912 ms |
TPC-DS: Total hot run time: 174674 ms |
ClickBench: Total hot run time: 29.91 s |
qidaye
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
xiaokang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
) 1. Variant use serialize_one_row_to_string to string and then parse to jsonb as row store.Since we could not get the original string after #34925 2. Remove redundant code
…che#36793) 1. Variant use serialize_one_row_to_string to string and then parse to jsonb as row store.Since we could not get the original string after 2. Remove redundant code
Proposed changes
Issue Number: close #xxx