[Fix]only publish topic to alive be #40535

wangbo · 2024-09-09T06:21:46Z

Proposed changes

Fix strange core stack when BE not start correctly, and FE send publish topic request.

before

BRPC service did not start correctly, exiting
*** Query id: 0-0 ***
*** is nereids: 0 ***
*** tablet id: 0 ***
*** Aborted at 1725862245 (unix time) try "date -d @1725862245" if you are using GNU date ***
*** Current BE git commitID: 903c05b3af ***
*** SIGSEGV unknown detail explain (@0x0) received by PID 2983204 (TID 2983204 OR 0x7f70dd18ca80) from PID 0; stack trace: ***
 0# doris::signal::(anonymous namespace)::FailureSignalHandler(int, siginfo_t*, void*) at /mnt/disk2/wangbo/git/doris/be/src/common/signal_handler.h:421
 1# 0x00007F70DB554B50 in /lib64/libc.so.6
 2# __GI___pthread_mutex_lock in /lib64/libpthread.so.0
 3# rocksdb::ThreadPoolImpl::Impl::UnSchedule(void*) in /mnt/disk2/wangbo/runtime/tmp/be/lib/doris_be
 4# rocksdb::DBImpl::CloseHelper() in /mnt/disk2/wangbo/runtime/tmp/be/lib/doris_be
 5# rocksdb::DBImpl::Close() in /mnt/disk2/wangbo/runtime/tmp/be/lib/doris_be
 6# std::_Function_handler<void (rocksdb::DB*), doris::OlapMeta::init()::$_0>::_M_invoke(std::_Any_data const&, rocksdb::DB*&&) at /mnt/disk2/wangbo/tools/ldb/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/std_function.h:291
 7# doris::OlapMeta::~OlapMeta() at /mnt/disk2/wangbo/git/doris/be/src/olap/olap_meta.cpp:66
 8# doris::DataDir::~DataDir() at /mnt/disk2/wangbo/git/doris/be/src/olap/data_dir.cpp:142
 9# std::_Rb_tree<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::unique_ptr<doris::DataDir, std::default_delete<doris::DataDir> > >, std::_Select1st<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::unique_ptr<doris::DataDir, std::default_delete<doris::DataDir> > > >, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::unique_ptr<doris::DataDir, std::default_delete<doris::DataDir> > > > >::_M_erase(std::_Rb_tree_node<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::unique_ptr<doris::DataDir, std::default_delete<doris::DataDir> > > >*) at /mnt/disk2/wangbo/tools/ldb/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/stl_tree.h:1889
10# doris::StorageEngine::~StorageEngine() at /mnt/disk2/wangbo/git/doris/be/src/olap/storage_engine.cpp:224
11# doris::StorageEngine::~StorageEngine() at /mnt/disk2/wangbo/git/doris/be/src/olap/storage_engine.cpp:222
12# doris::ExecEnv::destroy() at /mnt/disk2/wangbo/git/doris/be/src/runtime/exec_env_init.cpp:669
13# doris::ExecEnv::~ExecEnv() at /mnt/disk2/wangbo/git/doris/be/src/runtime/exec_env.cpp:45
14# __run_exit_handlers in /lib64/libc.so.6
15# on_exit in /lib64/libc.so.6
16# 0x000055A48A9DC9CA at /mnt/disk2/wangbo/git/doris/be/src/service/doris_main.cpp:548
17# main at /mnt/disk2/wangbo/git/doris/be/src/service/doris_main.cpp:576
18# __libc_start_main in /lib64/libc.so.6
19# _start in /mnt/disk2/wangbo/runtime/tmp/be/lib/doris_be

after:

start BE in local mode
BRPC service did not start correctly, exiting

doris-robot · 2024-09-09T06:21:52Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

wangbo · 2024-09-09T06:22:04Z

run buildall

doris-robot · 2024-09-09T06:40:35Z

TPC-H: Total hot run time: 38274 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 53b931d938b6fcb30e9039ee8bbda43873de73b7, data reload: false

------ Round 1 ----------------------------------
q1	17626	4389	4300	4300
q2	2030	195	187	187
q3	10455	1157	1136	1136
q4	10120	710	761	710
q5	7931	2911	2808	2808
q6	230	142	142	142
q7	980	638	639	638
q8	9606	2065	2091	2065
q9	7288	6569	6578	6569
q10	7027	2235	2246	2235
q11	479	241	241	241
q12	416	220	221	220
q13	18829	3088	3116	3088
q14	284	251	237	237
q15	534	497	483	483
q16	544	426	431	426
q17	968	679	705	679
q18	7488	6934	6858	6858
q19	1397	1016	1018	1016
q20	679	341	322	322
q21	3995	3135	2899	2899
q22	1148	1015	1018	1015
Total cold run time: 110054 ms
Total hot run time: 38274 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4348	4323	4317	4317
q2	381	275	274	274
q3	2929	2716	2662	2662
q4	1911	1656	1675	1656
q5	5405	5390	5429	5390
q6	217	130	128	128
q7	2158	1777	1741	1741
q8	3198	3376	3308	3308
q9	8460	8522	8483	8483
q10	3490	3213	3226	3213
q11	588	500	527	500
q12	794	617	608	608
q13	10237	3149	3113	3113
q14	320	287	275	275
q15	539	478	478	478
q16	534	472	482	472
q17	1797	1492	1473	1473
q18	7787	7334	7388	7334
q19	1674	1626	1519	1519
q20	2073	1855	1843	1843
q21	5351	5302	5158	5158
q22	1124	1041	1020	1020
Total cold run time: 65315 ms
Total hot run time: 54965 ms

doris-robot · 2024-09-09T06:52:24Z

TPC-DS: Total hot run time: 192750 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 53b931d938b6fcb30e9039ee8bbda43873de73b7, data reload: false

query1	913	370	380	370
query2	6476	1994	1852	1852
query3	6649	202	222	202
query4	34498	23410	23125	23125
query5	4147	512	490	490
query6	245	164	168	164
query7	4588	295	306	295
query8	271	207	218	207
query9	8433	2484	2453	2453
query10	426	303	268	268
query11	17943	15109	15119	15109
query12	149	100	102	100
query13	1631	387	361	361
query14	10174	7578	7384	7384
query15	246	172	169	169
query16	7625	414	455	414
query17	1586	595	537	537
query18	1353	278	281	278
query19	231	152	143	143
query20	123	108	108	108
query21	206	106	102	102
query22	4253	4189	4135	4135
query23	34159	33555	33555	33555
query24	11085	2910	2844	2844
query25	635	405	410	405
query26	1060	159	157	157
query27	2328	280	285	280
query28	6992	2041	2038	2038
query29	700	408	407	407
query30	303	162	150	150
query31	990	731	772	731
query32	94	60	55	55
query33	751	291	287	287
query34	1019	466	487	466
query35	866	734	714	714
query36	1088	908	965	908
query37	161	86	84	84
query38	3971	3879	3952	3879
query39	1444	1386	1420	1386
query40	200	115	113	113
query41	47	47	44	44
query42	114	94	98	94
query43	507	457	455	455
query44	1208	763	738	738
query45	195	167	169	167
query46	1127	751	743	743
query47	1885	1794	1821	1794
query48	364	292	298	292
query49	1096	438	434	434
query50	825	404	422	404
query51	7009	6971	6911	6911
query52	100	87	88	87
query53	254	182	182	182
query54	990	464	456	456
query55	74	74	76	74
query56	284	258	279	258
query57	1188	1071	1092	1071
query58	239	225	225	225
query59	2995	2694	2783	2694
query60	299	264	263	263
query61	102	99	100	99
query62	870	660	651	651
query63	232	193	188	188
query64	4551	668	709	668
query65	3278	3179	3158	3158
query66	1289	345	341	341
query67	15915	15357	15315	15315
query68	3113	866	848	848
query69	439	315	320	315
query70	1185	1177	1120	1120
query71	346	337	341	337
query72	6156	3560	3510	3510
query73	606	589	589	589
query74	9027	8856	8913	8856
query75	3182	3039	2998	2998
query76	1876	855	856	855
query77	506	405	396	396
query78	9407	9192	9231	9192
query79	897	877	884	877
query80	817	826	815	815
query81	448	263	262	262
query82	262	263	269	263
query83	191	197	196	196
query84	235	106	104	104
query85	701	425	378	378
query86	336	330	301	301
query87	4297	4236	4435	4236
query88	4384	4145	4141	4141
query89	378	364	367	364
query90	1510	320	319	319
query91	123	125	122	122
query92	80	73	78	73
query93	928	933	921	921
query94	589	356	363	356
query95	425	415	417	415
query96	475	476	478	476
query97	3077	3080	3091	3080
query98	232	233	224	224
query99	1438	1280	1284	1280
Total cold run time: 284715 ms
Total hot run time: 192750 ms

doris-robot · 2024-09-09T06:57:53Z

ClickBench: Total hot run time: 31.35 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 53b931d938b6fcb30e9039ee8bbda43873de73b7, data reload: false

query1	0.04	0.04	0.04
query2	0.08	0.04	0.04
query3	0.23	0.06	0.05
query4	1.65	0.09	0.08
query5	0.51	0.48	0.50
query6	1.13	0.73	0.73
query7	0.02	0.02	0.01
query8	0.05	0.04	0.05
query9	0.53	0.49	0.48
query10	0.54	0.55	0.53
query11	0.17	0.11	0.11
query12	0.16	0.13	0.13
query13	0.60	0.59	0.59
query14	1.37	1.46	1.41
query15	0.82	0.83	0.83
query16	0.36	0.36	0.38
query17	1.02	1.04	1.03
query18	0.21	0.21	0.20
query19	1.91	1.71	1.84
query20	0.01	0.01	0.01
query21	15.40	0.68	0.67
query22	4.81	6.44	1.87
query23	18.26	1.30	1.25
query24	2.10	0.23	0.22
query25	0.15	0.08	0.08
query26	0.28	0.19	0.18
query27	0.08	0.08	0.07
query28	13.26	1.03	1.00
query29	12.62	3.40	3.37
query30	0.25	0.06	0.05
query31	2.86	0.40	0.39
query32	3.26	0.48	0.47
query33	3.00	3.02	2.99
query34	17.03	4.41	4.36
query35	4.52	4.44	4.44
query36	0.66	0.48	0.50
query37	0.19	0.16	0.15
query38	0.16	0.14	0.14
query39	0.05	0.04	0.04
query40	0.17	0.13	0.13
query41	0.10	0.05	0.05
query42	0.06	0.05	0.05
query43	0.04	0.05	0.04
Total cold run time: 110.72 s
Total hot run time: 31.35 s

wangbo · 2024-09-09T09:56:17Z

run buildall

doris-robot · 2024-09-09T10:17:03Z

TPC-H: Total hot run time: 38153 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 38c398ec3c2c900714a0b57afc8d8c3f9efc0aa6, data reload: false

------ Round 1 ----------------------------------
q1	17623	4432	4322	4322
q2	2022	186	197	186
q3	10455	1192	1054	1054
q4	10131	755	682	682
q5	7729	2813	2792	2792
q6	224	139	136	136
q7	970	610	602	602
q8	9341	2117	2041	2041
q9	7162	6517	6535	6517
q10	6998	2164	2154	2154
q11	486	262	253	253
q12	408	228	225	225
q13	17771	3071	3076	3071
q14	279	230	243	230
q15	538	504	474	474
q16	518	440	430	430
q17	987	728	734	728
q18	7528	6981	6831	6831
q19	1385	1012	1033	1012
q20	693	339	323	323
q21	4345	3073	3099	3073
q22	1150	1072	1017	1017
Total cold run time: 108743 ms
Total hot run time: 38153 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4415	4297	4269	4269
q2	380	274	274	274
q3	2912	2685	2711	2685
q4	1949	1673	1661	1661
q5	5426	5394	5439	5394
q6	227	130	132	130
q7	2134	1745	1749	1745
q8	3202	3350	3326	3326
q9	8468	8448	8469	8448
q10	3484	3249	3205	3205
q11	594	488	508	488
q12	799	628	616	616
q13	16332	3101	3098	3098
q14	304	275	285	275
q15	514	486	480	480
q16	532	486	468	468
q17	1786	1481	1477	1477
q18	7728	7487	7507	7487
q19	1647	1449	1528	1449
q20	2079	1841	1841	1841
q21	5426	5185	5442	5185
q22	1124	1054	1026	1026
Total cold run time: 71462 ms
Total hot run time: 55027 ms

doris-robot · 2024-09-09T10:28:44Z

TPC-DS: Total hot run time: 188214 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 38c398ec3c2c900714a0b57afc8d8c3f9efc0aa6, data reload: false

query1	902	374	377	374
query2	6449	1921	1904	1904
query3	6644	208	244	208
query4	33226	23120	23106	23106
query5	4171	514	489	489
query6	259	166	159	159
query7	4593	294	294	294
query8	282	220	222	220
query9	8488	2485	2489	2485
query10	427	281	256	256
query11	17780	15049	15143	15049
query12	149	102	99	99
query13	1639	380	355	355
query14	9688	7722	7170	7170
query15	259	164	170	164
query16	7486	462	474	462
query17	1618	588	571	571
query18	1445	305	306	305
query19	255	144	142	142
query20	118	114	111	111
query21	217	103	103	103
query22	4411	4138	4284	4138
query23	34299	33764	33709	33709
query24	11175	2831	2912	2831
query25	618	404	398	398
query26	1143	150	151	150
query27	2586	272	269	269
query28	7257	2043	2019	2019
query29	730	399	394	394
query30	276	159	155	155
query31	965	759	776	759
query32	102	55	54	54
query33	751	309	299	299
query34	963	467	476	467
query35	854	719	695	695
query36	1074	934	957	934
query37	154	91	85	85
query38	3914	3812	3873	3812
query39	1428	1406	1387	1387
query40	202	119	114	114
query41	48	47	46	46
query42	121	99	96	96
query43	502	469	466	466
query44	1182	752	732	732
query45	197	165	167	165
query46	1103	735	736	735
query47	1885	1782	1852	1782
query48	374	294	289	289
query49	1105	438	432	432
query50	805	407	410	407
query51	7013	7050	6880	6880
query52	98	88	88	88
query53	247	185	191	185
query54	884	451	458	451
query55	76	72	74	72
query56	286	252	263	252
query57	1193	1068	1096	1068
query58	222	254	241	241
query59	2984	2771	2713	2713
query60	285	269	263	263
query61	105	100	102	100
query62	822	654	670	654
query63	216	187	185	185
query64	4531	782	628	628
query65	3236	3191	3190	3190
query66	1327	340	345	340
query67	15725	15868	15398	15398
query68	3386	599	576	576
query69	405	278	268	268
query70	1185	1081	1051	1051
query71	334	279	272	272
query72	6371	4036	3949	3949
query73	747	318	327	318
query74	9027	8771	8878	8771
query75	3349	2698	2641	2641
query76	1871	1012	941	941
query77	492	324	302	302
query78	10965	9353	9868	9353
query79	1077	529	536	529
query80	771	514	509	509
query81	560	227	228	227
query82	960	134	144	134
query83	242	155	153	153
query84	233	76	77	76
query85	704	313	292	292
query86	307	299	287	287
query87	4354	4279	4235	4235
query88	2835	2291	2297	2291
query89	381	284	284	284
query90	1938	182	188	182
query91	126	97	99	97
query92	60	49	51	49
query93	1045	542	540	540
query94	523	295	280	280
query95	344	252	254	252
query96	586	259	267	259
query97	3187	3109	3052	3052
query98	226	207	197	197
query99	1587	1303	1294	1294
Total cold run time: 285747 ms
Total hot run time: 188214 ms

doris-robot · 2024-09-09T10:34:15Z

ClickBench: Total hot run time: 32.08 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 38c398ec3c2c900714a0b57afc8d8c3f9efc0aa6, data reload: false

query1	0.05	0.04	0.04
query2	0.08	0.04	0.04
query3	0.23	0.04	0.05
query4	1.67	0.08	0.08
query5	0.52	0.50	0.52
query6	1.12	0.74	0.73
query7	0.02	0.01	0.02
query8	0.05	0.04	0.04
query9	0.54	0.50	0.49
query10	0.55	0.56	0.55
query11	0.16	0.12	0.12
query12	0.16	0.13	0.12
query13	0.60	0.59	0.58
query14	1.40	1.42	1.40
query15	0.83	0.83	0.81
query16	0.38	0.38	0.38
query17	1.05	1.03	1.02
query18	0.21	0.20	0.19
query19	1.81	1.71	1.87
query20	0.01	0.02	0.01
query21	15.39	0.67	0.67
query22	3.99	6.66	2.65
query23	18.29	1.36	1.24
query24	2.16	0.22	0.21
query25	0.15	0.08	0.09
query26	0.26	0.17	0.18
query27	0.07	0.08	0.07
query28	13.22	1.00	0.99
query29	12.63	3.34	3.31
query30	0.24	0.06	0.05
query31	2.90	0.39	0.40
query32	3.26	0.48	0.48
query33	3.00	3.03	3.04
query34	17.04	4.35	4.39
query35	4.50	4.44	4.46
query36	0.66	0.48	0.49
query37	0.20	0.16	0.16
query38	0.15	0.14	0.14
query39	0.05	0.04	0.04
query40	0.16	0.13	0.13
query41	0.10	0.05	0.05
query42	0.05	0.06	0.05
query43	0.04	0.04	0.04
Total cold run time: 109.95 s
Total hot run time: 32.08 s

yiguolei

LGTM

github-actions · 2024-09-10T02:32:40Z

PR approved by at least one committer and no changes requested.

github-actions · 2024-09-10T02:32:42Z

PR approved by anyone and no changes requested.

xinyiZzz

LGTM

## Proposed changes Fix strange core stack when BE not start correctly, and FE send publish topic request.

pick #40468 #40535 #40763 #40855

wangbo changed the title ~~only publish topic to alive be~~ [Fix]only publish topic to alive be Sep 9, 2024

only publish topic to alive be

38c398e

wangbo force-pushed the 0909_publish_when_be_alive branch from 53b931d to 38c398e Compare September 9, 2024 06:35

yiguolei added dev/2.1.x dev/3.0.x labels Sep 10, 2024

yiguolei approved these changes Sep 10, 2024

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 10, 2024

github-actions bot added the reviewed label Sep 10, 2024

xinyiZzz approved these changes Sep 10, 2024

View reviewed changes

wangbo merged commit 194b852 into apache:master Sep 10, 2024

wangbo added a commit to wangbo/incubator-doris that referenced this pull request Sep 12, 2024

[Fix]only publish topic to alive be (apache#40535)

08c0cba

## Proposed changes Fix strange core stack when BE not start correctly, and FE send publish topic request.

wangbo mentioned this pull request Sep 12, 2024

[Pick]only publish topic to alive be (#40535) #40759

Closed

dataroaring pushed a commit that referenced this pull request Oct 9, 2024

[Fix]only publish topic to alive be (#40535)

9ca28b8

## Proposed changes Fix strange core stack when BE not start correctly, and FE send publish topic request.

dataroaring added dev/3.0.3-merged and removed dev/3.0.x labels Oct 13, 2024

wangbo added a commit to wangbo/incubator-doris that referenced this pull request Nov 25, 2024

[Fix]only publish topic to alive be (apache#40535)

1e7b2e6

## Proposed changes Fix strange core stack when BE not start correctly, and FE send publish topic request.

wangbo mentioned this pull request Nov 25, 2024

[branch-2.1] pick some pr from master #44556

Merged

16 tasks

wangbo added a commit that referenced this pull request Nov 25, 2024

[branch-2.1] pick some pr from master (#44556)

5eb433e

pick #40468 #40535 #40763 #40855

wangbo added the dev/2.1.8-merged label Nov 26, 2024

[Fix]only publish topic to alive be #40535

[Fix]only publish topic to alive be #40535

Uh oh!

Conversation

wangbo commented Sep 9, 2024

Proposed changes

Uh oh!

doris-robot commented Sep 9, 2024

Uh oh!

wangbo commented Sep 9, 2024

Uh oh!

doris-robot commented Sep 9, 2024

Uh oh!

doris-robot commented Sep 9, 2024

Uh oh!

doris-robot commented Sep 9, 2024

Uh oh!

wangbo commented Sep 9, 2024

Uh oh!

doris-robot commented Sep 9, 2024

Uh oh!

doris-robot commented Sep 9, 2024

Uh oh!

doris-robot commented Sep 9, 2024

Uh oh!

yiguolei left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Sep 10, 2024

Uh oh!

github-actions bot commented Sep 10, 2024

Uh oh!

xinyiZzz left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants