Skip to content

Conversation

@wangbo
Copy link
Contributor

@wangbo wangbo commented Sep 14, 2024

Proposed changes

Fix thread num not reset 0 when fetch failed

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@wangbo
Copy link
Contributor Author

wangbo commented Sep 14, 2024

run buildall

Copy link
Contributor

@kaka11chen kaka11chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Sep 14, 2024
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.92% (9474/25663)
Line Coverage: 28.28% (77908/275490)
Region Coverage: 27.68% (40229/145319)
Branch Coverage: 24.29% (20438/84152)
Coverage Report: http://coverage.selectdb-in.cc/coverage/52afa38ffc2c16a394397f43bdab47133a27062e_52afa38ffc2c16a394397f43bdab47133a27062e/report/index.html

Copy link
Contributor

@xinyiZzz xinyiZzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doris-robot
Copy link

TPC-H: Total hot run time: 42835 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 52afa38ffc2c16a394397f43bdab47133a27062e, data reload: false

------ Round 1 ----------------------------------
q1	17557	7241	7207	7207
q2	2044	189	180	180
q3	10480	1275	1386	1275
q4	10332	1030	1052	1030
q5	7715	3135	3125	3125
q6	239	154	150	150
q7	1035	638	620	620
q8	9475	1969	2017	1969
q9	6797	6300	6311	6300
q10	7019	2528	2513	2513
q11	431	259	251	251
q12	411	232	230	230
q13	17763	3006	3051	3006
q14	283	250	253	250
q15	598	532	521	521
q16	527	433	435	433
q17	978	940	926	926
q18	7384	6801	6934	6801
q19	1387	1236	1234	1234
q20	606	329	319	319
q21	3925	3492	3494	3492
q22	1053	1003	1014	1003
Total cold run time: 108039 ms
Total hot run time: 42835 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7145	7103	7132	7103
q2	338	238	235	235
q3	3099	3092	3039	3039
q4	2109	2103	2071	2071
q5	5679	5577	5665	5577
q6	240	148	154	148
q7	2131	1744	1781	1744
q8	3394	3432	3433	3432
q9	8768	8942	8783	8783
q10	3530	3544	3568	3544
q11	585	481	476	476
q12	829	615	638	615
q13	10530	3228	3192	3192
q14	335	274	289	274
q15	581	536	530	530
q16	507	478	474	474
q17	1776	1739	1756	1739
q18	8465	7897	7984	7897
q19	1763	1738	1747	1738
q20	2146	1879	1869	1869
q21	5838	5598	5661	5598
q22	1145	1067	1041	1041
Total cold run time: 70933 ms
Total hot run time: 61119 ms

@doris-robot
Copy link

TPC-H: Total hot run time: 41176 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 52afa38ffc2c16a394397f43bdab47133a27062e, data reload: false

------ Round 1 ----------------------------------
q1	18137	7508	7308	7308
q2	2451	162	156	156
q3	12518	1127	1153	1127
q4	10590	703	743	703
q5	7775	3101	3130	3101
q6	235	149	150	149
q7	1019	653	601	601
q8	9482	1989	2033	1989
q9	6854	6398	6379	6379
q10	6987	2252	2299	2252
q11	439	240	242	240
q12	399	214	213	213
q13	17778	2961	2990	2961
q14	234	209	217	209
q15	583	527	531	527
q16	675	634	611	611
q17	955	764	752	752
q18	7166	6601	6757	6601
q19	1406	910	1101	910
q20	575	288	279	279
q21	3929	3126	3285	3126
q22	1088	997	982	982
Total cold run time: 111275 ms
Total hot run time: 41176 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7189	7174	7213	7174
q2	336	231	226	226
q3	2876	2768	2796	2768
q4	1929	1726	1660	1660
q5	5333	5375	5379	5375
q6	221	140	137	137
q7	2040	1699	1690	1690
q8	3173	3292	3289	3289
q9	8333	8349	8327	8327
q10	3351	3321	3323	3321
q11	579	480	474	474
q12	776	593	567	567
q13	5778	2991	2957	2957
q14	285	273	254	254
q15	562	518	514	514
q16	703	666	645	645
q17	1740	1558	1529	1529
q18	7644	7399	7244	7244
q19	1670	1587	1644	1587
q20	2029	1788	1832	1788
q21	5405	5069	5244	5069
q22	1132	1049	1015	1015
Total cold run time: 63084 ms
Total hot run time: 57610 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 194191 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 52afa38ffc2c16a394397f43bdab47133a27062e, data reload: false

query1	976	371	392	371
query2	6520	2110	2041	2041
query3	6705	212	233	212
query4	34171	23267	23345	23267
query5	4314	478	446	446
query6	257	167	165	165
query7	4612	288	296	288
query8	276	213	215	213
query9	9647	2649	2603	2603
query10	442	278	275	275
query11	18181	15087	15126	15087
query12	152	95	95	95
query13	1626	406	399	399
query14	10430	7612	7343	7343
query15	267	168	180	168
query16	7677	470	459	459
query17	1680	580	560	560
query18	2052	303	295	295
query19	362	150	149	149
query20	117	108	108	108
query21	219	106	105	105
query22	4463	4431	4259	4259
query23	34355	33841	33894	33841
query24	11250	2880	2909	2880
query25	629	401	408	401
query26	1335	168	160	160
query27	2686	287	288	287
query28	8204	2426	2401	2401
query29	867	421	425	421
query30	314	155	152	152
query31	1005	783	809	783
query32	100	56	63	56
query33	772	314	297	297
query34	922	480	503	480
query35	889	760	715	715
query36	1088	932	940	932
query37	150	93	91	91
query38	3967	3855	3929	3855
query39	1449	1399	1399	1399
query40	243	98	96	96
query41	50	52	49	49
query42	124	99	99	99
query43	515	501	487	487
query44	1264	818	805	805
query45	197	162	164	162
query46	1130	751	728	728
query47	1925	1805	1846	1805
query48	456	361	360	360
query49	1152	415	413	413
query50	811	400	411	400
query51	7199	7005	6904	6904
query52	104	94	94	94
query53	255	184	186	184
query54	1238	472	481	472
query55	80	80	77	77
query56	291	261	275	261
query57	1220	1110	1096	1096
query58	251	231	233	231
query59	3269	3040	3132	3040
query60	315	281	282	281
query61	123	224	106	106
query62	840	642	649	642
query63	210	182	184	182
query64	5327	637	642	637
query65	3309	3154	3182	3154
query66	1421	310	325	310
query67	15922	15662	15406	15406
query68	3334	865	839	839
query69	460	332	347	332
query70	1162	1167	1175	1167
query71	332	336	324	324
query72	6108	3380	3302	3302
query73	584	576	584	576
query74	9685	8946	8917	8917
query75	3006	2853	2862	2853
query76	1961	865	870	865
query77	404	344	354	344
query78	9520	9328	9328	9328
query79	909	880	855	855
query80	596	589	614	589
query81	446	246	260	246
query82	227	228	231	228
query83	163	155	154	154
query84	245	98	102	98
query85	689	362	367	362
query86	313	286	325	286
query87	4380	4378	4298	4298
query88	4904	4038	4072	4038
query89	362	356	366	356
query90	1460	311	317	311
query91	166	163	167	163
query92	76	71	71	71
query93	895	903	877	877
query94	576	388	378	378
query95	422	409	408	408
query96	491	488	483	483
query97	3139	3127	3100	3100
query98	223	228	219	219
query99	1385	1315	1284	1284
Total cold run time: 292992 ms
Total hot run time: 194191 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.02 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 52afa38ffc2c16a394397f43bdab47133a27062e, data reload: false

query1	0.04	0.05	0.04
query2	0.06	0.03	0.03
query3	0.24	0.06	0.06
query4	1.66	0.11	0.10
query5	0.52	0.49	0.49
query6	1.15	0.72	0.73
query7	0.02	0.01	0.02
query8	0.04	0.03	0.03
query9	0.55	0.49	0.48
query10	0.55	0.56	0.54
query11	0.14	0.10	0.10
query12	0.12	0.10	0.10
query13	0.60	0.59	0.59
query14	2.97	3.00	2.99
query15	0.86	0.82	0.83
query16	0.39	0.38	0.37
query17	1.05	1.00	1.07
query18	0.22	0.20	0.21
query19	1.94	1.84	2.00
query20	0.01	0.02	0.01
query21	15.35	0.60	0.58
query22	2.35	2.88	1.42
query23	17.32	0.86	0.78
query24	3.22	0.75	0.99
query25	0.12	0.11	0.09
query26	0.48	0.14	0.13
query27	0.04	0.04	0.04
query28	10.71	1.09	1.06
query29	12.55	3.26	3.27
query30	0.24	0.06	0.06
query31	2.87	0.38	0.38
query32	3.28	0.47	0.47
query33	2.99	2.96	3.01
query34	16.91	4.36	4.41
query35	4.45	4.38	4.44
query36	0.67	0.49	0.50
query37	0.08	0.06	0.06
query38	0.05	0.03	0.04
query39	0.03	0.02	0.02
query40	0.15	0.13	0.12
query41	0.07	0.02	0.02
query42	0.04	0.02	0.02
query43	0.03	0.03	0.02
Total cold run time: 107.13 s
Total hot run time: 32.02 s

@wangbo wangbo merged commit 810ccda into apache:master Sep 18, 2024
wangbo added a commit to wangbo/incubator-doris that referenced this pull request Nov 25, 2024
@wangbo wangbo mentioned this pull request Nov 25, 2024
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.3-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants