Skip to content

[branch-2.1] pick some pr from master #44556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wangbo merged 4 commits into from
Nov 25, 2024
Merged

[branch-2.1] pick some pr from master #44556

wangbo merged 4 commits into from
Nov 25, 2024

Conversation

@wangbo
Copy link
Contributor

@wangbo wangbo commented Nov 25, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:
pick #40468 #40535 #40763 #40855

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@wangbo
[Improvement]Add more tip when drop workload group failed (apache#40468)
9e9c197 
## Proposed changes
Add more tip to tell user what to do when drop wg failed.
@wangbo
[Fix]only publish topic to alive be (apache#40535)
1e7b2e6 
## Proposed changes
Fix strange core stack when BE not start correctly, and FE send publish
topic request.
@wangbo
[Fix]Fix publish may wait timeout because of dead BE (apache#40763)
52ff294 
```AckResponseHandler``` should only accept alive BE, otherwise pubslih may wait timeout if dead Be exists.
@wangbo
[Fix]Fix thread num not reset 0 when fetch failed (apache#40855)
adcdb0a
@doris-robot
Copy link

doris-robot commented Nov 25, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@wangbo
Copy link
Contributor Author

wangbo commented Nov 25, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Nov 25, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Nov 25, 2024

TeamCity be ut coverage result:
Function Coverage: 36.73% (9604/26145)
Line Coverage: 28.13% (78975/280772)
Region Coverage: 26.82% (40599/151391)
Branch Coverage: 23.64% (20653/87376)
Coverage Report: http://coverage.selectdb-in.cc/coverage/adcdb0a272fe096f39d70ec3577d2843e3952090_adcdb0a272fe096f39d70ec3577d2843e3952090/report/index.html

@wangbo wangbo merged commit 5eb433e into apache:branch-2.1 Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wangbo @doris-robot