Skip to content

Conversation

@morrySnow
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #41607 #45648

Problem Summary:

org.apache.doris.qe.GlobalVariable#getPersistentGlobalVarNames should use bit and to check whether variable is Global

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morrySnow
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32742 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6faacf448d0d169f311d056baee73cbc56d00717, data reload: false

------ Round 1 ----------------------------------
q1	17595	6176	6323	6176
q2	2044	311	175	175
q3	10395	1259	717	717
q4	10212	858	430	430
q5	7523	2206	1963	1963
q6	203	176	146	146
q7	890	739	602	602
q8	9249	1362	1151	1151
q9	5104	4875	4908	4875
q10	6754	2304	1886	1886
q11	474	278	246	246
q12	343	356	223	223
q13	17765	3686	3090	3090
q14	238	237	211	211
q15	567	511	499	499
q16	640	617	578	578
q17	559	850	327	327
q18	7093	6493	6398	6398
q19	1232	988	573	573
q20	309	321	188	188
q21	2834	2167	1979	1979
q22	368	335	309	309
Total cold run time: 102391 ms
Total hot run time: 32742 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6320	6293	6244	6244
q2	238	327	236	236
q3	2248	2689	2347	2347
q4	1397	1844	1352	1352
q5	4384	4766	4795	4766
q6	197	182	143	143
q7	2194	1979	1839	1839
q8	2588	2772	2684	2684
q9	7240	7175	7173	7173
q10	3122	3342	2863	2863
q11	593	514	515	514
q12	696	748	635	635
q13	3456	3872	3232	3232
q14	298	304	297	297
q15	559	509	496	496
q16	650	691	641	641
q17	1237	1722	1243	1243
q18	7734	7386	7296	7296
q19	809	1149	1081	1081
q20	1892	1954	1815	1815
q21	5463	5123	4914	4914
q22	626	635	575	575
Total cold run time: 53941 ms
Total hot run time: 52386 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 191272 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6faacf448d0d169f311d056baee73cbc56d00717, data reload: false

query1	977	373	373	373
query2	6518	2306	2287	2287
query3	6704	219	205	205
query4	36955	23710	23819	23710
query5	4106	620	463	463
query6	269	205	186	186
query7	4616	490	310	310
query8	301	232	239	232
query9	9367	2649	2640	2640
query10	445	307	248	248
query11	16783	15778	15226	15226
query12	157	113	107	107
query13	1667	540	405	405
query14	10030	7703	7993	7703
query15	261	194	212	194
query16	8708	615	470	470
query17	1662	763	566	566
query18	2125	404	315	315
query19	224	184	164	164
query20	118	114	112	112
query21	205	124	104	104
query22	4436	4289	4323	4289
query23	34496	33431	33382	33382
query24	6434	2346	2304	2304
query25	489	466	384	384
query26	765	278	153	153
query27	2023	460	347	347
query28	5245	2431	2390	2390
query29	667	528	415	415
query30	227	184	160	160
query31	994	908	823	823
query32	112	66	56	56
query33	488	373	293	293
query34	747	843	532	532
query35	797	828	759	759
query36	1043	1110	968	968
query37	114	100	77	77
query38	4324	4115	4189	4115
query39	1521	1484	1440	1440
query40	205	110	99	99
query41	48	44	53	44
query42	117	105	103	103
query43	498	527	480	480
query44	1325	802	794	794
query45	178	176	170	170
query46	844	1038	645	645
query47	1899	1925	1904	1904
query48	373	398	317	317
query49	745	474	380	380
query50	623	628	385	385
query51	7312	7178	7103	7103
query52	103	105	98	98
query53	222	255	183	183
query54	470	494	387	387
query55	76	76	75	75
query56	253	254	229	229
query57	1217	1156	1116	1116
query58	242	230	230	230
query59	3014	3038	3034	3034
query60	277	256	248	248
query61	113	107	107	107
query62	837	831	734	734
query63	230	191	190	190
query64	3448	1014	640	640
query65	3314	3177	3209	3177
query66	797	419	316	316
query67	16183	15826	15524	15524
query68	8721	683	511	511
query69	477	290	256	256
query70	1223	1172	1100	1100
query71	435	297	262	262
query72	6252	3793	3821	3793
query73	666	737	345	345
query74	9833	8833	9171	8833
query75	4543	3135	2681	2681
query76	4493	1134	760	760
query77	788	367	274	274
query78	10237	10025	9427	9427
query79	5321	757	579	579
query80	706	525	432	432
query81	479	279	245	245
query82	391	157	125	125
query83	191	167	142	142
query84	278	89	71	71
query85	778	351	383	351
query86	365	290	314	290
query87	4363	4593	4539	4539
query88	3710	2180	2155	2155
query89	435	328	295	295
query90	1995	189	187	187
query91	133	134	104	104
query92	61	67	51	51
query93	2997	820	523	523
query94	667	409	292	292
query95	335	268	248	248
query96	483	611	281	281
query97	2903	2973	2875	2875
query98	219	210	194	194
query99	1633	1573	1432	1432
Total cold run time: 298194 ms
Total hot run time: 191272 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.08 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 6faacf448d0d169f311d056baee73cbc56d00717, data reload: false

query1	0.04	0.04	0.06
query2	0.08	0.03	0.03
query3	0.24	0.07	0.07
query4	1.62	0.10	0.10
query5	0.41	0.43	0.42
query6	1.18	0.65	0.65
query7	0.03	0.01	0.02
query8	0.04	0.04	0.03
query9	0.58	0.50	0.51
query10	0.56	0.58	0.56
query11	0.14	0.10	0.10
query12	0.14	0.11	0.11
query13	0.61	0.62	0.60
query14	2.84	2.83	2.72
query15	0.89	0.83	0.82
query16	0.38	0.39	0.38
query17	1.02	1.02	1.06
query18	0.22	0.20	0.21
query19	1.84	1.79	1.95
query20	0.02	0.01	0.01
query21	15.36	0.89	0.57
query22	0.77	0.75	0.56
query23	15.38	1.40	0.60
query24	3.20	1.87	1.68
query25	0.19	0.25	0.10
query26	0.19	0.14	0.14
query27	0.07	0.05	0.04
query28	14.54	1.51	1.05
query29	12.58	3.95	3.25
query30	0.25	0.10	0.07
query31	2.80	0.58	0.37
query32	3.23	0.54	0.45
query33	3.07	3.17	3.21
query34	16.82	5.15	4.54
query35	4.49	4.57	4.53
query36	0.64	0.49	0.52
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.02	0.03
query40	0.17	0.14	0.13
query41	0.08	0.02	0.02
query42	0.04	0.02	0.03
query43	0.04	0.03	0.02
Total cold run time: 106.96 s
Total hot run time: 32.08 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 7, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2025

PR approved by anyone and no changes requested.

@morrySnow morrySnow merged commit 4f3b9bb into apache:master Jan 7, 2025
28 of 30 checks passed
@morrySnow morrySnow deleted the fix_variable_version_not_persist_in_image branch January 7, 2025 02:28
github-actions bot pushed a commit that referenced this pull request Jan 7, 2025
### What problem does this PR solve?

Related PR: #41607 #45648

Problem Summary:
org.apache.doris.qe.GlobalVariable#getPersistentGlobalVarNames should
use bit and to check whether variable is Global
github-actions bot pushed a commit that referenced this pull request Jan 7, 2025
### What problem does this PR solve?

Related PR: #41607 #45648

Problem Summary:
org.apache.doris.qe.GlobalVariable#getPersistentGlobalVarNames should
use bit and to check whether variable is Global
morrySnow added a commit that referenced this pull request Jan 7, 2025
 (#46499)

Cherry-picked from #46463

Co-authored-by: morrySnow <zhangwenxin@selectdb.com>
morrySnow added a commit that referenced this pull request Jan 8, 2025
 (#46497)

Cherry-picked from #46463

Co-authored-by: morrySnow <zhangwenxin@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.4-merged p0_b reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants