Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Jan 7, 2025

Cherry-picked from #46463

### What problem does this PR solve?

Related PR: #41607 #45648

Problem Summary:
org.apache.doris.qe.GlobalVariable#getPersistentGlobalVarNames should
use bit and to check whether variable is Global
@Thearas
Copy link
Contributor

Thearas commented Jan 7, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring closed this Jan 7, 2025
@dataroaring dataroaring reopened this Jan 7, 2025
@Thearas
Copy link
Contributor

Thearas commented Jan 7, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40741 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit edc052d51304aae97aae3b5dbd15b2bef2995fee, data reload: false

------ Round 1 ----------------------------------
q1	17615	7306	7397	7306
q2	2045	177	164	164
q3	10568	1068	1207	1068
q4	10558	703	730	703
q5	7723	2819	2816	2816
q6	235	149	142	142
q7	979	613	588	588
q8	9371	1955	1995	1955
q9	6578	6377	6425	6377
q10	6997	2289	2316	2289
q11	464	258	262	258
q12	397	215	205	205
q13	17804	3019	2968	2968
q14	232	204	206	204
q15	566	520	532	520
q16	678	601	585	585
q17	971	572	556	556
q18	7229	6708	6797	6708
q19	1397	1085	1016	1016
q20	471	213	197	197
q21	4036	3119	3210	3119
q22	1088	1005	997	997
Total cold run time: 108002 ms
Total hot run time: 40741 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7213	7227	7199	7199
q2	331	235	226	226
q3	2887	2890	2888	2888
q4	2026	1797	1773	1773
q5	5696	5663	5707	5663
q6	228	140	141	140
q7	2246	1870	1835	1835
q8	3334	3549	3508	3508
q9	8714	8851	8829	8829
q10	3564	3482	3545	3482
q11	592	506	495	495
q12	789	581	603	581
q13	9296	3199	3161	3161
q14	301	265	279	265
q15	569	545	520	520
q16	689	685	677	677
q17	1827	1641	1580	1580
q18	8220	7733	7529	7529
q19	1653	1606	1602	1602
q20	2079	1856	1826	1826
q21	5609	5276	5505	5276
q22	1144	1052	1022	1022
Total cold run time: 69007 ms
Total hot run time: 60077 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 196860 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit edc052d51304aae97aae3b5dbd15b2bef2995fee, data reload: false

query1	1311	916	928	916
query2	6221	2052	2021	2021
query3	10921	4293	4175	4175
query4	66053	28522	23299	23299
query5	5027	448	435	435
query6	411	181	169	169
query7	5487	305	308	305
query8	332	229	227	227
query9	8737	2715	2688	2688
query10	435	262	263	262
query11	17024	15101	15834	15101
query12	161	105	106	105
query13	1416	455	442	442
query14	9740	6717	6944	6717
query15	198	177	186	177
query16	6926	483	469	469
query17	1096	584	596	584
query18	1318	335	335	335
query19	234	158	165	158
query20	120	109	118	109
query21	207	104	105	104
query22	4985	4726	4659	4659
query23	34626	34182	34515	34182
query24	6915	2926	2896	2896
query25	560	422	426	422
query26	662	173	168	168
query27	2268	355	375	355
query28	4528	2500	2497	2497
query29	724	464	462	462
query30	240	157	165	157
query31	1001	831	839	831
query32	63	59	56	56
query33	405	287	279	279
query34	931	521	511	511
query35	870	727	732	727
query36	1130	961	961	961
query37	119	72	87	72
query38	4196	4003	4012	4003
query39	1569	1478	1459	1459
query40	218	99	100	99
query41	48	47	48	47
query42	116	96	100	96
query43	519	495	499	495
query44	1167	827	828	827
query45	183	169	172	169
query46	1141	731	733	731
query47	2024	1930	1923	1923
query48	475	391	390	390
query49	712	399	374	374
query50	822	430	429	429
query51	7414	7226	7207	7207
query52	109	86	89	86
query53	257	181	190	181
query54	562	446	438	438
query55	75	79	77	77
query56	258	255	254	254
query57	1210	1115	1092	1092
query58	220	211	208	208
query59	3280	3130	2872	2872
query60	280	253	263	253
query61	111	108	120	108
query62	770	648	649	648
query63	216	186	184	184
query64	1372	666	641	641
query65	3259	3174	3184	3174
query66	711	306	305	305
query67	15958	15638	15657	15638
query68	4010	577	572	572
query69	426	266	262	262
query70	1157	1133	1119	1119
query71	352	283	259	259
query72	6379	4060	3964	3964
query73	753	353	347	347
query74	10145	8939	8973	8939
query75	3340	2649	2626	2626
query76	1917	1063	1067	1063
query77	503	270	263	263
query78	10548	9686	9597	9597
query79	1434	593	593	593
query80	899	426	433	426
query81	531	239	235	235
query82	1266	114	119	114
query83	240	145	149	145
query84	293	84	75	75
query85	900	298	302	298
query86	352	292	302	292
query87	4395	4321	4179	4179
query88	3762	2416	2375	2375
query89	417	284	286	284
query90	2005	179	183	179
query91	178	150	147	147
query92	68	55	52	52
query93	1905	542	544	542
query94	777	290	274	274
query95	340	254	254	254
query96	628	289	283	283
query97	3363	3199	3198	3198
query98	220	198	200	198
query99	1605	1312	1265	1265
Total cold run time: 317762 ms
Total hot run time: 196860 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.26 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit edc052d51304aae97aae3b5dbd15b2bef2995fee, data reload: false

query1	0.03	0.03	0.04
query2	0.07	0.02	0.03
query3	0.22	0.07	0.07
query4	1.63	0.10	0.10
query5	0.52	0.50	0.49
query6	1.15	0.72	0.73
query7	0.03	0.02	0.02
query8	0.04	0.03	0.03
query9	0.56	0.51	0.49
query10	0.55	0.54	0.55
query11	0.14	0.10	0.10
query12	0.14	0.11	0.10
query13	0.60	0.59	0.58
query14	2.91	3.00	3.03
query15	0.90	0.83	0.82
query16	0.39	0.38	0.39
query17	1.03	1.06	1.04
query18	0.22	0.21	0.21
query19	1.88	1.78	2.09
query20	0.02	0.00	0.01
query21	15.36	0.60	0.59
query22	3.11	2.73	1.03
query23	17.00	0.92	0.86
query24	3.50	0.96	1.20
query25	0.24	0.16	0.12
query26	0.54	0.14	0.13
query27	0.04	0.05	0.04
query28	10.42	1.11	1.07
query29	12.56	3.30	3.29
query30	0.25	0.06	0.06
query31	2.85	0.40	0.38
query32	3.25	0.46	0.47
query33	2.97	3.00	3.01
query34	17.17	4.47	4.55
query35	4.53	4.54	4.49
query36	0.68	0.48	0.52
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.02	0.02
query40	0.15	0.12	0.14
query41	0.08	0.03	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 107.98 s
Total hot run time: 32.26 s

@morrySnow morrySnow merged commit 6e0afa4 into branch-3.0 Jan 8, 2025
22 checks passed
@github-actions github-actions bot deleted the auto-pick-46463-branch-3.0 branch January 8, 2025 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants