Skip to content

[improve](schema-change) support nested type with varchar type to support length growing #46639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eldenmoon merged 9 commits into from
Jan 15, 2025
Merged

[improve](schema-change) support nested type with varchar type to support length growing #46639

eldenmoon merged 9 commits into from
Jan 15, 2025

Conversation

@amorynan
Copy link
Contributor

@amorynan amorynan commented Jan 8, 2025

What problem does this PR solve?

The array|map|struct schema-change behavior supports moditfy to change the length of the varchar type in the current column type.
before

mysql> alter table t_sc MODIFY COLUMN s struct<col:varchar(20)>;
ERROR 1105 (HY000): errCode = 2, detailMessage = Can not change struct<col:varchar(10)> to `__doris_shadow_s` struct<col:varchar(20)> NULL

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Jan 8, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@amorynan
Copy link
Contributor Author

amorynan commented Jan 8, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Jan 8, 2025

TPC-H: Total hot run time: 32732 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e0114317ab12b807006efd68c448e369582820bb, data reload: false

------ Round 1 ----------------------------------
q1	17629	6170	6041	6041
q2	2059	303	172	172
q3	10430	1225	734	734
q4	10207	873	436	436
q5	7734	2205	1952	1952
q6	201	178	150	150
q7	891	759	624	624
q8	9253	1350	1145	1145
q9	5285	4902	4889	4889
q10	6821	2314	1872	1872
q11	466	280	252	252
q12	347	357	221	221
q13	17850	3780	3230	3230
q14	244	229	213	213
q15	571	514	522	514
q16	611	620	596	596
q17	587	866	338	338
q18	6950	6498	6366	6366
q19	2835	969	559	559
q20	299	308	188	188
q21	2872	2136	1932	1932
q22	364	341	308	308
Total cold run time: 104506 ms
Total hot run time: 32732 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6386	6224	6251	6224
q2	241	340	230	230
q3	2218	2633	2341	2341
q4	1400	1812	1369	1369
q5	4334	4720	4818	4720
q6	185	188	147	147
q7	2056	2012	1864	1864
q8	2607	2779	2707	2707
q9	7272	7247	7355	7247
q10	3080	3337	2834	2834
q11	567	514	489	489
q12	648	730	575	575
q13	3543	3883	3251	3251
q14	284	324	292	292
q15	575	506	509	506
q16	645	688	668	668
q17	1236	1727	1257	1257
q18	7538	7538	7281	7281
q19	832	1043	1144	1043
q20	2011	2061	1911	1911
q21	5723	5262	4937	4937
q22	648	615	602	602
Total cold run time: 54029 ms
Total hot run time: 52495 ms

@doris-robot
Copy link

doris-robot commented Jan 8, 2025

TPC-DS: Total hot run time: 195928 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e0114317ab12b807006efd68c448e369582820bb, data reload: false

query1	1299	937	886	886
query2	6349	2366	2362	2362
query3	11128	4837	4874	4837
query4	32656	23497	23838	23497
query5	5728	574	457	457
query6	285	203	195	195
query7	3998	499	308	308
query8	304	255	237	237
query9	9684	2744	2716	2716
query10	547	325	266	266
query11	18222	15168	15111	15111
query12	173	115	113	113
query13	1586	539	406	406
query14	9448	7300	7701	7300
query15	229	204	195	195
query16	7691	642	446	446
query17	1536	758	593	593
query18	1442	391	323	323
query19	211	187	162	162
query20	121	120	112	112
query21	212	123	106	106
query22	4628	4641	4401	4401
query23	34186	33093	33111	33093
query24	6359	2273	2295	2273
query25	535	444	390	390
query26	714	277	152	152
query27	2150	465	340	340
query28	4626	2490	2492	2490
query29	587	561	458	458
query30	221	198	153	153
query31	957	920	821	821
query32	80	61	58	58
query33	472	349	324	324
query34	771	891	538	538
query35	829	866	772	772
query36	1020	1059	964	964
query37	122	107	76	76
query38	4217	4125	4368	4125
query39	1499	1448	1489	1448
query40	218	117	105	105
query41	47	44	46	44
query42	119	111	104	104
query43	530	531	518	518
query44	1360	860	855	855
query45	187	183	178	178
query46	890	1068	672	672
query47	1919	1871	1836	1836
query48	399	460	344	344
query49	824	512	418	418
query50	652	715	406	406
query51	7059	7147	6967	6967
query52	105	102	93	93
query53	226	269	197	197
query54	495	501	419	419
query55	86	82	79	79
query56	259	274	242	242
query57	1183	1229	1135	1135
query58	241	236	225	225
query59	3159	3246	3167	3167
query60	288	267	272	267
query61	110	142	107	107
query62	825	807	726	726
query63	228	196	185	185
query64	2992	1020	669	669
query65	3313	3231	3237	3231
query66	692	404	326	326
query67	16128	15587	15374	15374
query68	8463	697	517	517
query69	516	296	251	251
query70	1215	1082	1097	1082
query71	469	290	257	257
query72	6215	3896	3896	3896
query73	644	764	361	361
query74	9758	8886	8928	8886
query75	3918	3155	2679	2679
query76	3615	1194	755	755
query77	678	362	267	267
query78	10144	9849	9407	9407
query79	3737	816	588	588
query80	737	527	444	444
query81	500	259	235	235
query82	621	155	125	125
query83	176	231	142	142
query84	245	87	70	70
query85	745	383	317	317
query86	353	318	300	300
query87	4601	4547	4343	4343
query88	5043	2212	2208	2208
query89	415	322	293	293
query90	1919	192	184	184
query91	141	137	108	108
query92	69	59	54	54
query93	2215	929	515	515
query94	624	410	298	298
query95	336	270	257	257
query96	502	616	281	281
query97	2928	2927	2736	2736
query98	231	203	202	202
query99	1581	1489	1477	1477
Total cold run time: 294710 ms
Total hot run time: 195928 ms

@doris-robot
Copy link

doris-robot commented Jan 8, 2025

ClickBench: Total hot run time: 31.5 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e0114317ab12b807006efd68c448e369582820bb, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.04	0.04
query3	0.23	0.07	0.07
query4	1.60	0.10	0.11
query5	0.40	0.43	0.42
query6	1.15	0.66	0.65
query7	0.02	0.01	0.01
query8	0.04	0.03	0.04
query9	0.60	0.51	0.49
query10	0.55	0.55	0.55
query11	0.15	0.10	0.10
query12	0.15	0.12	0.11
query13	0.61	0.61	0.60
query14	2.72	2.70	2.76
query15	0.91	0.82	0.82
query16	0.40	0.38	0.37
query17	1.08	1.05	1.06
query18	0.22	0.20	0.20
query19	1.90	1.83	1.98
query20	0.02	0.01	0.01
query21	15.34	0.95	0.56
query22	0.76	0.82	0.65
query23	15.29	1.48	0.52
query24	3.09	1.07	1.53
query25	0.16	0.25	0.14
query26	0.23	0.15	0.13
query27	0.05	0.05	0.07
query28	13.83	1.50	1.05
query29	12.57	3.96	3.31
query30	0.25	0.09	0.07
query31	2.83	0.58	0.39
query32	3.23	0.55	0.46
query33	3.08	3.14	3.12
query34	16.87	5.16	4.51
query35	4.56	4.50	4.63
query36	0.64	0.52	0.47
query37	0.09	0.06	0.06
query38	0.04	0.04	0.03
query39	0.03	0.03	0.02
query40	0.16	0.15	0.14
query41	0.09	0.02	0.02
query42	0.04	0.02	0.02
query43	0.04	0.04	0.03
Total cold run time: 106.12 s
Total hot run time: 31.5 s

eldenmoon
eldenmoon reviewed Jan 9, 2025
View reviewed changes
@amorynan amorynan changed the title [imprve](schema-change) support nested type with varchar type to support length growing [improve](schema-change) support nested type with varchar type to support length growing Jan 9, 2025
Hastyshell
Hastyshell reviewed Jan 9, 2025
View reviewed changes
Hastyshell
Hastyshell reviewed Jan 9, 2025
View reviewed changes
regression-test/suites/schema_change_p0/test_varchar_sc_in_complex.groovy
}


sql """ alter table ${tableName} modify column c_a array<varchar(20)> """
Copy link
Collaborator

@Hastyshell Hastyshell Jan 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz add a case as such like:

alter table ${tableName} modify column c_a array<varchar(20)> after c_s

cuz modify type+reorder will do link schema change rather than light schema change
we shall test this case additionaly

@amorynan
Copy link
Contributor Author

amorynan commented Jan 9, 2025

run buildall

eldenmoon
eldenmoon reviewed Jan 9, 2025
View reviewed changes
eldenmoon
eldenmoon reviewed Jan 9, 2025
View reviewed changes
@doris-robot
Copy link

doris-robot commented Jan 9, 2025

TPC-H: Total hot run time: 32793 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b69c3457d164bab98068f576b31d9e51074a8b58, data reload: false

------ Round 1 ----------------------------------
q1	17600	6167	6027	6027
q2	2053	314	168	168
q3	10418	1297	766	766
q4	10230	898	450	450
q5	7843	2218	1980	1980
q6	210	181	142	142
q7	899	759	600	600
q8	9240	1367	1180	1180
q9	5334	4993	5007	4993
q10	6769	2309	1866	1866
q11	478	283	258	258
q12	350	377	225	225
q13	17766	3687	3091	3091
q14	235	242	220	220
q15	578	514	501	501
q16	644	623	592	592
q17	568	867	323	323
q18	6995	6615	6396	6396
q19	2023	964	544	544
q20	309	316	183	183
q21	2962	2273	1980	1980
q22	368	340	308	308
Total cold run time: 103872 ms
Total hot run time: 32793 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6313	6190	6197	6190
q2	242	326	233	233
q3	2252	2697	2319	2319
q4	1417	1897	1353	1353
q5	4314	4733	4785	4733
q6	189	180	148	148
q7	2054	1985	1787	1787
q8	2645	2847	2717	2717
q9	7368	7395	7337	7337
q10	3097	3321	2705	2705
q11	589	508	518	508
q12	686	801	620	620
q13	3489	3851	3254	3254
q14	308	291	265	265
q15	563	520	500	500
q16	656	694	649	649
q17	1229	1745	1265	1265
q18	7879	7462	7495	7462
q19	792	1142	1073	1073
q20	1982	2052	2003	2003
q21	5643	5036	5140	5036
q22	634	633	596	596
Total cold run time: 54341 ms
Total hot run time: 52753 ms

@doris-robot
Copy link

doris-robot commented Jan 9, 2025

TPC-DS: Total hot run time: 195459 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b69c3457d164bab98068f576b31d9e51074a8b58, data reload: false

query1	1308	947	931	931
query2	6301	2347	2387	2347
query3	11136	4799	4940	4799
query4	32958	23590	23295	23295
query5	3595	614	468	468
query6	282	204	191	191
query7	3991	485	299	299
query8	297	230	220	220
query9	9486	2706	2715	2706
query10	470	311	248	248
query11	17929	15238	15031	15031
query12	158	111	107	107
query13	1558	559	419	419
query14	10713	6898	7176	6898
query15	257	212	184	184
query16	7902	616	456	456
query17	1554	788	586	586
query18	2054	419	330	330
query19	204	196	172	172
query20	130	152	115	115
query21	209	122	104	104
query22	4693	4598	4536	4536
query23	34250	33412	33466	33412
query24	6558	2336	2328	2328
query25	458	456	389	389
query26	724	287	153	153
query27	2060	479	343	343
query28	5387	2509	2497	2497
query29	561	573	437	437
query30	207	180	150	150
query31	962	880	814	814
query32	70	57	59	57
query33	504	350	291	291
query34	764	877	522	522
query35	806	838	748	748
query36	1036	1086	963	963
query37	120	99	76	76
query38	4220	4389	4063	4063
query39	1536	1495	1432	1432
query40	199	119	103	103
query41	53	47	47	47
query42	120	106	109	106
query43	520	541	503	503
query44	1355	845	842	842
query45	182	176	163	163
query46	883	1066	659	659
query47	1898	1861	1875	1861
query48	394	409	330	330
query49	725	500	389	389
query50	625	678	406	406
query51	7149	6959	7126	6959
query52	103	97	94	94
query53	229	255	198	198
query54	498	525	416	416
query55	84	77	83	77
query56	264	264	245	245
query57	1203	1213	1142	1142
query58	238	246	238	238
query59	3217	3286	3239	3239
query60	271	255	251	251
query61	110	109	111	109
query62	872	803	736	736
query63	237	188	184	184
query64	2781	1065	671	671
query65	3259	3302	3236	3236
query66	1064	401	327	327
query67	16412	15838	15452	15452
query68	8121	709	533	533
query69	468	294	256	256
query70	1191	1132	1100	1100
query71	435	276	250	250
query72	6470	3947	3886	3886
query73	672	751	365	365
query74	9876	9031	8885	8885
query75	4122	3136	2650	2650
query76	3555	1184	768	768
query77	746	369	287	287
query78	10263	10260	9332	9332
query79	3201	798	593	593
query80	673	544	428	428
query81	464	279	227	227
query82	618	156	126	126
query83	164	161	152	152
query84	241	95	75	75
query85	786	368	296	296
query86	349	311	290	290
query87	4280	4387	4452	4387
query88	4358	2187	2128	2128
query89	417	326	293	293
query90	1870	186	190	186
query91	138	175	106	106
query92	62	58	51	51
query93	1438	837	550	550
query94	648	383	297	297
query95	334	263	254	254
query96	488	609	281	281
query97	2900	2928	2780	2780
query98	220	207	200	200
query99	1539	1530	1347	1347
Total cold run time: 293460 ms
Total hot run time: 195459 ms

@doris-robot
Copy link

doris-robot commented Jan 9, 2025

ClickBench: Total hot run time: 32.3 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b69c3457d164bab98068f576b31d9e51074a8b58, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.24	0.07	0.07
query4	1.62	0.10	0.10
query5	0.42	0.42	0.40
query6	1.15	0.66	0.66
query7	0.02	0.01	0.02
query8	0.04	0.03	0.04
query9	0.59	0.51	0.50
query10	0.56	0.56	0.56
query11	0.14	0.10	0.11
query12	0.15	0.11	0.12
query13	0.62	0.60	0.61
query14	2.75	2.72	2.73
query15	0.89	0.83	0.83
query16	0.38	0.39	0.37
query17	1.08	1.05	1.08
query18	0.23	0.21	0.22
query19	1.93	1.79	2.06
query20	0.01	0.01	0.02
query21	15.37	0.97	0.56
query22	0.76	0.76	0.69
query23	15.26	1.40	0.52
query24	3.10	1.92	1.74
query25	0.14	0.34	0.13
query26	0.18	0.14	0.14
query27	0.05	0.05	0.04
query28	14.64	1.49	1.06
query29	12.58	4.04	3.36
query30	0.25	0.09	0.07
query31	2.82	0.59	0.38
query32	3.23	0.55	0.46
query33	3.08	3.07	3.24
query34	17.00	5.20	4.56
query35	4.56	4.54	4.59
query36	0.64	0.50	0.49
query37	0.11	0.06	0.06
query38	0.04	0.03	0.04
query39	0.04	0.03	0.03
query40	0.17	0.14	0.13
query41	0.08	0.03	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.02
Total cold run time: 107.1 s
Total hot run time: 32.3 s

@amorynan
Copy link
Contributor Author

amorynan commented Jan 9, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Jan 9, 2025

TPC-H: Total hot run time: 32535 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6295442e7a6fde91445fd6d3a5b9c464712751dd, data reload: false

------ Round 1 ----------------------------------
q1	17720	6167	6017	6017
q2	2046	307	178	178
q3	10404	1245	763	763
q4	10289	858	432	432
q5	8714	2165	1974	1974
q6	205	178	147	147
q7	910	780	605	605
q8	9243	1352	1142	1142
q9	5218	4918	4866	4866
q10	6761	2308	1845	1845
q11	486	277	270	270
q12	342	383	216	216
q13	17759	3595	3092	3092
q14	234	230	215	215
q15	561	513	505	505
q16	639	618	576	576
q17	574	853	338	338
q18	6889	6502	6364	6364
q19	1908	946	510	510
q20	305	324	195	195
q21	2863	2194	1984	1984
q22	360	333	301	301
Total cold run time: 104430 ms
Total hot run time: 32535 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6323	6194	6225	6194
q2	248	333	235	235
q3	2260	2696	2325	2325
q4	1393	1749	1386	1386
q5	4326	4744	4799	4744
q6	186	181	145	145
q7	2113	1990	1807	1807
q8	2595	2802	2733	2733
q9	7234	7142	7209	7142
q10	3045	3293	2723	2723
q11	584	513	496	496
q12	738	784	647	647
q13	3462	3850	3214	3214
q14	284	313	297	297
q15	575	518	502	502
q16	668	675	645	645
q17	1241	1759	1276	1276
q18	7873	7543	7390	7390
q19	795	1145	1065	1065
q20	1951	2045	2013	2013
q21	5701	5101	5069	5069
q22	603	599	616	599
Total cold run time: 54198 ms
Total hot run time: 52647 ms

@doris-robot
Copy link

doris-robot commented Jan 9, 2025

TPC-DS: Total hot run time: 195776 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6295442e7a6fde91445fd6d3a5b9c464712751dd, data reload: false

query1	1297	950	913	913
query2	6437	2359	2327	2327
query3	10982	4592	4444	4444
query4	33415	23805	23248	23248
query5	4950	611	459	459
query6	289	193	183	183
query7	3988	479	320	320
query8	297	252	237	237
query9	9468	2710	2725	2710
query10	476	308	258	258
query11	18025	15256	15129	15129
query12	169	110	103	103
query13	1586	521	398	398
query14	10660	7735	7642	7642
query15	237	194	188	188
query16	7884	652	485	485
query17	1507	761	627	627
query18	2106	422	307	307
query19	219	185	157	157
query20	119	111	113	111
query21	199	147	110	110
query22	4685	4512	4399	4399
query23	33984	33430	33394	33394
query24	6158	2322	2431	2322
query25	469	451	386	386
query26	733	279	149	149
query27	1954	471	339	339
query28	5031	2488	2460	2460
query29	633	551	427	427
query30	225	184	153	153
query31	956	863	821	821
query32	74	57	58	57
query33	477	347	296	296
query34	798	857	507	507
query35	782	836	717	717
query36	1018	1038	961	961
query37	124	95	76	76
query38	4052	4175	4089	4089
query39	1517	1471	1441	1441
query40	204	116	98	98
query41	52	46	47	46
query42	125	102	103	102
query43	507	536	506	506
query44	1346	839	861	839
query45	180	178	171	171
query46	880	1071	648	648
query47	1942	1905	1837	1837
query48	383	411	338	338
query49	726	505	390	390
query50	681	670	403	403
query51	7189	7124	7095	7095
query52	102	99	94	94
query53	235	253	183	183
query54	495	486	436	436
query55	94	84	83	83
query56	246	256	256	256
query57	1228	1206	1129	1129
query58	242	226	229	226
query59	3212	3235	3162	3162
query60	304	268	260	260
query61	116	127	110	110
query62	869	786	719	719
query63	229	186	187	186
query64	2965	1046	666	666
query65	3247	3356	3235	3235
query66	776	398	306	306
query67	16275	15708	15425	15425
query68	7184	703	534	534
query69	509	299	249	249
query70	1187	1149	1114	1114
query71	447	282	257	257
query72	6272	3926	4055	3926
query73	656	764	358	358
query74	10302	9279	9014	9014
query75	4089	3104	2626	2626
query76	3732	1176	765	765
query77	774	371	267	267
query78	10032	10004	9250	9250
query79	3486	826	610	610
query80	634	508	431	431
query81	479	273	226	226
query82	667	157	122	122
query83	160	161	142	142
query84	289	83	78	78
query85	898	354	296	296
query86	364	311	303	303
query87	4306	4545	4358	4358
query88	4450	2189	2160	2160
query89	415	316	303	303
query90	1794	190	196	190
query91	137	131	106	106
query92	69	56	57	56
query93	2073	834	539	539
query94	656	400	293	293
query95	338	268	254	254
query96	483	604	286	286
query97	2886	2910	2789	2789
query98	215	200	200	200
query99	1604	1479	1375	1375
Total cold run time: 294417 ms
Total hot run time: 195776 ms

@doris-robot
Copy link

doris-robot commented Jan 9, 2025

ClickBench: Total hot run time: 31.75 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 6295442e7a6fde91445fd6d3a5b9c464712751dd, data reload: false

query1	0.03	0.03	0.03
query2	0.09	0.03	0.04
query3	0.24	0.07	0.06
query4	1.62	0.10	0.10
query5	0.42	0.42	0.40
query6	1.16	0.66	0.66
query7	0.02	0.02	0.02
query8	0.04	0.03	0.04
query9	0.59	0.49	0.51
query10	0.56	0.58	0.55
query11	0.15	0.10	0.11
query12	0.15	0.12	0.11
query13	0.61	0.61	0.60
query14	2.81	2.71	2.80
query15	0.91	0.83	0.82
query16	0.36	0.39	0.38
query17	1.04	1.02	1.07
query18	0.23	0.21	0.21
query19	1.99	1.87	1.92
query20	0.01	0.01	0.01
query21	15.36	0.91	0.58
query22	0.77	0.73	0.71
query23	15.35	1.40	0.61
query24	2.96	1.25	1.40
query25	0.21	0.15	0.11
query26	0.25	0.15	0.14
query27	0.06	0.05	0.04
query28	14.12	1.56	1.04
query29	12.62	3.95	3.30
query30	0.25	0.09	0.06
query31	2.82	0.60	0.38
query32	3.23	0.55	0.48
query33	3.02	3.12	3.10
query34	16.85	5.12	4.50
query35	4.51	4.45	4.48
query36	0.66	0.49	0.48
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.02	0.02
query40	0.16	0.13	0.13
query41	0.07	0.02	0.02
query42	0.04	0.03	0.02
query43	0.03	0.03	0.03
Total cold run time: 106.54 s
Total hot run time: 31.75 s

eldenmoon
eldenmoon reviewed Jan 10, 2025
View reviewed changes
eldenmoon
eldenmoon reviewed Jan 10, 2025
View reviewed changes
@amorynan
Copy link
Contributor Author

amorynan commented Jan 10, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Jan 14, 2025

ClickBench: Total hot run time: 31.29 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 8b2aaf73c318049ffdb15f19e1d6f1cd3fdcc647, data reload: false

query1	0.03	0.04	0.03
query2	0.08	0.03	0.03
query3	0.25	0.07	0.07
query4	1.62	0.11	0.10
query5	0.40	0.42	0.42
query6	1.16	0.65	0.66
query7	0.02	0.02	0.01
query8	0.03	0.04	0.03
query9	0.58	0.51	0.49
query10	0.55	0.57	0.55
query11	0.14	0.10	0.11
query12	0.14	0.10	0.10
query13	0.61	0.60	0.60
query14	2.82	2.77	2.83
query15	0.90	0.83	0.83
query16	0.40	0.39	0.38
query17	1.02	1.06	0.99
query18	0.22	0.20	0.20
query19	1.92	1.84	2.02
query20	0.02	0.01	0.01
query21	15.37	0.89	0.60
query22	0.75	0.97	0.62
query23	15.18	1.48	0.55
query24	3.27	1.20	0.97
query25	0.22	0.35	0.09
query26	0.26	0.14	0.14
query27	0.07	0.04	0.04
query28	13.68	1.50	1.04
query29	12.56	3.98	3.27
query30	0.25	0.08	0.06
query31	2.83	0.59	0.37
query32	3.22	0.55	0.47
query33	2.98	3.04	3.06
query34	16.55	5.14	4.51
query35	4.60	4.53	4.56
query36	0.82	0.48	0.48
query37	0.09	0.06	0.06
query38	0.04	0.04	0.03
query39	0.04	0.02	0.02
query40	0.18	0.13	0.13
query41	0.07	0.03	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.02 s
Total hot run time: 31.29 s

eldenmoon
eldenmoon approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@eldenmoon eldenmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Jan 15, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 15, 2025
Hastyshell
Hastyshell approved these changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@Hastyshell Hastyshell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eldenmoon eldenmoon merged commit def0ed3 into apache:master Jan 15, 2025
25 of 26 checks passed
@eldenmoon eldenmoon added dev/2.0.x dev/3.0.x dev/2.1.x usercase Important user case type label and removed dev/3.0.x labels Jan 15, 2025
github-actions bot pushed a commit that referenced this pull request Jan 15, 2025
[improve](schema-change) support nested type with varchar type to sup…
41f22fc 
…port length growing (#46639)

The array|map|struct schema-change behavior supports moditfy to change
the length of the varchar type in the current column type.
before
```
mysql> alter table t_sc MODIFY COLUMN s struct<col:varchar(20)>;
ERROR 1105 (HY000): errCode = 2, detailMessage = Can not change struct<col:varchar(10)> to `__doris_shadow_s` struct<col:varchar(20)> NULL
```
@github-actions github-actions bot mentioned this pull request Jan 15, 2025
Closed
lzyy2024 pushed a commit to lzyy2024/doris that referenced this pull request Feb 21, 2025
@lzyy2024
[improve](schema-change) support nested type with varchar type to sup…
fd36016 
…port length growing (apache#46639)

The array|map|struct schema-change behavior supports moditfy to change
the length of the varchar type in the current column type.
before
```
mysql> alter table t_sc MODIFY COLUMN s struct<col:varchar(20)>;
ERROR 1105 (HY000): errCode = 2, detailMessage = Can not change struct<col:varchar(10)> to `__doris_shadow_s` struct<col:varchar(20)> NULL
```
@Hastyshell Hastyshell mentioned this pull request Mar 4, 2025
Merged
16 tasks
@eldenmoon eldenmoon mentioned this pull request Mar 5, 2025
Merged
16 tasks
dataroaring pushed a commit that referenced this pull request Mar 6, 2025
@Hastyshell
[fix](schema-change) Complete check for string type length change (#4…
7cd9757 
…8607)

### What problem does this PR solve?

Related PR: introduce #46639

Problem Summary:

After the change of #46639, shorten length for CHAR type escapes from
checking of schema change. Fix in this PR and add some regression test
cases to verify it.
amorynan pushed a commit to amorynan/doris that referenced this pull request Mar 25, 2025
@Hastyshell
[fix](schema-change) Complete check for string type length change (ap…
8d02651 
…ache#48607)

Related PR: introduce apache#46639

Problem Summary:

After the change of apache#46639, shorten length for CHAR type escapes from
checking of schema change. Fix in this PR and add some regression test
cases to verify it.
@Hastyshell Hastyshell mentioned this pull request Mar 25, 2025
Merged
16 tasks
dataroaring pushed a commit that referenced this pull request Mar 26, 2025
@Hastyshell
[fix](schema-change) Nested types should only support enlarging varch…
8b268dc 
…ar length with light schema change (#49452)

Introduce: #48607, #46639

Problem Summary:

Currently nested types only support light schema change for internal
fields, for string types, only varchar can do light schema change.
dataroaring pushed a commit that referenced this pull request Mar 27, 2025
@Hastyshell
[improve](schema-change) support nested type with varchar type to sup…
7dbe083 
…port length growing (#48025)

### What problem does this PR solve?
cherry-pick from #46639
#48607
#49452 should be picked soon to
resovle problem introduced by the pr
Issue Number: close #xxx
Co-authored-by: Siyang Tang <tangsiyang2001@foxmail.com>
Hastyshell added a commit to Hastyshell/doris that referenced this pull request Mar 27, 2025
@Hastyshell
[fix](schema-change) Nested types should only support enlarging varch…
16b090e 
…ar length with light schema change (apache#49452)

Introduce: apache#48607, apache#46639

Problem Summary:

Currently nested types only support light schema change for internal
fields, for string types, only varchar can do light schema change.
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
@Hastyshell @koarz
[fix](schema-change) Complete check for string type length change (ap…
938d98c 
…ache#48607)

### What problem does this PR solve?

Related PR: introduce apache#46639

Problem Summary:

After the change of apache#46639, shorten length for CHAR type escapes from
checking of schema change. Fix in this PR and add some regression test
cases to verify it.
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
@Hastyshell @koarz
[fix](schema-change) Nested types should only support enlarging varch…
a6e71d6 
…ar length with light schema change (apache#49452)

Introduce: apache#48607, apache#46639

Problem Summary:

Currently nested types only support light schema change for internal
fields, for string types, only varchar can do light schema change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eldenmoon eldenmoon eldenmoon approved these changes

+1 more reviewer

@Hastyshell Hastyshell Hastyshell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.5-merged reviewed usercase Important user case type label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@amorynan @Thearas @doris-robot @eldenmoon @Hastyshell @xiaokang @dataroaring