-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[improve](schema-change) support nested type with varchar type to support length growing #48025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 41443 ms |
TPC-DS: Total hot run time: 192319 ms |
ClickBench: Total hot run time: 33.07 s |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 40111 ms |
TPC-DS: Total hot run time: 197702 ms |
ClickBench: Total hot run time: 31.64 s |
Contributor
Author
|
run cloud_p0 |
Contributor
Author
|
run buildall |
Contributor
Author
|
run p0 |
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 40817 ms |
TPC-DS: Total hot run time: 191062 ms |
ClickBench: Total hot run time: 31.77 s |
…ache#48607) Related PR: introduce apache#46639 Problem Summary: After the change of apache#46639, shorten length for CHAR type escapes from checking of schema change. Fix in this PR and add some regression test cases to verify it.
Contributor
Author
|
run buildall |
Hastyshell
reviewed
Mar 25, 2025
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 40229 ms |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 39745 ms |
TPC-DS: Total hot run time: 196567 ms |
ClickBench: Total hot run time: 32.39 s |
Contributor
Author
|
run buildall |
dataroaring
approved these changes
Mar 27, 2025
Contributor
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
cherry-pick from #46639
#48607
#49452 should be picked soon to resovle problem introduced by the pr
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)