[fix](schema-change) Complete check for string type length change #48607

Hastyshell · 2025-03-04T05:12:57Z

What problem does this PR solve?

Related PR: introduce #46639

Problem Summary:

After the change of #46639, shorten length for CHAR type escapes from checking of schema change. Fix in this PR and add some regression test cases to verify it.

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

hello-stephen · 2025-03-04T05:13:01Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

…eted

Hastyshell · 2025-03-04T06:45:03Z

run buildall

doris-robot · 2025-03-04T07:23:55Z

TPC-H: Total hot run time: 31694 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a491cc3c73404c428dbbf2822ca73823eb8ee02e, data reload: false

------ Round 1 ----------------------------------
q1	17615	5234	5277	5234
q2	2055	290	168	168
q3	10455	1263	748	748
q4	10245	1007	526	526
q5	8071	2377	2311	2311
q6	190	169	132	132
q7	909	746	622	622
q8	9310	1302	1040	1040
q9	4867	4830	4697	4697
q10	6817	2310	1907	1907
q11	502	288	271	271
q12	349	356	230	230
q13	18128	3948	3130	3130
q14	231	222	213	213
q15	502	472	457	457
q16	645	632	577	577
q17	592	866	342	342
q18	6732	6277	6131	6131
q19	1684	961	539	539
q20	320	315	194	194
q21	2767	2195	1923	1923
q22	369	331	302	302
Total cold run time: 103355 ms
Total hot run time: 31694 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5184	5161	5140	5140
q2	234	323	226	226
q3	2191	2685	2259	2259
q4	1426	1870	1375	1375
q5	4238	4133	4163	4133
q6	211	175	129	129
q7	1836	1789	1761	1761
q8	2612	2651	2534	2534
q9	7278	7164	7201	7164
q10	2987	3227	2844	2844
q11	578	517	494	494
q12	674	800	634	634
q13	3403	3979	3306	3306
q14	296	298	272	272
q15	497	475	460	460
q16	651	722	652	652
q17	1138	1595	1342	1342
q18	7545	7305	7275	7275
q19	775	885	1081	885
q20	1950	2076	1873	1873
q21	5492	5034	4670	4670
q22	630	595	551	551
Total cold run time: 51826 ms
Total hot run time: 49979 ms

doris-robot · 2025-03-04T07:36:06Z

TPC-DS: Total hot run time: 191769 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a491cc3c73404c428dbbf2822ca73823eb8ee02e, data reload: false

query1	1317	984	965	965
query2	6225	1935	1869	1869
query3	11123	4756	4684	4684
query4	52867	25396	23018	23018
query5	4953	576	506	506
query6	333	197	202	197
query7	4885	517	297	297
query8	321	250	242	242
query9	5404	2551	2545	2545
query10	425	322	264	264
query11	15393	15170	14910	14910
query12	150	113	113	113
query13	1055	526	409	409
query14	10966	6771	7359	6771
query15	217	202	181	181
query16	7096	686	493	493
query17	1092	729	594	594
query18	1571	424	342	342
query19	200	201	167	167
query20	133	164	127	127
query21	203	125	109	109
query22	4345	4603	4408	4408
query23	34096	33363	33450	33363
query24	5771	2491	2495	2491
query25	455	470	413	413
query26	745	295	163	163
query27	1854	522	341	341
query28	2787	2470	2459	2459
query29	585	579	422	422
query30	226	195	161	161
query31	926	865	809	809
query32	72	68	60	60
query33	462	367	316	316
query34	801	893	504	504
query35	786	854	772	772
query36	951	1007	881	881
query37	145	98	76	76
query38	4180	4327	4212	4212
query39	1487	1533	1446	1446
query40	207	127	99	99
query41	52	52	56	52
query42	128	105	105	105
query43	533	520	485	485
query44	1367	806	814	806
query45	180	185	168	168
query46	934	1095	678	678
query47	1853	1861	1801	1801
query48	386	417	306	306
query49	711	555	412	412
query50	728	786	446	446
query51	4332	4397	4300	4300
query52	114	111	104	104
query53	239	268	195	195
query54	493	507	430	430
query55	87	85	83	83
query56	269	290	265	265
query57	1159	1182	1135	1135
query58	252	245	241	241
query59	2809	2933	2871	2871
query60	331	283	278	278
query61	122	122	115	115
query62	737	744	714	714
query63	244	197	195	195
query64	2022	1047	689	689
query65	3332	3263	3246	3246
query66	730	398	301	301
query67	15745	15431	15651	15431
query68	7252	916	518	518
query69	544	306	271	271
query70	1187	1122	1071	1071
query71	506	301	272	272
query72	5801	3671	3832	3671
query73	1529	768	353	353
query74	9066	9102	8785	8785
query75	3793	3196	2790	2790
query76	4165	1199	765	765
query77	652	388	284	284
query78	10013	10045	9337	9337
query79	3737	861	584	584
query80	716	543	450	450
query81	518	283	243	243
query82	699	127	98	98
query83	272	177	154	154
query84	335	105	72	72
query85	789	351	309	309
query86	358	280	286	280
query87	4463	4380	4311	4311
query88	3427	2230	2222	2222
query89	437	316	281	281
query90	1893	195	194	194
query91	139	142	107	107
query92	75	61	56	56
query93	1837	1057	581	581
query94	671	422	305	305
query95	351	272	264	264
query96	486	566	281	281
query97	3352	3404	3299	3299
query98	219	211	197	197
query99	1460	1411	1313	1313
Total cold run time: 297441 ms
Total hot run time: 191769 ms

doris-robot · 2025-03-04T07:41:25Z

ClickBench: Total hot run time: 31.06 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a491cc3c73404c428dbbf2822ca73823eb8ee02e, data reload: false

query1	0.04	0.04	0.03
query2	0.07	0.03	0.03
query3	0.23	0.07	0.06
query4	1.62	0.10	0.10
query5	0.58	0.55	0.54
query6	1.21	0.71	0.73
query7	0.02	0.02	0.02
query8	0.04	0.03	0.03
query9	0.58	0.56	0.53
query10	0.56	0.56	0.56
query11	0.16	0.11	0.10
query12	0.14	0.11	0.11
query13	0.62	0.59	0.60
query14	2.79	2.71	2.68
query15	0.93	0.85	0.85
query16	0.40	0.39	0.39
query17	1.03	1.02	1.03
query18	0.20	0.20	0.20
query19	1.93	1.78	2.02
query20	0.01	0.02	0.01
query21	15.38	0.87	0.55
query22	0.76	1.05	0.62
query23	15.12	1.36	0.60
query24	7.09	1.78	0.97
query25	0.49	0.23	0.25
query26	0.61	0.17	0.15
query27	0.05	0.05	0.05
query28	9.40	0.87	0.43
query29	12.55	4.01	3.36
query30	0.24	0.10	0.07
query31	2.83	0.58	0.38
query32	3.23	0.55	0.46
query33	2.95	2.98	3.04
query34	15.80	5.13	4.53
query35	4.58	4.55	4.59
query36	0.66	0.49	0.48
query37	0.10	0.07	0.06
query38	0.04	0.04	0.03
query39	0.04	0.02	0.03
query40	0.17	0.14	0.13
query41	0.08	0.03	0.03
query42	0.03	0.02	0.02
query43	0.04	0.03	0.02
Total cold run time: 105.4 s
Total hot run time: 31.06 s

Hastyshell · 2025-03-04T08:04:08Z

run buildall

Hastyshell · 2025-03-04T08:11:15Z

run buildall

doris-robot · 2025-03-04T08:55:04Z

TPC-H: Total hot run time: 31603 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 689eaaa75bb05185edc27ed6d655af960056299b, data reload: false

------ Round 1 ----------------------------------
q1	17592	5247	5082	5082
q2	2043	304	168	168
q3	10426	1265	770	770
q4	10204	1028	545	545
q5	7530	2375	2357	2357
q6	182	165	129	129
q7	888	733	614	614
q8	9340	1269	1060	1060
q9	4952	4738	4719	4719
q10	6831	2322	1889	1889
q11	479	281	257	257
q12	360	358	229	229
q13	17766	3675	3142	3142
q14	233	233	209	209
q15	514	470	456	456
q16	628	625	562	562
q17	581	846	335	335
q18	6913	6134	6140	6134
q19	1244	939	527	527
q20	314	322	190	190
q21	2867	2290	1916	1916
q22	368	332	313	313
Total cold run time: 102255 ms
Total hot run time: 31603 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5222	5237	5146	5146
q2	238	326	228	228
q3	2172	2713	2340	2340
q4	1437	1834	1379	1379
q5	4204	4088	4153	4088
q6	204	164	121	121
q7	1857	1855	1693	1693
q8	2603	2496	2498	2496
q9	7265	7190	7238	7190
q10	3035	3232	2832	2832
q11	580	537	497	497
q12	683	793	654	654
q13	3425	3920	3349	3349
q14	289	290	257	257
q15	501	470	463	463
q16	654	692	659	659
q17	1124	1637	1313	1313
q18	7531	7403	7307	7307
q19	789	853	1019	853
q20	1965	2078	1878	1878
q21	5551	5094	4834	4834
q22	615	573	541	541
Total cold run time: 51944 ms
Total hot run time: 50118 ms

doris-robot · 2025-03-04T09:07:13Z

TPC-DS: Total hot run time: 190568 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 689eaaa75bb05185edc27ed6d655af960056299b, data reload: false

query1	1309	940	938	938
query2	6220	1847	1849	1847
query3	11118	4503	4766	4503
query4	53026	25828	23486	23486
query5	5258	561	460	460
query6	346	195	181	181
query7	4912	524	296	296
query8	324	245	232	232
query9	5801	2547	2535	2535
query10	428	333	263	263
query11	15140	15328	14832	14832
query12	168	114	110	110
query13	1078	531	376	376
query14	10577	6352	6867	6352
query15	216	203	182	182
query16	7198	697	494	494
query17	1063	732	575	575
query18	1510	437	308	308
query19	198	191	165	165
query20	133	130	117	117
query21	208	129	103	103
query22	4466	4590	4313	4313
query23	33837	33476	33600	33476
query24	5929	2438	2419	2419
query25	467	470	432	432
query26	726	307	152	152
query27	1802	544	335	335
query28	2905	2477	2461	2461
query29	578	586	431	431
query30	224	202	157	157
query31	908	878	831	831
query32	74	60	60	60
query33	459	370	316	316
query34	800	929	508	508
query35	841	843	751	751
query36	961	1020	917	917
query37	119	98	75	75
query38	4225	4276	4075	4075
query39	1544	1416	1433	1416
query40	218	121	106	106
query41	52	50	51	50
query42	130	105	111	105
query43	501	503	498	498
query44	1387	820	807	807
query45	177	167	163	163
query46	965	1131	650	650
query47	1829	1878	1823	1823
query48	399	448	310	310
query49	713	540	437	437
query50	807	793	426	426
query51	4192	4286	4294	4286
query52	116	106	97	97
query53	249	275	188	188
query54	492	509	425	425
query55	84	81	88	81
query56	266	300	269	269
query57	1186	1197	1146	1146
query58	252	239	238	238
query59	2787	2927	2719	2719
query60	286	304	259	259
query61	145	146	174	146
query62	739	771	674	674
query63	240	192	184	184
query64	1962	1039	668	668
query65	3317	3270	3219	3219
query66	755	408	307	307
query67	15902	15506	15267	15267
query68	6726	906	519	519
query69	537	304	261	261
query70	1201	1143	1069	1069
query71	485	296	256	256
query72	5743	3581	3908	3581
query73	1469	775	363	363
query74	9044	8996	9060	8996
query75	3723	3158	2671	2671
query76	4126	1274	763	763
query77	618	394	280	280
query78	10200	10288	9306	9306
query79	2425	868	586	586
query80	640	534	447	447
query81	507	280	241	241
query82	629	130	100	100
query83	180	176	152	152
query84	292	95	77	77
query85	772	359	308	308
query86	403	309	307	307
query87	4398	4637	4259	4259
query88	3843	2232	2204	2204
query89	412	317	275	275
query90	1790	197	192	192
query91	140	135	110	110
query92	75	60	56	56
query93	1734	1072	587	587
query94	671	434	304	304
query95	346	269	250	250
query96	492	635	268	268
query97	3466	3383	3271	3271
query98	231	215	209	209
query99	1434	1417	1272	1272
Total cold run time: 295996 ms
Total hot run time: 190568 ms

doris-robot · 2025-03-04T09:12:31Z

ClickBench: Total hot run time: 30.52 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 689eaaa75bb05185edc27ed6d655af960056299b, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.03	0.03
query3	0.24	0.06	0.06
query4	1.62	0.11	0.10
query5	0.55	0.55	0.56
query6	1.18	0.71	0.72
query7	0.02	0.02	0.01
query8	0.04	0.04	0.02
query9	0.61	0.54	0.52
query10	0.57	0.58	0.57
query11	0.16	0.11	0.11
query12	0.14	0.11	0.12
query13	0.60	0.60	0.61
query14	2.82	2.70	2.69
query15	0.93	0.85	0.85
query16	0.37	0.38	0.37
query17	1.03	1.04	1.03
query18	0.20	0.20	0.19
query19	1.87	1.79	2.00
query20	0.01	0.01	0.01
query21	15.37	0.90	0.55
query22	0.75	1.24	0.66
query23	14.89	1.42	0.61
query24	6.78	2.41	0.49
query25	0.54	0.20	0.19
query26	0.63	0.16	0.13
query27	0.05	0.04	0.05
query28	9.24	0.87	0.43
query29	12.54	3.93	3.28
query30	0.25	0.08	0.06
query31	2.83	0.57	0.38
query32	3.23	0.55	0.47
query33	3.01	2.98	3.03
query34	15.72	5.18	4.58
query35	4.59	4.53	4.57
query36	0.65	0.49	0.50
query37	0.09	0.07	0.06
query38	0.05	0.03	0.03
query39	0.04	0.02	0.02
query40	0.18	0.15	0.12
query41	0.09	0.03	0.02
query42	0.04	0.03	0.02
query43	0.04	0.03	0.03
Total cold run time: 104.68 s
Total hot run time: 30.52 s

Hastyshell · 2025-03-04T11:52:50Z

run buildall

Hastyshell · 2025-03-04T12:28:42Z

run buildall

eldenmoon

LGTM

github-actions · 2025-03-04T13:41:48Z

PR approved by at least one committer and no changes requested.

github-actions · 2025-03-04T13:41:51Z

PR approved by anyone and no changes requested.

doris-robot · 2025-03-04T13:44:43Z

TPC-H: Total hot run time: 31504 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c99c9efeaed24d1f6584dfa18ef0c83d700f1082, data reload: false

------ Round 1 ----------------------------------
q1	17586	5247	5079	5079
q2	2056	302	168	168
q3	10403	1299	716	716
q4	10225	1044	520	520
q5	7559	2427	2368	2368
q6	190	167	133	133
q7	914	749	604	604
q8	9300	1297	1088	1088
q9	5024	4621	4820	4621
q10	6819	2344	1897	1897
q11	495	286	272	272
q12	349	356	213	213
q13	17799	3706	3073	3073
q14	233	230	221	221
q15	515	490	476	476
q16	634	637	581	581
q17	579	880	359	359
q18	6678	6323	6137	6137
q19	1908	956	546	546
q20	320	330	197	197
q21	2832	2186	1921	1921
q22	376	343	314	314
Total cold run time: 102794 ms
Total hot run time: 31504 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5192	5139	5139	5139
q2	244	332	230	230
q3	2168	2695	2316	2316
q4	1444	1850	1405	1405
q5	4252	4126	4156	4126
q6	210	163	123	123
q7	1873	1806	1678	1678
q8	2523	2605	2484	2484
q9	6870	6860	6748	6748
q10	2892	3107	2663	2663
q11	578	497	496	496
q12	646	758	606	606
q13	3320	3668	3064	3064
q14	266	279	258	258
q15	515	470	454	454
q16	640	683	638	638
q17	1128	1570	1302	1302
q18	7242	7107	6995	6995
q19	786	784	785	784
q20	1913	1965	1796	1796
q21	5237	4934	4612	4612
q22	624	604	552	552
Total cold run time: 50563 ms
Total hot run time: 48469 ms

amorynan

LGTM

doris-robot · 2025-03-04T13:56:13Z

TPC-DS: Total hot run time: 183892 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c99c9efeaed24d1f6584dfa18ef0c83d700f1082, data reload: false

query1	972	373	378	373
query2	6537	1909	1887	1887
query3	6797	212	212	212
query4	25738	23224	23145	23145
query5	4798	663	491	491
query6	305	207	181	181
query7	4610	491	301	301
query8	294	245	243	243
query9	8636	2586	2606	2586
query10	472	352	250	250
query11	15370	15060	14938	14938
query12	174	107	108	107
query13	1660	526	389	389
query14	11625	6674	6456	6456
query15	257	195	175	175
query16	7794	656	499	499
query17	1586	727	570	570
query18	2025	404	317	317
query19	269	192	156	156
query20	125	119	121	119
query21	266	123	103	103
query22	4262	4294	4187	4187
query23	33756	32941	32911	32911
query24	7001	2382	2353	2353
query25	491	452	381	381
query26	799	270	153	153
query27	1973	494	326	326
query28	3844	2446	2432	2432
query29	597	545	417	417
query30	236	191	155	155
query31	955	870	820	820
query32	69	76	62	62
query33	543	356	291	291
query34	777	849	492	492
query35	819	809	727	727
query36	933	968	901	901
query37	118	94	75	75
query38	4306	4279	4082	4082
query39	1476	1563	1389	1389
query40	209	115	102	102
query41	55	51	52	51
query42	123	104	104	104
query43	501	506	489	489
query44	1257	798	777	777
query45	187	168	161	161
query46	861	1044	641	641
query47	1745	1764	1718	1718
query48	402	419	301	301
query49	748	503	399	399
query50	668	736	397	397
query51	4138	4136	4169	4136
query52	103	111	95	95
query53	225	248	185	185
query54	492	490	400	400
query55	89	80	80	80
query56	261	272	238	238
query57	1147	1155	1033	1033
query58	238	240	244	240
query59	2660	2749	2568	2568
query60	279	264	254	254
query61	121	124	119	119
query62	778	780	665	665
query63	230	182	187	182
query64	3432	1003	669	669
query65	3266	3103	3140	3103
query66	849	410	362	362
query67	15718	15587	15305	15305
query68	8275	866	509	509
query69	471	294	268	268
query70	1226	1162	1119	1119
query71	473	294	270	270
query72	5791	3459	3707	3459
query73	791	715	359	359
query74	9033	8932	8802	8802
query75	3938	3175	2688	2688
query76	3669	1159	722	722
query77	788	366	279	279
query78	10096	10148	9305	9305
query79	2883	823	592	592
query80	653	512	451	451
query81	495	285	244	244
query82	700	125	93	93
query83	167	172	158	158
query84	241	97	78	78
query85	782	350	309	309
query86	339	305	292	292
query87	4381	4437	4581	4437
query88	3410	2276	2166	2166
query89	393	324	290	290
query90	1941	194	196	194
query91	139	135	115	115
query92	77	59	55	55
query93	1652	1045	576	576
query94	674	412	361	361
query95	346	268	257	257
query96	480	548	268	268
query97	3325	3394	3276	3276
query98	227	208	196	196
query99	1688	1386	1278	1278
Total cold run time: 273591 ms
Total hot run time: 183892 ms

doris-robot · 2025-03-04T14:01:30Z

ClickBench: Total hot run time: 30.88 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit c99c9efeaed24d1f6584dfa18ef0c83d700f1082, data reload: false

query1	0.03	0.03	0.03
query2	0.08	0.03	0.03
query3	0.24	0.07	0.06
query4	1.62	0.10	0.10
query5	0.57	0.54	0.56
query6	1.18	0.72	0.72
query7	0.02	0.02	0.02
query8	0.04	0.03	0.03
query9	0.58	0.55	0.51
query10	0.57	0.59	0.58
query11	0.16	0.11	0.10
query12	0.14	0.11	0.12
query13	0.60	0.60	0.60
query14	2.81	2.76	2.68
query15	0.93	0.85	0.85
query16	0.36	0.39	0.37
query17	1.01	1.05	1.03
query18	0.22	0.20	0.19
query19	1.94	1.78	2.03
query20	0.02	0.01	0.01
query21	15.38	0.91	0.56
query22	0.78	1.10	0.65
query23	14.98	1.39	0.64
query24	6.88	1.03	1.68
query25	0.48	0.35	0.11
query26	0.52	0.16	0.13
query27	0.05	0.04	0.05
query28	9.90	0.84	0.44
query29	12.58	3.89	3.25
query30	0.26	0.10	0.06
query31	2.82	0.58	0.39
query32	3.23	0.55	0.48
query33	2.99	2.97	3.01
query34	15.78	5.06	4.49
query35	4.52	4.54	4.51
query36	0.64	0.51	0.47
query37	0.09	0.07	0.06
query38	0.04	0.04	0.05
query39	0.03	0.02	0.03
query40	0.17	0.14	0.12
query41	0.08	0.03	0.03
query42	0.04	0.02	0.02
query43	0.04	0.04	0.03
Total cold run time: 105.4 s
Total hot run time: 30.88 s

Hastyshell · 2025-03-05T02:31:37Z

run cloud_p0

Hastyshell · 2025-03-05T02:31:44Z

run external

Hastyshell · 2025-03-05T02:31:50Z

run p0

Hastyshell · 2025-03-05T06:54:09Z

run buildall

doris-robot · 2025-03-05T07:59:09Z

TPC-H: Total hot run time: 32407 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 21e3200a0c9c9c2c75423644630151ed22a7fdfb, data reload: false

------ Round 1 ----------------------------------
q1	17604	5205	5010	5010
q2	2050	290	171	171
q3	10659	1226	737	737
q4	10249	1010	545	545
q5	7751	2380	2319	2319
q6	189	167	133	133
q7	895	742	616	616
q8	9304	1232	1105	1105
q9	4978	4820	4775	4775
q10	6862	2306	1863	1863
q11	479	276	250	250
q12	342	352	215	215
q13	17765	3633	3055	3055
q14	217	222	207	207
q15	532	492	489	489
q16	616	615	576	576
q17	572	844	346	346
q18	6916	6446	6336	6336
q19	1620	946	549	549
q20	309	321	189	189
q21	2729	2159	1935	1935
q22	1059	1026	986	986
Total cold run time: 103697 ms
Total hot run time: 32407 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5204	5090	5177	5090
q2	236	336	234	234
q3	2128	2622	2297	2297
q4	1417	1834	1398	1398
q5	4241	4129	4128	4128
q6	202	162	123	123
q7	1858	1876	1770	1770
q8	2609	2690	2554	2554
q9	7289	7206	7190	7190
q10	3015	3249	2779	2779
q11	583	544	481	481
q12	672	797	586	586
q13	3309	3908	3261	3261
q14	274	296	284	284
q15	524	487	459	459
q16	634	703	634	634
q17	1122	1607	1362	1362
q18	7832	7613	7337	7337
q19	820	811	873	811
q20	1984	2032	1905	1905
q21	5494	5065	4764	4764
q22	1101	1108	1042	1042
Total cold run time: 52548 ms
Total hot run time: 50489 ms

doris-robot · 2025-03-05T08:11:19Z

TPC-DS: Total hot run time: 191246 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 21e3200a0c9c9c2c75423644630151ed22a7fdfb, data reload: false

query1	1381	1042	1007	1007
query2	6203	1944	1971	1944
query3	11218	4446	4600	4446
query4	54364	24632	23181	23181
query5	5194	511	481	481
query6	349	205	198	198
query7	4867	506	289	289
query8	310	243	236	236
query9	5544	2570	2545	2545
query10	426	346	254	254
query11	15025	15076	14808	14808
query12	153	113	111	111
query13	1046	512	404	404
query14	10472	6897	6341	6341
query15	207	198	175	175
query16	7091	691	506	506
query17	1082	730	579	579
query18	1618	425	319	319
query19	206	205	177	177
query20	135	129	125	125
query21	245	127	108	108
query22	4390	4607	4320	4320
query23	34029	33231	33382	33231
query24	5747	2408	2450	2408
query25	457	467	424	424
query26	715	268	157	157
query27	1792	504	327	327
query28	2957	2482	2456	2456
query29	574	545	442	442
query30	284	217	190	190
query31	882	861	801	801
query32	69	66	59	59
query33	456	353	314	314
query34	766	853	494	494
query35	781	827	779	779
query36	957	1021	910	910
query37	122	98	102	98
query38	4265	4169	4135	4135
query39	1648	1451	1414	1414
query40	207	112	98	98
query41	54	51	60	51
query42	134	103	100	100
query43	516	526	504	504
query44	1296	824	801	801
query45	178	174	170	170
query46	862	1011	637	637
query47	1859	1916	1784	1784
query48	386	414	299	299
query49	717	556	421	421
query50	710	750	412	412
query51	4272	4258	4233	4233
query52	109	106	97	97
query53	224	254	185	185
query54	466	493	422	422
query55	84	84	83	83
query56	263	273	256	256
query57	1169	1167	1100	1100
query58	235	242	230	230
query59	2972	2865	2753	2753
query60	280	275	254	254
query61	142	118	118	118
query62	744	744	667	667
query63	223	196	207	196
query64	1955	1044	672	672
query65	4535	4463	4311	4311
query66	736	390	300	300
query67	15863	15793	15639	15639
query68	7363	863	508	508
query69	528	289	272	272
query70	1219	1120	1099	1099
query71	489	295	263	263
query72	5832	3632	3673	3632
query73	1521	735	335	335
query74	9257	9032	8934	8934
query75	3672	3153	2706	2706
query76	4098	1227	747	747
query77	628	359	289	289
query78	10145	10047	9196	9196
query79	2386	836	575	575
query80	675	523	430	430
query81	473	262	220	220
query82	647	127	90	90
query83	286	164	147	147
query84	292	88	75	75
query85	775	402	299	299
query86	420	302	270	270
query87	4359	4436	4290	4290
query88	3662	2154	2145	2145
query89	411	318	276	276
query90	1865	190	190	190
query91	132	137	104	104
query92	77	59	55	55
query93	1730	1043	584	584
query94	655	405	282	282
query95	336	255	257	255
query96	477	554	265	265
query97	3357	3364	3303	3303
query98	234	204	197	197
query99	1429	1401	1227	1227
Total cold run time: 298648 ms
Total hot run time: 191246 ms

doris-robot · 2025-03-05T08:16:41Z

ClickBench: Total hot run time: 30.81 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 21e3200a0c9c9c2c75423644630151ed22a7fdfb, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.24	0.07	0.07
query4	1.62	0.11	0.11
query5	0.57	0.56	0.54
query6	1.18	0.72	0.72
query7	0.02	0.02	0.01
query8	0.04	0.04	0.04
query9	0.59	0.52	0.53
query10	0.56	0.58	0.56
query11	0.14	0.11	0.11
query12	0.15	0.12	0.12
query13	0.60	0.60	0.59
query14	2.66	2.81	2.66
query15	0.91	0.83	0.82
query16	0.37	0.36	0.38
query17	1.03	1.04	1.01
query18	0.21	0.19	0.19
query19	1.95	1.97	1.81
query20	0.01	0.01	0.01
query21	15.35	0.88	0.54
query22	0.77	1.18	0.61
query23	14.95	1.35	0.65
query24	7.35	1.91	1.02
query25	0.50	0.30	0.12
query26	0.73	0.17	0.14
query27	0.06	0.04	0.05
query28	9.47	0.79	0.42
query29	12.52	3.88	3.22
query30	0.25	0.09	0.07
query31	2.82	0.57	0.38
query32	3.23	0.56	0.45
query33	3.05	2.99	3.04
query34	15.82	5.14	4.56
query35	4.53	4.51	4.53
query36	0.66	0.49	0.48
query37	0.09	0.06	0.06
query38	0.05	0.04	0.03
query39	0.03	0.03	0.02
query40	0.17	0.14	0.12
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.04	0.03
Total cold run time: 105.5 s
Total hot run time: 30.81 s

eldenmoon

LGTM

…ache#48607) Related PR: introduce apache#46639 Problem Summary: After the change of apache#46639, shorten length for CHAR type escapes from checking of schema change. Fix in this PR and add some regression test cases to verify it.

…ar length with light schema change (#49452) Introduce: #48607, #46639 Problem Summary: Currently nested types only support light schema change for internal fields, for string types, only varchar can do light schema change.

…port length growing (#48025) ### What problem does this PR solve? cherry-pick from #46639 #48607 #49452 should be picked soon to resovle problem introduced by the pr Issue Number: close #xxx Co-authored-by: Siyang Tang <tangsiyang2001@foxmail.com>

…ar length with light schema change (apache#49452) Introduce: apache#48607, apache#46639 Problem Summary: Currently nested types only support light schema change for internal fields, for string types, only varchar can do light schema change.

…ache#48607) ### What problem does this PR solve? Related PR: introduce apache#46639 Problem Summary: After the change of apache#46639, shorten length for CHAR type escapes from checking of schema change. Fix in this PR and add some regression test cases to verify it.

…ar length with light schema change (apache#49452) Introduce: apache#48607, apache#46639 Problem Summary: Currently nested types only support light schema change for internal fields, for string types, only varchar can do light schema change.

Hastyshell force-pushed the fix-shorten-string-length branch 2 times, most recently from 3cf92f3 to 2f08f40 Compare March 4, 2025 05:19

[fix](schema-change) Check for string type length change is not compl…

52729b7

…eted

Hastyshell force-pushed the fix-shorten-string-length branch from 2f08f40 to 52729b7 Compare March 4, 2025 05:52

Hastyshell changed the title ~~[fix](schema-change) Check for string type length change is not completed~~ [fix](schema-change) Complete check for string type length change Mar 4, 2025

Hastyshell force-pushed the fix-shorten-string-length branch from 52729b7 to 0790619 Compare March 4, 2025 06:41

[fix](schema-change) Check for string type length change is not compl…

a491cc3

…eted

Hastyshell force-pushed the fix-shorten-string-length branch from 0790619 to a491cc3 Compare March 4, 2025 06:44

Hastyshell marked this pull request as ready for review March 4, 2025 06:45

Update Column.java

b250fbd

Update Column.java

689eaaa

Hastyshell added 2 commits March 4, 2025 19:48

merge

a7b4834

fix case

504f9cd

Update Column.java

c99c9ef

eldenmoon approved these changes Mar 4, 2025

View reviewed changes

eldenmoon added the dev/3.0.x label Mar 4, 2025

github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 4, 2025

github-actions bot added the reviewed label Mar 4, 2025

amorynan approved these changes Mar 4, 2025

View reviewed changes

Merge branch 'master' into fix-shorten-string-length

21e3200

eldenmoon approved these changes Mar 6, 2025

View reviewed changes

dataroaring merged commit 7cd9757 into apache:master Mar 6, 2025
24 checks passed

github-actions bot added the dev/3.0.x-conflict label Mar 6, 2025

Hastyshell mentioned this pull request Mar 25, 2025

[fix](schema-change) Nested types should only support enlarging varchar length with light schema change #49452

Merged

16 tasks

amorynan mentioned this pull request Mar 26, 2025

[improve](schema-change) support nested type with varchar type to support length growing #48025

Merged

16 tasks

dataroaring added dev/3.0.5-merged and removed dev/3.0.x dev/3.0.x-conflict labels Mar 27, 2025

[fix](schema-change) Complete check for string type length change #48607

[fix](schema-change) Complete check for string type length change #48607

Uh oh!

Conversation

Hastyshell commented Mar 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

hello-stephen commented Mar 4, 2025

Uh oh!

Hastyshell commented Mar 4, 2025

Uh oh!

doris-robot commented Mar 4, 2025

Uh oh!

doris-robot commented Mar 4, 2025

Uh oh!

doris-robot commented Mar 4, 2025

Uh oh!

Hastyshell commented Mar 4, 2025

Uh oh!

Hastyshell commented Mar 4, 2025

Uh oh!

doris-robot commented Mar 4, 2025

Uh oh!

doris-robot commented Mar 4, 2025

Uh oh!

doris-robot commented Mar 4, 2025

Uh oh!

Hastyshell commented Mar 4, 2025

Uh oh!

Hastyshell commented Mar 4, 2025

Uh oh!

eldenmoon left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 4, 2025

Uh oh!

github-actions bot commented Mar 4, 2025

Uh oh!

doris-robot commented Mar 4, 2025

Uh oh!

amorynan left a comment

Choose a reason for hiding this comment

Uh oh!

doris-robot commented Mar 4, 2025

Uh oh!

doris-robot commented Mar 4, 2025

Uh oh!

Hastyshell commented Mar 5, 2025

Uh oh!

Hastyshell commented Mar 5, 2025

Uh oh!

Hastyshell commented Mar 5, 2025

Uh oh!

Hastyshell commented Mar 5, 2025

Uh oh!

doris-robot commented Mar 5, 2025

Uh oh!

doris-robot commented Mar 5, 2025

Uh oh!

doris-robot commented Mar 5, 2025

Uh oh!

eldenmoon left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Hastyshell commented Mar 4, 2025 •

edited

Loading