Skip to content

Conversation

@Hastyshell
Copy link
Collaborator

What problem does this PR solve?

cherry-pick: #49452

Problem Summary:

Currently nested types only support light schema change for internal fields, for string types, only varchar can do light schema change.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

…ar length with light schema change (apache#49452)

Introduce: apache#48607, apache#46639

Problem Summary:

Currently nested types only support light schema change for internal
fields, for string types, only varchar can do light schema change.
@Hastyshell Hastyshell requested a review from dataroaring as a code owner March 27, 2025 11:42
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Hastyshell
Copy link
Collaborator Author

run buildall

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 27, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 40123 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 16b090ed5484214115741ee7123a385dae17f110, data reload: false

------ Round 1 ----------------------------------
q1	17586	6724	6605	6605
q2	2049	182	173	173
q3	10922	1083	1222	1083
q4	10543	746	733	733
q5	7742	2874	2820	2820
q6	221	135	132	132
q7	1001	625	613	613
q8	9359	1964	2065	1964
q9	6560	6405	6354	6354
q10	7052	2279	2277	2277
q11	459	260	266	260
q12	416	221	213	213
q13	17802	2986	2997	2986
q14	243	207	205	205
q15	511	466	463	463
q16	657	586	578	578
q17	1001	544	554	544
q18	7205	6606	6697	6606
q19	1398	1124	1041	1041
q20	470	195	200	195
q21	4116	3287	3384	3287
q22	1089	991	1007	991
Total cold run time: 108402 ms
Total hot run time: 40123 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6637	6575	6579	6575
q2	335	246	243	243
q3	2911	2799	2950	2799
q4	2059	1808	1793	1793
q5	5798	5765	5777	5765
q6	214	134	129	129
q7	2182	1851	1840	1840
q8	3433	3671	3598	3598
q9	8957	9099	8996	8996
q10	3647	3582	3508	3508
q11	589	488	491	488
q12	823	603	612	603
q13	9283	3229	3217	3217
q14	316	270	266	266
q15	517	464	458	458
q16	693	650	649	649
q17	1856	1622	1593	1593
q18	8287	7858	7571	7571
q19	1648	1542	1531	1531
q20	2111	1886	1856	1856
q21	5629	5485	5345	5345
q22	1178	1033	1015	1015
Total cold run time: 69103 ms
Total hot run time: 59838 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 198303 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 16b090ed5484214115741ee7123a385dae17f110, data reload: false

query1	1329	925	921	921
query2	6414	2090	2017	2017
query3	10942	4345	4584	4345
query4	66200	28444	23488	23488
query5	5021	455	439	439
query6	413	180	180	180
query7	5506	318	306	306
query8	294	208	213	208
query9	8472	2583	2575	2575
query10	449	275	258	258
query11	17297	15515	15716	15515
query12	167	105	101	101
query13	1453	450	449	449
query14	10728	7368	7339	7339
query15	211	182	187	182
query16	7065	517	497	497
query17	1095	582	585	582
query18	1856	310	312	310
query19	205	157	155	155
query20	116	110	109	109
query21	201	104	101	101
query22	4695	4729	4514	4514
query23	34335	34281	34072	34072
query24	6179	2906	2879	2879
query25	567	444	448	444
query26	661	172	170	170
query27	2079	360	380	360
query28	4514	2493	2464	2464
query29	722	477	459	459
query30	248	170	165	165
query31	1019	828	847	828
query32	69	64	59	59
query33	452	311	322	311
query34	924	505	506	505
query35	893	735	735	735
query36	1120	971	987	971
query37	120	73	72	72
query38	4273	3919	4114	3919
query39	1526	1471	1451	1451
query40	204	103	106	103
query41	51	52	49	49
query42	116	104	104	104
query43	538	495	500	495
query44	1171	809	806	806
query45	195	176	170	170
query46	1174	752	736	736
query47	2054	1900	1914	1900
query48	511	390	381	381
query49	756	415	424	415
query50	872	448	455	448
query51	7330	7267	7168	7168
query52	108	95	91	91
query53	262	191	188	188
query54	597	479	477	477
query55	80	81	78	78
query56	278	254	258	254
query57	1201	1109	1114	1109
query58	207	202	209	202
query59	3038	2973	2825	2825
query60	277	256	251	251
query61	105	104	108	104
query62	791	665	655	655
query63	224	198	200	198
query64	1376	688	644	644
query65	3259	3180	3144	3144
query66	696	297	304	297
query67	15818	15750	15746	15746
query68	3980	598	578	578
query69	440	266	266	266
query70	1199	1139	1126	1126
query71	355	267	261	261
query72	6357	3979	4049	3979
query73	772	350	349	349
query74	10252	9066	9165	9066
query75	3415	2670	2672	2670
query76	1860	1101	1113	1101
query77	506	287	287	287
query78	10587	9628	9628	9628
query79	1527	609	595	595
query80	863	426	426	426
query81	519	245	233	233
query82	1251	91	87	87
query83	168	149	145	145
query84	287	86	82	82
query85	879	321	289	289
query86	349	287	295	287
query87	4505	4298	4378	4298
query88	3810	2382	2365	2365
query89	422	297	282	282
query90	2007	195	184	184
query91	183	152	145	145
query92	69	53	50	50
query93	1864	554	553	553
query94	787	317	303	303
query95	351	263	260	260
query96	614	281	280	280
query97	3307	3215	3151	3151
query98	211	221	208	208
query99	1528	1276	1290	1276
Total cold run time: 318343 ms
Total hot run time: 198303 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.69 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 16b090ed5484214115741ee7123a385dae17f110, data reload: false

query1	0.03	0.03	0.03
query2	0.06	0.03	0.03
query3	0.24	0.07	0.07
query4	1.63	0.10	0.11
query5	0.52	0.49	0.49
query6	1.14	0.73	0.73
query7	0.02	0.02	0.02
query8	0.03	0.03	0.04
query9	0.57	0.50	0.50
query10	0.55	0.56	0.54
query11	0.14	0.10	0.11
query12	0.14	0.11	0.12
query13	0.61	0.59	0.60
query14	2.78	2.89	2.84
query15	0.90	0.83	0.82
query16	0.42	0.41	0.39
query17	0.95	1.05	1.00
query18	0.23	0.22	0.21
query19	1.99	1.88	2.01
query20	0.01	0.01	0.01
query21	15.36	0.58	0.57
query22	2.22	2.16	2.38
query23	16.93	1.09	0.82
query24	3.28	0.90	1.20
query25	0.33	0.16	0.16
query26	0.45	0.14	0.13
query27	0.05	0.04	0.04
query28	10.14	0.56	0.46
query29	12.55	3.25	3.26
query30	0.24	0.06	0.06
query31	2.84	0.40	0.39
query32	3.23	0.47	0.47
query33	2.96	3.04	2.98
query34	17.07	4.48	4.52
query35	4.58	4.53	4.67
query36	0.67	0.49	0.50
query37	0.08	0.06	0.07
query38	0.05	0.04	0.03
query39	0.03	0.02	0.02
query40	0.17	0.13	0.14
query41	0.08	0.02	0.03
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.34 s
Total hot run time: 32.69 s

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 7bf3705 into apache:branch-3.0 Mar 28, 2025
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants