Skip to content

MINOR Remove triage label in nightly job#18147

Merged
mumrah merged 20 commits intoapache:trunkfrom
mumrah:minor-auto-approve-pr-reviewed-workflow
Dec 18, 2024
Merged

MINOR Remove triage label in nightly job#18147
mumrah merged 20 commits intoapache:trunkfrom
mumrah:minor-auto-approve-pr-reviewed-workflow

Conversation

@mumrah
Copy link
Copy Markdown
Member

@mumrah mumrah commented Dec 11, 2024 •
edited
Loading

This patch adds a nightly job which removes the "triage" label from PRs which have been reviewed.

@github-actions github-actions bot added build Gradle build or GitHub Actions small Small PRs labels Dec 11, 2024
@mumrah
Copy link
Copy Markdown
Member Author

mumrah commented Dec 12, 2024

@gharris1727 another followup

@mumrah
Copy link
Copy Markdown
Member Author

mumrah commented Dec 16, 2024

@chia7712 could you take a look at this? The workflow to remove the "triage" label isn't running automatically and this PR should fix it.

@mumrah
Copy link
Copy Markdown
Member Author

mumrah commented Dec 16, 2024

Actually I'm realizing now this might not work. Since pull_request_review runs the workflow definition from the PR, it will require approval before running. However, for some reason the API call is failing on these approvals

$ gh api --method POST \
              -H 'Accept: application/vnd.github+json' \
              -H 'X-GitHub-Api-Version: 2022-11-28' \
              /repos/apache/kafka/actions/runs/12356775485/approve
{
  "message": "This run is not from a fork pull request",
  "documentation_url": "https://docs.github.com/rest/actions/workflow-runs#approve-a-workflow-run-for-a-fork-pull-request",
  "status": "403"
}
gh: This run is not from a fork pull request (HTTP 403)

I was able to approve the workflow in the UI, but not using the API. Maybe this is a bug in the pull_request_review event handling 🤷‍♂️

@github-actions github-actions bot removed the small Small PRs label Dec 16, 2024
@mumrah mumrah changed the title MINOR Auto-approve pr-reviewed workflow MINOR Remove triage label in nightly job Dec 16, 2024
@mumrah
Copy link
Copy Markdown
Member Author

mumrah commented Dec 16, 2024

Ok @chia7712, now it's ready for review 😄. I rewrote this workflow to run as a cron job rather than trying to react to the pull_request_review event.

@mumrah mumrah requested review from chia7712 and mimaison and removed request for chia7712 and gharris1727 December 17, 2024 14:11
@mumrah mumrah merged commit 5e9605a into apache:trunk Dec 18, 2024
ijuma added a commit to ijuma/kafka that referenced this pull request Dec 19, 2024
@ijuma
Merge remote-tracking branch 'apache-github/trunk' into kip-896-remov…
2d94927 
…e-old-protocol-versions

* apache-github/trunk: (25 commits)
  KAFKA-18270: FindCoordinator v0 incorrectly tagged as deprecated (apache#18262)
  KAFKA-18284: Add group coordinator records for Streams rebalance protocol (apache#18228)
  MINOR: Fix flaky state updater test (apache#18253)
  MINOR: improve StreamsResetter logging (apache#18237)
  KAFKA-18227: Ensure v2 partitions are not added to last transaction during upgrade (apache#18176)
  Add IT for share consumer with duration base offet auto reset (apache#18251)
  KAFKA-18283: Add StreamsGroupDescribe RPC definitions (apache#18230)
  KAFKA-18241: add docs check to CI (apache#18183)
  KAFKA-18223 Improve flaky test report (apache#18212)
  MINOR Remove triage label in nightly job (apache#18147)
  KAFKA-18294 Remove deprecated SourceTask#commitRecord (apache#18260)
  KAFKA-18264 Remove NotLeaderForPartitionException (apache#18211)
  KAFKA-13722: Refactor SerdeGetter (apache#18242)
  KAFKA-18094 Remove deprecated TopicListing(String, Boolean) (apache#18248)
  KAFKA-18282: Add StreamsGroupHeartbeat RPC definitions (apache#18227)
  KAFKA-18026: KIP-1112 migrate KTableSuppressProcessorSupplier (apache#18150)
  KAFKA-18026: transition KTable#filter impl to use processor wrapper (apache#18205)
  KAFKA-18293 Remove `org.apache.kafka.common.security.oauthbearer.secured.OAuthBearerLoginCallbackHandler` and `org.apache.kafka.common.security.oauthbearer.secured.OAuthBearerValidatorCallbackHandler` (apache#18244)
  MINOR: add assertion about groupEpoch and targetAssignmentEpoch to testConsumerGroups (apache#18203)
  KAFKA-17960; PlaintextAdminIntegrationTest.testConsumerGroups fails with CONSUMER group protocol (apache#18234)
  ...
@mumrah
Copy link
Copy Markdown
Member Author

mumrah commented Dec 19, 2024

It works 🎉 https://github.com/apache/kafka/actions/runs/12405547852/job/34632606547

@mumrah mumrah mentioned this pull request Dec 31, 2024
Merged
tedyu pushed a commit to tedyu/kafka that referenced this pull request Jan 6, 2025
@mumrah @tedyu
MINOR Remove triage label in nightly job (apache#18147)
d9f4b7b 
For PRs that have been reviewed (by anyone, not just a committer), remove the "triage" label. This job runs once per night.

Reviewers: Justine Olshan <jolshan@confluent.io>, Chia-Ping Tsai <chia7712@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chia7712 chia7712 chia7712 approved these changes

@jolshan jolshan jolshan approved these changes

@mimaison mimaison Awaiting requested review from mimaison

Assignees

No one assigned

Labels

build Gradle build or GitHub Actions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mumrah @chia7712 @jolshan