KAFKA-18284: Add group coordinator records for Streams rebalance protocol#18228
Merged
cadonna merged 4 commits intoapache:trunkfrom Dec 19, 2024
Merged
Conversation
Member
Author
|
Call for review: @aliehsaeedii |
cadonna
force-pushed
the
streams_rebalance_protocol_records
branch
from
d54ab94 to
4623f41
Compare
lucasbru
reviewed
Dec 18, 2024
Member
lucasbru
left a comment
lucasbru
left a comment
There was a problem hiding this comment.
Thanks for the PR. I left some comments!
| "commonStructs": [ | ||
| { "name": "Endpoint", "versions": "0+", "fields": [ | ||
| { "name": "Host", "type": "string", "versions": "0+", | ||
| "about": "host of the endpoint" }, |
Member
There was a problem hiding this comment.
All other "about" fields are capitalized and end with a ".".
| "flexibleVersions": "none", | ||
| "fields": [ | ||
| { "name": "GroupId", "type": "string", "versions": "17", | ||
| "about": "The group id." } |
Member
There was a problem hiding this comment.
nit: Probably we should try to use "ID" everywhere in the text, instead of "id".
| { "name": "key", "type": "string", "versions": "0+", | ||
| "about": "The key of the topic-level configuration." }, | ||
| { "name": "value", "type": "string", "versions": "0+", | ||
| "about": "The value of the topic-level configuration," } |
| "about": "The client host." }, | ||
| { "name": "RebalanceTimeoutMs", "type": "int32", "versions": "0+", "default": -1, | ||
| "about": "The rebalance timeout." }, | ||
|
|
Member
There was a problem hiding this comment.
not sure if blank lines serve any purpose in this file, maybe remove?
…ocol KIP-1071 specifies records that the group coordinator needs to store into the consumer offset topic to persist the state of a Streams group. This records are specified in json files from which the actual classes for the records are generated. This commit adds the records needed by the group corrdinator to store the state of a Streams group.
cadonna
force-pushed
the
streams_rebalance_protocol_records
branch
from
4623f41 to
b891876
Compare
lucasbru
approved these changes
Dec 18, 2024
Member
lucasbru
left a comment
lucasbru
left a comment
There was a problem hiding this comment.
Thanks for the PR. Looks good to me!
ijuma
added a commit
to ijuma/kafka
that referenced
this pull request
Dec 19, 2024
…e-old-protocol-versions * apache-github/trunk: (25 commits) KAFKA-18270: FindCoordinator v0 incorrectly tagged as deprecated (apache#18262) KAFKA-18284: Add group coordinator records for Streams rebalance protocol (apache#18228) MINOR: Fix flaky state updater test (apache#18253) MINOR: improve StreamsResetter logging (apache#18237) KAFKA-18227: Ensure v2 partitions are not added to last transaction during upgrade (apache#18176) Add IT for share consumer with duration base offet auto reset (apache#18251) KAFKA-18283: Add StreamsGroupDescribe RPC definitions (apache#18230) KAFKA-18241: add docs check to CI (apache#18183) KAFKA-18223 Improve flaky test report (apache#18212) MINOR Remove triage label in nightly job (apache#18147) KAFKA-18294 Remove deprecated SourceTask#commitRecord (apache#18260) KAFKA-18264 Remove NotLeaderForPartitionException (apache#18211) KAFKA-13722: Refactor SerdeGetter (apache#18242) KAFKA-18094 Remove deprecated TopicListing(String, Boolean) (apache#18248) KAFKA-18282: Add StreamsGroupHeartbeat RPC definitions (apache#18227) KAFKA-18026: KIP-1112 migrate KTableSuppressProcessorSupplier (apache#18150) KAFKA-18026: transition KTable#filter impl to use processor wrapper (apache#18205) KAFKA-18293 Remove `org.apache.kafka.common.security.oauthbearer.secured.OAuthBearerLoginCallbackHandler` and `org.apache.kafka.common.security.oauthbearer.secured.OAuthBearerValidatorCallbackHandler` (apache#18244) MINOR: add assertion about groupEpoch and targetAssignmentEpoch to testConsumerGroups (apache#18203) KAFKA-17960; PlaintextAdminIntegrationTest.testConsumerGroups fails with CONSUMER group protocol (apache#18234) ...
tedyu
pushed a commit
to tedyu/kafka
that referenced
this pull request
Jan 6, 2025
…ocol (apache#18228) KIP-1071 specifies records that the group coordinator needs to store into the consumer offset topic to persist the state of a Streams group. This records are specified in json files from which the actual classes for the records are generated. This commit adds the records needed by the group coordinator to store the state of a Streams group. Reviewer: Lucas Brutschy <lbrutschy@confluent.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KIP-1071 specifies records that the group coordinator needs to store into the consumer offset topic to persist the state of a Streams group. This records are specified in json files from which the actual classes for the records are generated.
This commit adds the records needed by the group corrdinator to store the state of a Streams group.
More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)