Skip to content

KAFKA-18283: Add StreamsGroupDescribe RPC definitions#18230

Merged
lucasbru merged 3 commits intoapache:trunkfrom
lucasbru:kip1071merge/describe_rpc
Dec 18, 2024
Merged

KAFKA-18283: Add StreamsGroupDescribe RPC definitions#18230
lucasbru merged 3 commits intoapache:trunkfrom
lucasbru:kip1071merge/describe_rpc

Conversation

@lucasbru
Copy link
Copy Markdown
Member

@lucasbru lucasbru commented Dec 17, 2024

Adds a new RPC StreamsGroupDescribe that returns, given the group ID, all metadata related to the streams group, such as

  • The topology metadata of the group.
  • The topology epoch of the group.
  • The latest member metadata that each member provided through the StreamsGroupHeartbeat API.
  • The current target assignment generated by the assignor.

This just adds the JSON as defined in KIP-1071, together with some plumbing.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@github-actions github-actions bot added core Kafka Broker clients labels Dec 17, 2024
@lucasbru lucasbru force-pushed the kip1071merge/describe_rpc branch from b4d217c to 9523195 Compare December 17, 2024 18:18
@lucasbru lucasbru force-pushed the kip1071merge/describe_rpc branch from 9523195 to 2e4c098 Compare December 18, 2024 10:45
@lucasbru lucasbru marked this pull request as ready for review December 18, 2024 10:45
Copy link
Copy Markdown
Member

@bbejeck bbejeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bbejeck
Copy link
Copy Markdown
Member

bbejeck commented Dec 18, 2024

There are test failures, but they don't seem related to this PR

@lucasbru lucasbru merged commit 0055ef0 into apache:trunk Dec 18, 2024
ijuma added a commit to ijuma/kafka that referenced this pull request Dec 19, 2024
…e-old-protocol-versions

* apache-github/trunk: (25 commits)
  KAFKA-18270: FindCoordinator v0 incorrectly tagged as deprecated (apache#18262)
  KAFKA-18284: Add group coordinator records for Streams rebalance protocol (apache#18228)
  MINOR: Fix flaky state updater test (apache#18253)
  MINOR: improve StreamsResetter logging (apache#18237)
  KAFKA-18227: Ensure v2 partitions are not added to last transaction during upgrade (apache#18176)
  Add IT for share consumer with duration base offet auto reset (apache#18251)
  KAFKA-18283: Add StreamsGroupDescribe RPC definitions (apache#18230)
  KAFKA-18241: add docs check to CI (apache#18183)
  KAFKA-18223 Improve flaky test report (apache#18212)
  MINOR Remove triage label in nightly job (apache#18147)
  KAFKA-18294 Remove deprecated SourceTask#commitRecord (apache#18260)
  KAFKA-18264 Remove NotLeaderForPartitionException (apache#18211)
  KAFKA-13722: Refactor SerdeGetter (apache#18242)
  KAFKA-18094 Remove deprecated TopicListing(String, Boolean) (apache#18248)
  KAFKA-18282: Add StreamsGroupHeartbeat RPC definitions (apache#18227)
  KAFKA-18026: KIP-1112 migrate KTableSuppressProcessorSupplier (apache#18150)
  KAFKA-18026: transition KTable#filter impl to use processor wrapper (apache#18205)
  KAFKA-18293 Remove `org.apache.kafka.common.security.oauthbearer.secured.OAuthBearerLoginCallbackHandler` and `org.apache.kafka.common.security.oauthbearer.secured.OAuthBearerValidatorCallbackHandler` (apache#18244)
  MINOR: add assertion about groupEpoch and targetAssignmentEpoch to testConsumerGroups (apache#18203)
  KAFKA-17960; PlaintextAdminIntegrationTest.testConsumerGroups fails with CONSUMER group protocol (apache#18234)
  ...
tedyu pushed a commit to tedyu/kafka that referenced this pull request Jan 6, 2025
Adds a new RPC StreamsGroupDescribe that returns, given the group ID, all metadata related to the streams group, such as

 - The topology metadata of the group.
 - The topology epoch of the group.
 - The latest member metadata that each member provided through the StreamsGroupHeartbeat API.
 - The current target assignment generated by the assignor.
 - This just adds the JSON as defined in KIP-1071, together with some plumbing.

Reviewers: Bill Bejeck <bbejeck@gmail.com>
@lucasbru lucasbru added KIP-1071 PRs related to KIP-1071 streams labels Feb 5, 2025
{ "name": "Offset", "type": "int64", "versions": "0+",
"about": "The offset." }
]},
{ "name": "TopicPartitions", "versions": "0+", "fields": [
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this common struct does not seems to be used, should we remove it?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find!

#20864

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clients core Kafka Broker KIP-1071 PRs related to KIP-1071 streams

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants