Bug Hotfix: consumer poll blocked & FetchResponse cast error#4858
Closed
koqizhao wants to merge 8 commits intoapache:trunkfrom
Closed
Bug Hotfix: consumer poll blocked & FetchResponse cast error#4858koqizhao wants to merge 8 commits intoapache:trunkfrom
koqizhao wants to merge 8 commits intoapache:trunkfrom
Conversation
koqizhao
commented
Apr 12, 2018
koqizhao
commented
- fix bug: consumer poll(timeout) blocked infinitely when no available bootstrap server
- fix bug: FindCoordinatorResponse cannot be cast to FetchResponse
Author
|
bug "consumer poll blocked" is found in 0.10.x versions in: Yesterday I found it in 1.1.0 as well and made a fix. |
Reviewers: Jun Rao <junrao@gmail.com>
…249) (apache#4427) Reviewers: Jun Rao <junrao@gmail.com>
KIP: https://cwiki.apache.org/confluence/display/KAFKA/KIP-222+-+Add+Consumer+Group+operations+to+Admin+API Author: Jorge Quilcate Otoya <quilcate.jorge@gmail.com> Author: Jorge Esteban Quilcate Otoya <quilcate.jorge@gmail.com> Author: Guozhang Wang <wangguoz@gmail.com> Reviewers: Colin Patrick McCabe <colin@cmccabe.xyz>, Guozhang Wang <wangguoz@gmail.com> Closes apache#4454 from jeqo/feature/admin-client-describe-consumer-group
…he#4852) Reviewers: Manikumar Reddy O <manikumar.reddy@gmail.com>, Jason Gustafson <jason@confluent.io>
…pache#4450) AsyncProducerTest gets an error about an incorrect mock when the logging level is turned up. Instead of usIng a mock, just create a real SyncProducerConfig object, since the object is simple to create. Reviewers: Ismael Juma <ismael@juma.me.uk>
…pId (apache#4851) We had a regression in apache#4788 which caused the offset commit/fetch/describe APIs to fail if the groupId was empty. This should be allowed for backwards compatibility. Additionally, I have modified DeleteGroups to allow removal of the empty group, which was missed in the initial implementation. I've added a test case to ensure that we do not miss this again in the future. Reviewers: Ismael Juma <ismael@juma.me.uk>
This change makes adding a metric to a sensor idempotent. That is, if the metric is already added to the sensor, the method returns with success. The current behavior is that any attempt to register a second metric with the same name is an error. Testing strategy: There is a new unit test covering this behavior Reviewers: Guozhang Wang <guozhang@confluent.io>, Bill Bejeck <bill@confluent.io>
bootstrap server fix bug: FindCoordinatorResponse cannot be cast to FetchResponse
koqizhao
force-pushed
the
hotfix-consumer-poll-blocked
branch
from
ce4ba84 to
2410c4e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.