KAFKA-7660: fix streams and Metrics memory leaks#5979
Merged
mjsax merged 2 commits intoapache:2.1from Dec 4, 2018
vvcephei:2.1-memory-leaks
Merged
KAFKA-7660: fix streams and Metrics memory leaks#5979mjsax merged 2 commits intoapache:2.1from vvcephei:2.1-memory-leaks
mjsax merged 2 commits intoapache:2.1from
vvcephei:2.1-memory-leaks
Conversation
In StreamsMetricsImpl, the parentSensors map was keeping references to Sensors after the sensors themselves had been removed. Reviewers: Matthias J. Sax <matthias@confluent.io>, Bill Bejeck <bill@confluent.io>, Guozhang Wang <wangguoz@gmail.com>
A heap dump provided by Patrik Kleindl in https://issues.apache.org/jira/browse/KAFKA-7660 identifies the childrenSensors map in Metrics as keeping references to sensors alive after they have been removed. This PR fixes it and adds a test to be sure. Reviewers: Jason Gustafson <jason@confluent.io>, Guozhang Wang <wangguoz@gmail.com>
Contributor
Author
|
@mjsax @guozhangwang , This backports a couple of small memory-leak fixes from trunk. I'm not sure if you want to keep them as separate commits in the backport as well... |
This was referenced Nov 30, 2018
vvcephei
changed the title
This was referenced Nov 30, 2018
Contributor
Author
|
Thanks, @mjsax ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport two memory-leak fixes (#5974 and #5953)
Committer Checklist (excluded from commit message)