KAFKA-7660: fix streams and Metrics memory leaks#5982
Merged
mjsax merged 2 commits intoapache:1.0from Dec 6, 2018
vvcephei:1.0-memory-leaks
Merged
KAFKA-7660: fix streams and Metrics memory leaks#5982mjsax merged 2 commits intoapache:1.0from vvcephei:1.0-memory-leaks
mjsax merged 2 commits intoapache:1.0from
vvcephei:1.0-memory-leaks
Conversation
A heap dump provided by Patrik Kleindl in https://issues.apache.org/jira/browse/KAFKA-7660 identifies the childrenSensors map in Metrics as keeping references to sensors alive after they have been removed. This PR fixes it and adds a test to be sure. Reviewers: Jason Gustafson <jason@confluent.io>, Guozhang Wang <wangguoz@gmail.com>
This was referenced Nov 30, 2018
Contributor
Author
|
@ijuma , sorry to spam you, but I think it might be easier to deal with this in a batch... |
Member
|
Retest this please |
Member
|
retest this please |
Member
|
This branch doesn't work fully with Java 10 either, just Java 9. The 10 failures with Java 10 are expected. |
Contributor
Author
|
Just to clarify about the expected failure. It seems to be an incompatibility between java 10 and easymock: |
Member
|
Yeah, the ASM version used by EasyMock in this branch is too old. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport two memory-leak fixes (#5974 and #5953) (see also 2.1: #5979, 2.0: #5980, 1.1: #5981 )
It looks like we already had the parentSensors fix in 1.0 and lost it in 2.0. The change in
this PR just tidies it up a little for consistency with later branches.
Committer Checklist (excluded from commit message)