Skip to content

KAFKA-7660: fix streams and Metrics memory leaks#5984

Merged
mjsax merged 2 commits intoapache:0.10.2from
vvcephei:0.10.2-memory-leaks
Dec 6, 2018
Merged

KAFKA-7660: fix streams and Metrics memory leaks#5984
mjsax merged 2 commits intoapache:0.10.2from
vvcephei:0.10.2-memory-leaks

Conversation

@vvcephei
Copy link
Copy Markdown
Contributor

Backport two memory-leak fixes (#5974 and #5953) (see also 2.1: #5979, 2.0: #5980, 1.1: #5981, 1.0: #5982, 0.11: #5983 )

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

vvcephei and others added 2 commits November 30, 2018 17:41
A heap dump provided by Patrik Kleindl in https://issues.apache.org/jira/browse/KAFKA-7660 identifies the childrenSensors map in Metrics as keeping references to sensors alive after they have been removed.

This PR fixes it and adds a test to be sure.

Reviewers: Jason Gustafson <jason@confluent.io>, Guozhang Wang <wangguoz@gmail.com>
@asfgit
Copy link
Copy Markdown

asfgit commented Dec 1, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/3817/
Test FAILed (JDK 7 and Scala 2.10).

@mjsax
Copy link
Copy Markdown
Member

mjsax commented Dec 1, 2018

Retest this please

@asfgit
Copy link
Copy Markdown

asfgit commented Dec 1, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/3818/
Test FAILed (JDK 7 and Scala 2.10).

@mjsax
Copy link
Copy Markdown
Member

mjsax commented Dec 2, 2018

Retest this please

@asfgit
Copy link
Copy Markdown

asfgit commented Dec 2, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/3819/
Test FAILed (JDK 7 and Scala 2.10).

@ijuma
Copy link
Copy Markdown
Member

ijuma commented Dec 2, 2018

retest this please

@asfgit
Copy link
Copy Markdown

asfgit commented Dec 2, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/3820/
Test FAILed (JDK 7 and Scala 2.10).

@vvcephei
Copy link
Copy Markdown
Contributor Author

vvcephei commented Dec 3, 2018

Both of the builds timed out after 3 hours.

Retest this, please.

@asfgit
Copy link
Copy Markdown

asfgit commented Dec 4, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/3821/
Test FAILed (JDK 7 and Scala 2.10).

@mjsax
Copy link
Copy Markdown
Member

mjsax commented Dec 4, 2018

QueryableStateIntegrationTest is known to be unstable... Will try again. If we can't get a green build, and test pass locally, we can merge, too, IMHO. Objections?

Retest this please.

@asfgit
Copy link
Copy Markdown

asfgit commented Dec 4, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/3822/
Test FAILed (JDK 7 and Scala 2.10).

@vvcephei
Copy link
Copy Markdown
Contributor Author

vvcephei commented Dec 4, 2018

@mjsax , ./gradlew clean :streams:test does pass for me locally on this branch.

@vvcephei
Copy link
Copy Markdown
Contributor Author

vvcephei commented Dec 5, 2018

Might as well try again...

Retest this, please.

@asfgit
Copy link
Copy Markdown

asfgit commented Dec 6, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/3823/
Test FAILed (JDK 7 and Scala 2.10).

@mjsax
Copy link
Copy Markdown
Member

mjsax commented Dec 6, 2018

Tests passed locally for me. Merging.

@mjsax mjsax merged commit fdc742b into apache:0.10.2 Dec 6, 2018
@vvcephei vvcephei deleted the 0.10.2-memory-leaks branch December 7, 2018 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants