KAFKA-9855 - return cached Structs for Schemas with no fields#8472
Merged
ijuma merged 1 commit intoapache:trunkfrom May 21, 2020
radai-rosenblatt:struct-perf
Merged
KAFKA-9855 - return cached Structs for Schemas with no fields#8472ijuma merged 1 commit intoapache:trunkfrom radai-rosenblatt:struct-perf
ijuma merged 1 commit intoapache:trunkfrom
radai-rosenblatt:struct-perf
Conversation
Signed-off-by: radai-rosenblatt <radai.rosenblatt@gmail.com>
Contributor
Author
|
@hachikuji @ijuma - this accounted for ~1.3 GB of ~wasted heap space for us for at least one cluster. for your consideration? |
radai-rosenblatt
added a commit
to linkedin/kafka
that referenced
this pull request
Apr 15, 2020
…elds (#77) TICKET = LI_DESCERIPTION = committing to our fork until upstream picks this up EXIT_CRITERIA = when KAFKA-9855 is accepted upstream (specifically - apache#8472) Signed-off-by: radai-rosenblatt <radai.rosenblatt@gmail.com>
Member
|
ok to test |
Contributor
Author
|
@ijuma - any more modifications required? |
Member
|
I have a WIP PR that removes structs altogether, but this is a good improvement in the meantime. Merging to trunk. Thanks. |
Kvicii
pushed a commit
to Kvicii/kafka
that referenced
this pull request
May 22, 2020
* 'trunk' of github.com:apache/kafka: KAFKA-9980: Fix bug where alterClientQuotas could not set default client quotas (apache#8658) KAFKA-9780: Deprecate commit records without record metadata (apache#8379) MINOR: Deploy VerifiableClient in constructor to avoid test timeouts (apache#8651) MINOR: Added unit tests for ConnectionQuotas (apache#8650) MINOR: Correct MirrorMaker2 integration test configs for Connect internal topics (apache#8653) KAFKA-9855 - return cached Structs for Schemas with no fields (apache#8472) KAFKA-9950: Construct new ConfigDef for MirrorTaskConfig before defining new properties (apache#8608) KAFKA-8869: Remove task configs for deleted connectors from config snapshot (apache#8444) KAFKA-9409: Supplement immutability of ClusterConfigState class in Connect (apache#7942)
gitlw
pushed a commit
to linkedin/kafka
that referenced
this pull request
Jun 13, 2020
…elds (#77) TICKET = LI_DESCERIPTION = committing to our fork until upstream picks this up EXIT_CRITERIA = when KAFKA-9855 is accepted upstream (specifically - apache#8472) Signed-off-by: radai-rosenblatt <radai.rosenblatt@gmail.com>
gitlw
pushed a commit
to linkedin/kafka
that referenced
this pull request
Jun 13, 2020
…elds (#77) TICKET = LI_DESCERIPTION = committing to our fork until upstream picks this up EXIT_CRITERIA = when KAFKA-9855 is accepted upstream (specifically - apache#8472) Signed-off-by: radai-rosenblatt <radai.rosenblatt@gmail.com>
gitlw
pushed a commit
to linkedin/kafka
that referenced
this pull request
Jun 17, 2020
…elds (#77) TICKET = LI_DESCERIPTION = committing to our fork until upstream picks this up EXIT_CRITERIA = when KAFKA-9855 is accepted upstream (specifically - apache#8472) Signed-off-by: radai-rosenblatt <radai.rosenblatt@gmail.com>
gitlw
pushed a commit
to linkedin/kafka
that referenced
this pull request
Jun 17, 2020
…elds (#77) TICKET = LI_DESCERIPTION = committing to our fork until upstream picks this up EXIT_CRITERIA = when KAFKA-9855 is accepted upstream (specifically - apache#8472) Signed-off-by: radai-rosenblatt <radai.rosenblatt@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: radai-rosenblatt radai.rosenblatt@gmail.com
at the time of this writing there are 6 schemas in kafka APIs with no fields - 3 versions each of LIST_GROUPS and API_VERSIONS.
when reading instances of these schemas off the wire there's little point in returning a unique Struct object (or a unique values array inside that Struct) since there is no payload.
Committer Checklist (excluded from commit message)