Skip to content

MINOR: Correct MirrorMaker2 integration test configs for Connect internal topics#8653

Merged
rhauch merged 1 commit intoapache:trunkfrom
rhauch:fix-mirrormaker-test-topic-configs
May 21, 2020
Merged

MINOR: Correct MirrorMaker2 integration test configs for Connect internal topics#8653
rhauch merged 1 commit intoapache:trunkfrom
rhauch:fix-mirrormaker-test-topic-configs

Conversation

@rhauch
Copy link
Copy Markdown
Contributor

@rhauch rhauch commented May 12, 2020

The replication factor for the Connect workers’ internal topics were incorrectly named and not actually used.

This only affects & fixes tests, and should be backported all the way back to the 2.4 branch.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

…rnal topics

The replication factor for the Connect workers’ internal topics were incorrectly named and not actually used.
@rhauch rhauch requested a review from kkonstantine May 12, 2020 14:06
Copy link
Copy Markdown
Contributor

@ryannedolan ryannedolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

Copy link
Copy Markdown
Contributor

@kkonstantine kkonstantine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhauch rhauch merged commit d4ffc24 into apache:trunk May 21, 2020
rhauch added a commit that referenced this pull request May 21, 2020
…rnal topics (#8653)

The replication factor for the Connect workers’ internal topics were incorrectly named and not actually used.
rhauch added a commit that referenced this pull request May 21, 2020
…rnal topics (#8653)

The replication factor for the Connect workers’ internal topics were incorrectly named and not actually used.
@rhauch rhauch deleted the fix-mirrormaker-test-topic-configs branch May 21, 2020 18:04
Kvicii pushed a commit to Kvicii/kafka that referenced this pull request May 22, 2020
* 'trunk' of github.com:apache/kafka:
  KAFKA-9980: Fix bug where alterClientQuotas could not set default client quotas (apache#8658)
  KAFKA-9780: Deprecate commit records without record metadata (apache#8379)
  MINOR: Deploy VerifiableClient in constructor to avoid test timeouts (apache#8651)
  MINOR: Added unit tests for ConnectionQuotas (apache#8650)
  MINOR: Correct MirrorMaker2 integration test configs for Connect internal topics (apache#8653)
  KAFKA-9855 - return cached Structs for Schemas with no fields (apache#8472)
  KAFKA-9950: Construct new ConfigDef for MirrorTaskConfig before defining new properties (apache#8608)
  KAFKA-8869: Remove task configs for deleted connectors from config snapshot (apache#8444)
  KAFKA-9409: Supplement immutability of ClusterConfigState class in Connect (apache#7942)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants