KAFKA-9980: Fix bug where alterClientQuotas could not set default client quotas#8658
Merged
cmccabe merged 2 commits intoapache:trunkfrom May 22, 2020
Merged
KAFKA-9980: Fix bug where alterClientQuotas could not set default client quotas#8658cmccabe merged 2 commits intoapache:trunkfrom
cmccabe merged 2 commits intoapache:trunkfrom
Conversation
Contributor
Author
|
I've applied @d8tltanc's updates to |
Contributor
Author
|
@cmccabe this is ready for review. Thanks! |
Contributor
|
ok to test |
Contributor
Author
|
Both test failures in |
cmccabe
changed the title
Contributor
|
LGTM. Thanks, @bdbyrne . |
Kvicii
pushed a commit
to Kvicii/kafka
that referenced
this pull request
May 22, 2020
* 'trunk' of github.com:apache/kafka: KAFKA-9980: Fix bug where alterClientQuotas could not set default client quotas (apache#8658) KAFKA-9780: Deprecate commit records without record metadata (apache#8379) MINOR: Deploy VerifiableClient in constructor to avoid test timeouts (apache#8651) MINOR: Added unit tests for ConnectionQuotas (apache#8650) MINOR: Correct MirrorMaker2 integration test configs for Connect internal topics (apache#8653) KAFKA-9855 - return cached Structs for Schemas with no fields (apache#8472) KAFKA-9950: Construct new ConfigDef for MirrorTaskConfig before defining new properties (apache#8608) KAFKA-8869: Remove task configs for deleted connectors from config snapshot (apache#8444) KAFKA-9409: Supplement immutability of ClusterConfigState class in Connect (apache#7942)
3 tasks
gitlw
pushed a commit
to linkedin/kafka
that referenced
this pull request
Sep 9, 2021
…s could not set default client quotas (apache#8658) Reviewers: Colin P. McCabe <cmccabe@apache.org>
|
Sorry for resurrecting an old thread but I'm still experiencing this in Kafka 2.6.2 with Java kafka-clients 2.6.2. What am I missing here so that the |
|
From the comments on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where the default entity name
"<default>"was erroneouslybeing sanitized, which prevented proper inheritance of default configs.
Committer Checklist (excluded from commit message)